thermal: imx8mm_thermal: validate temperature range
Subsystems (2)
PATCH v3 1/1 thermal: imx8mm_thermal: validate temperature range
Check against the upper temperature limit (125 degrees C) before consider the temperature valid.
---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)
v3: Only check temperature range as the valid bit is invalid.
drivers/thermal/imx8mm_thermal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/thermal/imx8mm_thermal.c +7 -1
@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)u32 val; val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + +/* +* Do not validate against the V bit (bit 31) due to errata +* ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid +*/ + *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) +if (*temp <VER1_TEMP_LOW_LIMIT || *temp >VER2_TEMP_HIGH_LIMIT )return -EAGAIN ;return 0 ;
Signature · 1 line
2.37.1
Quoted 37 lines
Subject: [PATCH v3] thermal:
imx8mm_thermal: validate temperature rangeCheck against the upper temperature limit (125 degrees C) before consider the temperature valid.
Fixes 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermalmonitoring unit")
Signed-off-by Marcus Folkesson <[email protected]>---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)
v3: Only check temperature range as the valid bit is invalid.drivers/thermal/imx8mm_thermal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/thermal/imx8mm_thermal.c +4
-0@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)u32 val; val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + +/* +* Do not validate against the V bit (bit 31) due to errata +* ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid
drivers/thermal/imx8mm_thermal.c +3
-1+*/ + *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) + if (*temp < VER1_TEMP_LOW_LIMIT || *temp >
Quoted 1 line
VER2_TEMP_HIGH_LIMIT)
Don't remember the reason why I only add low limit check before. Should be ok to check the high limit.
BR
Quoted 5 lines
drivers/thermal/imx8mm_thermal.c +0
-1return -EAGAIN ;return 0 ; --2.37.1
Daniel Lezcano
AppliedQuoted 6 lines · Marcus Folkesson
Check against the upper temperature limit (125 degrees C) before consider the temperature valid.
Fixes 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")Signed-off-by Marcus Folkesson <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 24 lines · Marcus Folkesson
Check against the upper temperature limit (125 degrees C) before consider the temperature valid.
Fixes 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")Signed-off-by Marcus Folkesson <[email protected]>---
Notes:
v2: Also invalidate if temperature > max (125 degrees C)
v3: Only check temperature range as the valid bit is invalid.drivers/thermal/imx8mm_thermal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/thermal/imx8mm_thermal.c +2
-0@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)u32 val; val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + +/*
drivers/thermal/imx8mm_thermal.c static int imx8mm_tmu_get_temp(void *data, int *temp) · line 78
Quoted 10 lines
drivers/thermal/imx8mm_thermal.c +5
-1+* Do not validate against the V bit (bit 31) due to errata +* ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid +*/ + *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) +if (*temp <VER1_TEMP_LOW_LIMIT || *temp >VER2_TEMP_HIGH_LIMIT )return -EAGAIN ;return 0 ;
[thermal: thermal/next] thermal/drivers/imx8mm_thermal: Validate temperature range
In reply to Marcus FolkessonThe following commit has been merged into the thermal/next branch of thermal:
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 86f0836ca9f6669993da7feba0a04d21506e05e0 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//86f0836ca9f6669993da7feba0a04d21506e05e0 Author: Marcus Folkesson <[email protected]> AuthorDate: Fri, 14 Oct 2022 09:35:07 +02:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Thu, 08 Dec 2022 14:30:43 +01:00
thermal/drivers/imx8mm_thermal: Validate temperature range
Check against the upper temperature limit (125 degrees C) before consider the temperature valid.
--- drivers/thermal/imx8mm_thermal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/thermal/imx8mm_thermal.c +7 -1
@@ -65,8 +65,14 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)u32 val; val =readl_relaxed (tmu->base +TRITSR ) &TRITSR_TEMP0_VAL_MASK ; + +/* +* Do not validate against the V bit (bit 31) due to errata +* ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid +*/ + *temp = val *1000 ; -if (*temp <VER1_TEMP_LOW_LIMIT ) +if (*temp <VER1_TEMP_LOW_LIMIT || *temp >VER2_TEMP_HIGH_LIMIT )return -EAGAIN ;return 0 ;