md-bitmap: reuse former bitmap chunk size on resizing.
RFC PATCH 1/1 md-bitmap: reuse former bitmap chunk size on resizing.
From: Florian-Ewald Mueller <[email protected]>
On bitmap resizing, attempt to reuse the former chunk size (if any) in order to preserve the, ev. on purpose set, chunk size resolution.
--- drivers/md/md-cluster.c | 3 ++- drivers/md/raid1.c | 3 ++- drivers/md/raid10.c | 12 ++++++++---- drivers/md/raid5.c | 3 ++- 4 files changed, 14 insertions(+), 7 deletions(-)
drivers/md/md-cluster.c +2 -1
@@ -604,7 +604,8 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)case BITMAP_RESIZE :if (le64_to_cpu (msg->high) != mddev->pers->size (mddev,0 ,0 )) ret =md_bitmap_resize (mddev->bitmap, -le64_to_cpu (msg->high),0 ,0 ); +le64_to_cpu (msg->high), + mddev->bitmap_info.chunksize,0 );break ;default : ret =-1 ;
drivers/md/raid1.c +2 -1
@@ -3225,7 +3225,8 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }
drivers/md/raid10.c +8 -4
@@ -4346,7 +4346,8 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > size)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, size,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, size, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }
@@ -4618,7 +4619,8 @@ static int raid10_start_reshape(struct mddev *mddev) newsize =raid10_size (mddev,0 , conf->geo.raid_disks);if (!mddev_is_clustered (mddev)) { - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort;else
@@ -4640,13 +4642,15 @@ static int raid10_start_reshape(struct mddev *mddev) MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize)) goto out; - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort; ret = md_cluster_ops->resize_bitmaps (mddev, newsize, oldsize);if (ret) { -md_bitmap_resize (mddev->bitmap, oldsize,0 ,0 ); +md_bitmap_resize (mddev->bitmap, oldsize, + mddev->bitmap_info.chunksize,0 ); goto abort; } }
drivers/md/raid5.c +2 -1
@@ -8372,7 +8372,8 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, sectors,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, sectors, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }
Signature · 1 line
2.34.1
Song Liu
maintainerQuoted 5 lines · Jack Wang
From: Florian-Ewald Mueller <[email protected]>
On bitmap resizing, attempt to reuse the former chunk size (if any) in order to preserve the, ev. on purpose set, chunk size resolution.
Could you please explain more on why we would rather keep the chunk size instead of recalculating it?
Thanks,
Song
Quoted 97 lines
Signed-off-by Florian-Ewald Mueller <[email protected]>Signed-off-by Jack Wang <[email protected]>--- drivers/md/md-cluster.c | 3 ++- drivers/md/raid1.c | 3 ++- drivers/md/raid10.c | 12 ++++++++---- drivers/md/raid5.c | 3 ++- 4 files changed, 14 insertions(+), 7 deletions(-)drivers/md/md-cluster.c +2
-1@@ -604,7 +604,8 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)case BITMAP_RESIZE :if (le64_to_cpu (msg->high) != mddev->pers->size (mddev,0 ,0 )) ret =md_bitmap_resize (mddev->bitmap, -le64_to_cpu (msg->high),0 ,0 ); +le64_to_cpu (msg->high), + mddev->bitmap_info.chunksize,0 );break ;default : ret =-1 ;drivers/md/raid1.c +2
-1@@ -3225,7 +3225,8 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }drivers/md/raid10.c +8
-4@@ -4346,7 +4346,8 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > size)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, size,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, size, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }@@ -4618,7 +4619,8 @@ static int raid10_start_reshape(struct mddev *mddev) newsize =raid10_size (mddev,0 , conf->geo.raid_disks);if (!mddev_is_clustered (mddev)) { - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort;else @@ -4640,13 +4642,15 @@ static int raid10_start_reshape(struct mddev *mddev) MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize)) goto out; - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort; ret = md_cluster_ops->resize_bitmaps (mddev, newsize, oldsize);if (ret) { -md_bitmap_resize (mddev->bitmap, oldsize,0 ,0 ); +md_bitmap_resize (mddev->bitmap, oldsize, + mddev->bitmap_info.chunksize,0 ); goto abort; } }drivers/md/raid5.c +2
-2@@ -8372,7 +8372,8 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, sectors,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, sectors, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; } --2.34.1
A message that is not in the archive (sent off-list or not yet received): CAHJVUej9hgzH2FH1r2hsVwoBqbnCvi8PWM9j=m5ih_raxCZSpA@mail.gmail.com
Quoted 12 lines · Florian-Ewald Müller
Hello Song,
Thank you for taking this patch into consideration. This patch was indeed meant only as a RFC.
We have, sometimes, the situation that a md-raid1 device of e.g. size=128G, created with bitmap=internal and bitmap-chunk=256M, needs to be resized to (let's say) size=8T.
We originally set the bitmap-chunk=256M because we found it a good compromise between performance and resync speed. With that bitmap-chunk=256G and the starting size=128G, the md-bitmap code will use only 512 bits fitting into a page (4K).
Quoted 10 lines
When resizing to size=8T, the md-bitmap code will attempt to reuse the space available (4k) and calculate a bitmap-chunk=2G. We found here that such a huge bitmap-chunk (2G) is not so suitable for an eventual, later resync process. Also taking into consideration that IOPS issued on the now resized device won't increase/differ significantly.
This is a particular usage scenario and the effect of this patch may, indeed, not be optimal in some other use case.
Best regards,
Florian
resent with plain text, so it's available on mainlist
Quoted 113 lines · Song Liu
Quoted 111 lines · Jack Wang
Quoted 5 lines
From: Florian-Ewald Mueller <[email protected]>
On bitmap resizing, attempt to reuse the former chunk size (if any) in order to preserve the, ev. on purpose set, chunk size resolution.
Could you please explain more on why we would rather keep the chunk size instead of recalculating it?
Thanks,
SongQuoted 97 lines
Signed-off-by Florian-Ewald Mueller <[email protected]>Signed-off-by Jack Wang <[email protected]>--- drivers/md/md-cluster.c | 3 ++- drivers/md/raid1.c | 3 ++- drivers/md/raid10.c | 12 ++++++++---- drivers/md/raid5.c | 3 ++- 4 files changed, 14 insertions(+), 7 deletions(-)drivers/md/md-cluster.c +2
-1@@ -604,7 +604,8 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)case BITMAP_RESIZE :if (le64_to_cpu (msg->high) != mddev->pers->size (mddev,0 ,0 )) ret =md_bitmap_resize (mddev->bitmap, -le64_to_cpu (msg->high),0 ,0 ); +le64_to_cpu (msg->high), + mddev->bitmap_info.chunksize,0 );break ;default : ret =-1 ;drivers/md/raid1.c +2
-1@@ -3225,7 +3225,8 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }drivers/md/raid10.c +8
-4@@ -4346,7 +4346,8 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > size)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, size,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, size, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; }@@ -4618,7 +4619,8 @@ static int raid10_start_reshape(struct mddev *mddev) newsize =raid10_size (mddev,0 , conf->geo.raid_disks);if (!mddev_is_clustered (mddev)) { - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort;else @@ -4640,13 +4642,15 @@ static int raid10_start_reshape(struct mddev *mddev) MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize)) goto out; - ret =md_bitmap_resize (mddev->bitmap, newsize,0 ,0 ); + ret =md_bitmap_resize (mddev->bitmap, newsize, + mddev->bitmap_info.chunksize,0 );if (ret) goto abort; ret = md_cluster_ops->resize_bitmaps (mddev, newsize, oldsize);if (ret) { -md_bitmap_resize (mddev->bitmap, oldsize,0 ,0 ); +md_bitmap_resize (mddev->bitmap, oldsize, + mddev->bitmap_info.chunksize,0 ); goto abort; } }drivers/md/raid5.c +2
-2@@ -8372,7 +8372,8 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors) mddev->array_sectors > newsize)return -EINVAL ;if (mddev->bitmap) { -int ret =md_bitmap_resize (mddev->bitmap, sectors,0 ,0 ); +int ret =md_bitmap_resize (mddev->bitmap, sectors, + mddev->bitmap_info.chunksize,0 );if (ret)return ret; } --2.34.1