Skip to contentSkip to conversation

rtlwifi: update firmware for rtl8192eu to v35.7

PATCH In review James Hilliard 3 participants 7 messages Oct 14, 2022 – Oct 20, 2022 Arm/actions semi architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtlwifi: update firmware for rtl8192eu to v35.7

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8192eu_ap.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..a6fcfc8b4bb9e3abbad78212cf6aee857740ddc2
GIT binary patch
rtlwifi/rtl8192eu_nic.bin binary +0 -0
index 4a034d3ae8910df49682876dfe44fe8690798825..4ee03e8842953cd6a2b122c54a7fd71e91176c38 100644
GIT binary patch
rtlwifi/rtl8192eu_nic_setupbox.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..245fe08f792fe4b9be7d8e55da9b2e0627ef107d
GIT binary patch
rtlwifi/rtl8192eu_wowlan.bin binary +0 -0
index aebcffc3aad4ee0331b710a865f125d3247d75d7..4a12a1d4de77867498840df54a5dd160dc5ccc58 100644
GIT binary patch
Signature · 1 line
2.34.1
#1 lore raw
Quoted 8 lines · James Hilliard

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

Quoted 4 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

josh

Quoted 2,117 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8192eu_ap.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..a6fcfc8b4bb9e3abbad78212cf6aee857740ddc2
GIT binary patch
rtlwifi/rtl8192eu_nic.bin binary +0 -0
index 4a034d3ae8910df49682876dfe44fe8690798825..4ee03e8842953cd6a2b122c54a7fd71e91176c38 100644
GIT binary patch
rtlwifi/rtl8192eu_nic_setupbox.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..245fe08f792fe4b9be7d8e55da9b2e0627ef107d
GIT binary patch
rtlwifi/rtl8192eu_wowlan.bin binary +0 -1
index aebcffc3aad4ee0331b710a865f125d3247d75d7..4a12a1d4de77867498840df54a5dd160dc5ccc58 100644
GIT binary patch
 
 
--

2.34.1

#2 lore raw
Quoted 16 lines · Josh Boyer
Quoted 8 lines · James Hilliard

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

Quoted 4 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

Quoted 6 lines

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

I just extracted them from the vendor driver same as last time:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/rtlwifi/rtl8192eu_nic.bin?id=91d5dd136153e0a199d7bf30fd03763d83586b73

The vendor file license just says GPLv2:
https://github.com/clnhub/rtl8192eu-linux/blob/5.11.2.1/hal/rtl8192e/hal8192e_fw.c

Quoted 2,125 lines

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

josh

Quoted 2,117 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 
rtlwifi/rtl8192eu_ap.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..a6fcfc8b4bb9e3abbad78212cf6aee857740ddc2
GIT binary patch
rtlwifi/rtl8192eu_nic.bin binary +0 -0
index 4a034d3ae8910df49682876dfe44fe8690798825..4ee03e8842953cd6a2b122c54a7fd71e91176c38 100644
GIT binary patch
rtlwifi/rtl8192eu_nic_setupbox.bin new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..245fe08f792fe4b9be7d8e55da9b2e0627ef107d
GIT binary patch
rtlwifi/rtl8192eu_wowlan.bin binary +0 -1
index aebcffc3aad4ee0331b710a865f125d3247d75d7..4a12a1d4de77867498840df54a5dd160dc5ccc58 100644
GIT binary patch
 
 
--

2.34.1

#3 lore raw
Quoted 10 lines

-----Original Message-----
From: James Hilliard <[email protected]>
Sent: Wednesday, October 19, 2022 9:30 PM
To: Josh Boyer <[email protected]>
Cc: Ping-Ke Shih <[email protected]>; [email protected]; [email protected]; Jes Sorensen <[email protected]>; Bitterblue Smith <[email protected]>
Subject: Re: [PATCH] rtlwifi: update firmware for rtl8192eu to v35.7

Quoted 11 lines
Quoted 10 lines · Josh Boyer
Quoted 7 lines · James Hilliard

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

I think these two are not suitable to rtl8xxxu, so I suggest to ignore them.

Quoted 13 lines
Quoted 6 lines
Quoted 5 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

Quoted 6 lines

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

Quoted 7 lines

I just extracted them from the vendor driver same as last time:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/rtlwifi/rtl8192eu_n
ic.bin?id=91d5dd136153e0a199d7bf30fd03763d83586b73

The vendor file license just says GPLv2:
https://github.com/clnhub/rtl8192eu-linux/blob/5.11.2.1/hal/rtl8192e/hal8192e_fw.c

I'm not a lawyer, no idea about this. I hope someone can comment this.

Quoted 5 lines
Quoted 5 lines

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

I think I can take patches related to Realtek firmware to my github tree, and send out pull-request after checking content of firmware patch. Does it work to you, Josh?

Quoted 64 lines
Quoted 64 lines

josh

Quoted 61 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 

[...]

#4 lore raw
Quoted 16 lines · Ping-Ke Shih
Quoted 16 lines

-----Original Message-----
From: James Hilliard <[email protected]>
Sent: Wednesday, October 19, 2022 9:30 PM
To: Josh Boyer <[email protected]>
Cc: Ping-Ke Shih <[email protected]>; [email protected]; [email protected]; Jes Sorensen <[email protected]>; Bitterblue Smith <[email protected]>
Subject: Re: [PATCH] rtlwifi: update firmware for rtl8192eu to v35.7

Quoted 4 lines · Josh Boyer
Quoted 1 line · James Hilliard
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

I think these two are not suitable to rtl8xxxu, so I suggest to ignore them.

That's correct, and actually only rtl8192eu_nic.bin seems to be used by rtl8xxxu at the moment, I just extracted all variants for consistency, this appears to be what was done when these files were originally added.

Quoted 25 lines
Quoted 14 lines
Quoted 7 lines
Quoted 6 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

Quoted 6 lines

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

Quoted 7 lines

I just extracted them from the vendor driver same as last time:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/rtlwifi/rtl8192eu_n
ic.bin?id=91d5dd136153e0a199d7bf30fd03763d83586b73

The vendor file license just says GPLv2:
https://github.com/clnhub/rtl8192eu-linux/blob/5.11.2.1/hal/rtl8192e/hal8192e_fw.c

I'm not a lawyer, no idea about this. I hope someone can comment this.

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

I think I can take patches related to Realtek firmware to my github tree, and send out pull-request after checking content of firmware patch. Does it work to you, Josh?

If possible could you check if v35.7 is the newest available firmware version for the rtl8192eu?

The v35.7 was the newest I found in vendor drivers for the rtl8192eu, for example in this dlink release(v35.7 was also in a few earlier revisions):
https://support.dlink.com/resource/SECURITY_ADVISEMENTS/DWA-131/REVE/DWA-131_REVE_DRIVER_v5.11.2.1-18_HOTFIX_LINUX.zip

Quoted 68 lines
Quoted 65 lines
Quoted 65 lines

josh

Quoted 61 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 

[...]

#5 lore raw
Quoted 75 lines

-----Original Message-----
From: James Hilliard <[email protected]>
Sent: Thursday, October 20, 2022 8:56 AM
To: Ping-Ke Shih <[email protected]>
Cc: Josh Boyer <[email protected]>; [email protected]; [email protected]; Jes Sorensen <[email protected]>; Bitterblue Smith <[email protected]>
Subject: Re: [PATCH] rtlwifi: update firmware for rtl8192eu to v35.7

Quoted 16 lines · Ping-Ke Shih
Quoted 16 lines

-----Original Message-----
From: James Hilliard <[email protected]>
Sent: Wednesday, October 19, 2022 9:30 PM
To: Josh Boyer <[email protected]>
Cc: Ping-Ke Shih <[email protected]>; [email protected]; [email protected]; Jes Sorensen <[email protected]>; Bitterblue Smith <[email protected]>
Subject: Re: [PATCH] rtlwifi: update firmware for rtl8192eu to v35.7

Quoted 4 lines · Josh Boyer
Quoted 1 line · James Hilliard
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

I think these two are not suitable to rtl8xxxu, so I suggest to ignore them.

That's correct, and actually only rtl8192eu_nic.bin seems to be used by rtl8xxxu at the moment, I just extracted all variants for consistency, this appears to be what was done when these files were originally added.

Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 6 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

Quoted 2 lines
Quoted 2 lines

I just extracted them from the vendor driver same as last time:

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/rtlwifi/rtl8192eu_n

Quoted 9 lines
Quoted 5 lines

ic.bin?id=91d5dd136153e0a199d7bf30fd03763d83586b73

The vendor file license just says GPLv2:
https://github.com/clnhub/rtl8192eu-linux/blob/5.11.2.1/hal/rtl8192e/hal8192e_fw.c

I'm not a lawyer, no idea about this. I hope someone can comment this.

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

I think I can take patches related to Realtek firmware to my github tree, and send out pull-request after checking content of firmware patch. Does it work to you, Josh?

Quoted 7 lines

If possible could you check if v35.7 is the newest available firmware version for the rtl8192eu?

The v35.7 was the newest I found in vendor drivers for the rtl8192eu, for example in this dlink release(v35.7 was also in a few earlier revisions):
https://support.dlink.com/resource/SECURITY_ADVISEMENTS/DWA-131/REVE/DWA-131_REVE_DRIVER_v5.11.2.1-18_
HOTFIX_LINUX.zip

The v35.7 is the newest, but I think the "newest" is not always important to you, because newer firmware could possibly add new feature collaborated with newer driver. If v35.7 can run stably with rtl8xxxu, we don't need newer one.

Quoted 71 lines
Quoted 64 lines
Quoted 64 lines
Quoted 64 lines

josh

Quoted 59 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
WHENCE +0 -0
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 

[...]

------Please consider the environment before printing this e-mail.

#6 lore raw
In reply to Ping-Ke Shih
Quoted 49 lines · Ping-Ke Shih
Quoted 11 lines

-----Original Message-----
From: James Hilliard <[email protected]>
Sent: Wednesday, October 19, 2022 9:30 PM
To: Josh Boyer <[email protected]>
Cc: Ping-Ke Shih <[email protected]>; [email protected]; [email protected]; Jes Sorensen <[email protected]>; Bitterblue Smith <[email protected]>
Subject: Re: [PATCH] rtlwifi: update firmware for rtl8192eu to v35.7

Quoted 11 lines
Quoted 10 lines · Josh Boyer
Quoted 7 lines · James Hilliard

This is v35.7 firmware for the rtl8192eu.

This adds 2 new firmware variants extracted from vendor drivers that were not previously present:
rtl8192eu_ap.bin
rtl8192eu_nic_setupbox.bin

I think these two are not suitable to rtl8xxxu, so I suggest to ignore them.

Quoted 13 lines
Quoted 6 lines
Quoted 5 lines

These firmware files occurs as data statements in the latest Realtek vendor driver I found for the rtl8192eu in addition to some older vendor driver releases:
rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047

Quoted 6 lines

I have no idea what this is, nor is there any indication that Realtek wants these published to the linux-firmware repo under redistributable license terms. You've extracted firmware from elsewhere and are assuming it is licensed under the existing license, but there's no indication that's actually the case. The provenance of this firmware is questionable.

Quoted 7 lines

I just extracted them from the vendor driver same as last time:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/rtlwifi/rtl8192eu_n
ic.bin?id=91d5dd136153e0a199d7bf30fd03763d83586b73

The vendor file license just says GPLv2:
https://github.com/clnhub/rtl8192eu-linux/blob/5.11.2.1/hal/rtl8192e/hal8192e_fw.c

I'm not a lawyer, no idea about this. I hope someone can comment this.

Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

I've copied Ping-Ke Shih in case they have some insight here, but I can't really take this patch as it is based on what is represented here. An ack or Signed-off-by from someone at Realtek would go a long way.

I think I can take patches related to Realtek firmware to my github tree, and send out pull-request after checking content of firmware patch. Does it work to you, Josh?

Yes, that would be great. Thank you.

josh

Quoted 64 lines
Quoted 61 lines
Quoted 61 lines
Quoted 61 lines

Note that the existing rtl8192eu_ap_wowlan.bin firmware header indicates it is actually v18.0 and not v19.0 as indicated by the commit that introduced it 91d5dd136153e0a199d7bf30fd03763d83586b73, as such it is marked as version 18.0.

So far I have managed to find the following firmware versions for the rtl8192eu in various vendor driver releases:
v18.0
v19.0
v27.0
v35.7

The rtl8192eu_ap_wowlan.bin firmware does not appear to have received any updates unlike the other rtl8192eu firmware variants.

Previous firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 19.0 (signature 0x92e1)

Updated firmware load in rtl8xxxu:
rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin Firmware revision 35.7 (signature 0x92e1)

Cc Jes Sorensen <[email protected]>
Cc Bitterblue Smith <[email protected]>
---
 WHENCE                             |   9 ++++++++-
 rtlwifi/rtl8192eu_ap.bin           | Bin 0 -> 25816 bytes
 rtlwifi/rtl8192eu_nic.bin          | Bin 31818 -> 32286 bytes
 rtlwifi/rtl8192eu_nic_setupbox.bin | Bin 0 -> 28554 bytes
 rtlwifi/rtl8192eu_wowlan.bin       | Bin 25878 -> 29008 bytes
 5 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 rtlwifi/rtl8192eu_ap.bin
 create mode 100644 rtlwifi/rtl8192eu_nic_setupbox.bin
WHENCE +8 -1
index 816cf7c..e7ae78a 100644
@@ -3257,12 +3257,19 @@ File: rtlwifi/rtl8723bu_wowlan.bin
 File: rtlwifi/rtl8723bu_ap_wowlan.bin
 
 Info: rtl8192eu taken from Realtek driver
-      rtl8192EU_linux_v4.3.1.1_11320.20140505
+      rtl8192EU_WiFi_linux_v5.11.2.1-18-g8e7df912b.20210527_COEX20171113-0047
       Firmware is embedded in the driver as data statements. This info
       has been extracted into a binary file.
 File: rtlwifi/rtl8192eu_nic.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_nic_setupbox.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_wowlan.bin
+Version: 35.7
+File: rtlwifi/rtl8192eu_ap.bin
+Version: 35.7
 File: rtlwifi/rtl8192eu_ap_wowlan.bin
+Version: 18.0
 
 Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
 

[...]