Skip to contentSkip to conversation

Support VMCOREINFO export for RISCV64

PATCH Superseded Xianting Tian 4 participants 13 messages Oct 14, 2022 – Oct 18, 2022 1 message not in the archive

Subsystems (5)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover Support VMCOREINFO export for RISCV64

As disscussed in below patch set, the patch of 'describe VMCOREINFO export in Documentation' need to update according to Bagas's comments.
https://lore.kernel.org/linux-riscv/[email protected]/

As others patches in above patch set already applied, so this patch set only contains below two patches.

------
Changes:
Fix commit message in patch 2: use "Document these RISCV64 exports above" instead of "This patch just add the description of VMCOREINFO export for RISCV64."
V1 -> V2:
Remove unnecessary overline above header text in patch 2.

Xianting Tian (2):
RISC-V: Add arch_crash_save_vmcoreinfo support
Documentation: kdump: describe VMCOREINFO export for RISCV64

 .../admin-guide/kdump/vmcoreinfo.rst          | 30 ++++++++++++++++++
 arch/riscv/kernel/Makefile                    |  1 +
 arch/riscv/kernel/crash_core.c                | 29 +++++++++++++++++
 3 files changed, 61 insertions(+)
 create mode 100644 arch/riscv/kernel/crash_core.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/2 RISC-V: Add arch_crash_save_vmcoreinfo support

Add arch_crash_save_vmcoreinfo(), which exports VM layout(MODULES, VMALLOC, VMEMMAP and KERNEL_LINK_ADDR ranges), va bits and ram base for vmcore.

Default pagetable levels and PAGE_OFFSET aren't same for different kernel version as below. For default pagetable levels, it sets sv57 on defaultly in latest kernel and do fallback to try to set sv48 on boot time if sv57 is not supported in current hardware.

For ram base, the default value is 0x80200000 for qemu riscv64 env, 0x200000 for riscv64 SoC platform(eg, SoC platform of RISC-V XuanTie 910 CPU).

* Linux Kernel 5.18 ~
* PGTABLE_LEVELS = 5
* PAGE_OFFSET = 0xff60000000000000
* Linux Kernel 5.17 ~
* PGTABLE_LEVELS = 4
* PAGE_OFFSET = 0xffffaf8000000000
* Linux Kernel 4.19 ~
* PGTABLE_LEVELS = 3
* PAGE_OFFSET = 0xffffffe000000000

Since these configurations change from time to time and version to version, it is preferable to export them via vmcoreinfo than to change the crash's code frequently, it can simplify the development of crash tool.

---
 arch/riscv/kernel/Makefile     |  1 +
 arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 arch/riscv/kernel/crash_core.c
arch/riscv/kernel/Makefile +1 -0
index db6e4b1294ba..4cf303a779ab 100644
@@ -81,6 +81,7 @@ obj-$(CONFIG_KGDB)		+= kgdb.o
 obj-$(CONFIG_KEXEC_CORE)	+= kexec_relocate.o crash_save_regs.o machine_kexec.o
 obj-$(CONFIG_KEXEC_FILE)	+= elf_kexec.o machine_kexec_file.o
 obj-$(CONFIG_CRASH_DUMP)	+= crash_dump.o
+obj-$(CONFIG_CRASH_CORE)	+= crash_core.o
 
 obj-$(CONFIG_JUMP_LABEL)	+= jump_label.o
 
arch/riscv/kernel/crash_core.c new file +29 -0
new file mode 100644
index 000000000000..8d7f5ff108da
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/crash_core.h>
+#include <linux/pagemap.h>
+
+void arch_crash_save_vmcoreinfo(void)
+{
+	VMCOREINFO_NUMBER(VA_BITS);
+	VMCOREINFO_NUMBER(phys_ram_base);
+
+	vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
+#ifdef CONFIG_64BIT
+	vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
+	vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
+#endif
+
+	if (IS_ENABLED(CONFIG_64BIT)) {
+#ifdef CONFIG_KASAN
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_START)=0x%lx\n", KASAN_SHADOW_START);
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_END)=0x%lx\n", KASAN_SHADOW_END);
+#endif
+		vmcoreinfo_append_str("NUMBER(KERNEL_LINK_ADDR)=0x%lx\n", KERNEL_LINK_ADDR);
+		vmcoreinfo_append_str("NUMBER(ADDRESS_SPACE_END)=0x%lx\n", ADDRESS_SPACE_END);
+	}
+}
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH V2 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support

Quoted 7 lines · Xianting Tian

Add arch_crash_save_vmcoreinfo(), which exports VM layout(MODULES, VMALLOC, VMEMMAP and KERNEL_LINK_ADDR ranges), va bits and ram base for vmcore.

Default pagetable levels and PAGE_OFFSET aren't same for different kernel version as below. For default pagetable levels, it sets sv57 on defaultly in latest kernel and do fallback to try to set sv48 on boot time if sv57 is not supported in current hardware.

nit: This would read better as "it sets sv57 by default and falls back to setting sv48 at boot time if sv57 is not supported by the hardware".

Quoted 3 lines

For ram base, the default value is 0x80200000 for qemu riscv64 env, 0x200000 for riscv64 SoC platform(eg, SoC platform of RISC-V XuanTie 910 CPU).

The second part of this sentence I'm not really sure that that is true, I think you should reword it to something like "...for qemu riscv64 and, for example, is 0x200000 on the XuanTie 910 CPU." and avoid applying that number blanketly for other SoCs.

Quoted 51 lines

* Linux Kernel 5.18 ~
* PGTABLE_LEVELS = 5
* PAGE_OFFSET = 0xff60000000000000
* Linux Kernel 5.17 ~
* PGTABLE_LEVELS = 4
* PAGE_OFFSET = 0xffffaf8000000000
* Linux Kernel 4.19 ~
* PGTABLE_LEVELS = 3
* PAGE_OFFSET = 0xffffffe000000000

Since these configurations change from time to time and version to version, it is preferable to export them via vmcoreinfo than to change the crash's code frequently, it can simplify the development of crash tool.

---
 arch/riscv/kernel/Makefile     |  1 +
 arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 arch/riscv/kernel/crash_core.c
arch/riscv/kernel/Makefile +1 -0
index db6e4b1294ba..4cf303a779ab 100644
@@ -81,6 +81,7 @@ obj-$(CONFIG_KGDB)		+= kgdb.o
 obj-$(CONFIG_KEXEC_CORE)	+= kexec_relocate.o crash_save_regs.o machine_kexec.o
 obj-$(CONFIG_KEXEC_FILE)	+= elf_kexec.o machine_kexec_file.o
 obj-$(CONFIG_CRASH_DUMP)	+= crash_dump.o
+obj-$(CONFIG_CRASH_CORE)	+= crash_core.o
 
 obj-$(CONFIG_JUMP_LABEL)	+= jump_label.o
 
arch/riscv/kernel/crash_core.c new file +11 -0
new file mode 100644
index 000000000000..8d7f5ff108da
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/crash_core.h>
+#include <linux/pagemap.h>
+
+void arch_crash_save_vmcoreinfo(void)
+{
+	VMCOREINFO_NUMBER(VA_BITS);
+	VMCOREINFO_NUMBER(phys_ram_base);
+
+	vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET);

arch/riscv/kernel/crash_core.c line 21

Quoted 10 lines
arch/riscv/kernel/crash_core.c new file +10 -0
+	vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
+#ifdef CONFIG_64BIT
+	vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
+	vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
+#endif
+
+	if (IS_ENABLED(CONFIG_64BIT)) {

You've already got a #ifdef CONFIG_64BIT above, is there a reason why you'd use the IS_ENABLED here rather than merge this with the above section? I'm a big fan of IS_ENABLED but I'm not sure what it adds here, maybe you can show me the light :)

Thanks,
Conor.

Quoted 12 lines
arch/riscv/kernel/crash_core.c new file +8 -0
+#ifdef CONFIG_KASAN
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_START)=0x%lx\n", KASAN_SHADOW_START);
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_END)=0x%lx\n", KASAN_SHADOW_END);
+#endif
+		vmcoreinfo_append_str("NUMBER(KERNEL_LINK_ADDR)=0x%lx\n", KERNEL_LINK_ADDR);
+		vmcoreinfo_append_str("NUMBER(ADDRESS_SPACE_END)=0x%lx\n", ADDRESS_SPACE_END);
+	}
+}
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Re: [PATCH V2 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support

Quoted 70 lines · Xianting Tian

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 58 lines · Conor Dooley
Quoted 56 lines · Xianting Tian

* Linux Kernel 5.18 ~
* PGTABLE_LEVELS = 5
* PAGE_OFFSET = 0xff60000000000000
* Linux Kernel 5.17 ~
* PGTABLE_LEVELS = 4
* PAGE_OFFSET = 0xffffaf8000000000
* Linux Kernel 4.19 ~
* PGTABLE_LEVELS = 3
* PAGE_OFFSET = 0xffffffe000000000

Since these configurations change from time to time and version to version, it is preferable to export them via vmcoreinfo than to change the crash's code frequently, it can simplify the development of crash tool.

---
  arch/riscv/kernel/Makefile     |  1 +
  arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++++++++++++++
  2 files changed, 30 insertions(+)

create mode 100644 arch/riscv/kernel/crash_core.c

arch/riscv/kernel/Makefile +1 -0
index db6e4b1294ba..4cf303a779ab 100644
@@ -81,6 +81,7 @@ obj-$(CONFIG_KGDB)		+= kgdb.o
  obj-$(CONFIG_KEXEC_CORE)	+= kexec_relocate.o crash_save_regs.o machine_kexec.o
  obj-$(CONFIG_KEXEC_FILE)	+= elf_kexec.o machine_kexec_file.o
  obj-$(CONFIG_CRASH_DUMP)	+= crash_dump.o
+obj-$(CONFIG_CRASH_CORE)	+= crash_core.o
 
  obj-$(CONFIG_JUMP_LABEL)	+= jump_label.o
 
arch/riscv/kernel/crash_core.c new file +17 -0
new file mode 100644
index 000000000000..8d7f5ff108da
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/crash_core.h>
+#include <linux/pagemap.h>
+
+void arch_crash_save_vmcoreinfo(void)
+{
+	VMCOREINFO_NUMBER(VA_BITS);
+	VMCOREINFO_NUMBER(phys_ram_base);
+
+	vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
+#ifdef CONFIG_64BIT
+	vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
Quoted 8 lines

arch/riscv/kernel/crash_core.c line 21

Quoted 4 lines
arch/riscv/kernel/crash_core.c new file +4 -0
+	vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
+#endif
+
+	if (IS_ENABLED(CONFIG_64BIT)) {

You've already got a #ifdef CONFIG_64BIT above, is there a reason why you'd use the IS_ENABLED here rather than merge this with the above section? I'm a big fan of IS_ENABLED but I'm not sure what it adds here, maybe you can show me the light :)

Quoted 2 lines

The IS_ENABLED() check prevents the line from getting executed, but unlike an #ifdef it relies on it to be parsable.

Hey Xianting,
Firstly, neither this nor the other version of this message made it to the mailing list - and since I usually use lei to get my mails that is a bit of a problem :(

Yeah, I know that that is what IS_ENABLED() does, it's just in this situation it does not look very intentional & more like disjoint bits of copy-paste. It's fine though, leave it as it is.

Thanks,
Conor.

Quoted 44 lines

I wrote this arch_crash_save_vmcoreinfo() func with reference to this: static void __init print_vm_layout(void) // arch/riscv/mm/init.c

{
         pr_notice("Virtual kernel memory layout:\n");
         print_ml("fixmap", (unsigned long)FIXADDR_START,
                 (unsigned long)FIXADDR_TOP);
         print_ml("pci io", (unsigned long)PCI_IO_START,
                 (unsigned long)PCI_IO_END);
         print_ml("vmemmap", (unsigned long)VMEMMAP_START,
                 (unsigned long)VMEMMAP_END);
         print_ml("vmalloc", (unsigned long)VMALLOC_START,
                 (unsigned long)VMALLOC_END);
#ifdef CONFIG_64BIT
         print_ml("modules", (unsigned long)MODULES_VADDR,
                 (unsigned long)MODULES_END);
#endif
         print_ml("lowmem", (unsigned long)PAGE_OFFSET,
                 (unsigned long)high_memory);
         if (IS_ENABLED(CONFIG_64BIT)) {
#ifdef CONFIG_KASAN
                 print_ml("kasan", KASAN_SHADOW_START, KASAN_SHADOW_END);

#endif

                 print_ml("kernel", (unsigned long)KERNEL_LINK_ADDR,
                          (unsigned long)ADDRESS_SPACE_END);
         }
}
Quoted 16 lines

Thanks,
Conor.

Quoted 12 lines
arch/riscv/kernel/crash_core.c new file +8 -0
+#ifdef CONFIG_KASAN
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_START)=0x%lx\n", KASAN_SHADOW_START);
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_END)=0x%lx\n", KASAN_SHADOW_END);
+#endif
+		vmcoreinfo_append_str("NUMBER(KERNEL_LINK_ADDR)=0x%lx\n", KERNEL_LINK_ADDR);
+		vmcoreinfo_append_str("NUMBER(ADDRESS_SPACE_END)=0x%lx\n", ADDRESS_SPACE_END);
+	}
+}
Signature · 1 line
2.17.1
#5 lore raw

Re: [PATCH V2 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support

Quoted 70 lines · 在 2022/10/18 下午3:19, [email protected] 写道:
Quoted 69 lines · Xianting Tian

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 65 lines · Conor Dooley
Quoted 50 lines · Xianting Tian

* Linux Kernel 5.18 ~
* PGTABLE_LEVELS = 5
* PAGE_OFFSET = 0xff60000000000000
* Linux Kernel 5.17 ~
* PGTABLE_LEVELS = 4
* PAGE_OFFSET = 0xffffaf8000000000
* Linux Kernel 4.19 ~
* PGTABLE_LEVELS = 3
* PAGE_OFFSET = 0xffffffe000000000

Since these configurations change from time to time and version to version, it is preferable to export them via vmcoreinfo than to change the crash's code frequently, it can simplify the development of crash tool.

---
   arch/riscv/kernel/Makefile     |  1 +
   arch/riscv/kernel/crash_core.c | 29 +++++++++++++++++++++++++++++
   2 files changed, 30 insertions(+)

create mode 100644 arch/riscv/kernel/crash_core.c

arch/riscv/kernel/Makefile +1 -0
index db6e4b1294ba..4cf303a779ab 100644
@@ -81,6 +81,7 @@ obj-$(CONFIG_KGDB)		+= kgdb.o
   obj-$(CONFIG_KEXEC_CORE)	+= kexec_relocate.o crash_save_regs.o machine_kexec.o
   obj-$(CONFIG_KEXEC_FILE)	+= elf_kexec.o machine_kexec_file.o
   obj-$(CONFIG_CRASH_DUMP)	+= crash_dump.o
+obj-$(CONFIG_CRASH_CORE)	+= crash_core.o
 
   obj-$(CONFIG_JUMP_LABEL)	+= jump_label.o
 
arch/riscv/kernel/crash_core.c new file +11 -0
new file mode 100644
index 000000000000..8d7f5ff108da
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <linux/crash_core.h>
+#include <linux/pagemap.h>
+
+void arch_crash_save_vmcoreinfo(void)
+{
+	VMCOREINFO_NUMBER(VA_BITS);
+	VMCOREINFO_NUMBER(phys_ram_base);
+
+	vmcoreinfo_append_str("NUMBER(PAGE_OFFSET)=0x%lx\n", PAGE_OFFSET);

arch/riscv/kernel/crash_core.c line 21

Quoted 10 lines
arch/riscv/kernel/crash_core.c new file +10 -0
+	vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START);
+	vmcoreinfo_append_str("NUMBER(VMALLOC_END)=0x%lx\n", VMALLOC_END);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_START)=0x%lx\n", VMEMMAP_START);
+	vmcoreinfo_append_str("NUMBER(VMEMMAP_END)=0x%lx\n", VMEMMAP_END);
+#ifdef CONFIG_64BIT
+	vmcoreinfo_append_str("NUMBER(MODULES_VADDR)=0x%lx\n", MODULES_VADDR);
+	vmcoreinfo_append_str("NUMBER(MODULES_END)=0x%lx\n", MODULES_END);
+#endif
+
+	if (IS_ENABLED(CONFIG_64BIT)) {

You've already got a #ifdef CONFIG_64BIT above, is there a reason why you'd use the IS_ENABLED here rather than merge this with the above section? I'm a big fan of IS_ENABLED but I'm not sure what it adds here, maybe you can show me the light :)

Quoted 6 lines
Quoted 2 lines

The IS_ENABLED() check prevents the line from getting executed, but unlike an #ifdef it relies on it to be parsable.

Hey Xianting,
Firstly, neither this nor the other version of this message made it to the mailing list - and since I usually use lei to get my mails that is a bit of a problem :(

Sorry, I don't know why,  I just reply via Thunderbird.

But git send-mail is right, I will send V3 soon.

Quoted 4 lines

Yeah, I know that that is what IS_ENABLED() does, it's just in this situation it does not look very intentional & more like disjoint bits of copy-paste. It's fine though, leave it as it is.

OK, thanks

Quoted 47 lines

Thanks,
Conor.

Quoted 43 lines

I wrote this arch_crash_save_vmcoreinfo() func with reference to this: static void __init print_vm_layout(void) // arch/riscv/mm/init.c

{
          pr_notice("Virtual kernel memory layout:\n");
          print_ml("fixmap", (unsigned long)FIXADDR_START,
                  (unsigned long)FIXADDR_TOP);
          print_ml("pci io", (unsigned long)PCI_IO_START,
                  (unsigned long)PCI_IO_END);
          print_ml("vmemmap", (unsigned long)VMEMMAP_START,
                  (unsigned long)VMEMMAP_END);
          print_ml("vmalloc", (unsigned long)VMALLOC_START,
                  (unsigned long)VMALLOC_END);
#ifdef CONFIG_64BIT
          print_ml("modules", (unsigned long)MODULES_VADDR,
                  (unsigned long)MODULES_END);
#endif
          print_ml("lowmem", (unsigned long)PAGE_OFFSET,
                  (unsigned long)high_memory);
          if (IS_ENABLED(CONFIG_64BIT)) {
#ifdef CONFIG_KASAN
                  print_ml("kasan", KASAN_SHADOW_START, KASAN_SHADOW_END);

#endif

                  print_ml("kernel", (unsigned long)KERNEL_LINK_ADDR,
                           (unsigned long)ADDRESS_SPACE_END);
          }
}
Quoted 16 lines

Thanks,
Conor.

Quoted 12 lines
arch/riscv/kernel/crash_core.c new file +8 -0
+#ifdef CONFIG_KASAN
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_START)=0x%lx\n", KASAN_SHADOW_START);
+		vmcoreinfo_append_str("NUMBER(KASAN_SHADOW_END)=0x%lx\n", KASAN_SHADOW_END);
+#endif
+		vmcoreinfo_append_str("NUMBER(KERNEL_LINK_ADDR)=0x%lx\n", KERNEL_LINK_ADDR);
+		vmcoreinfo_append_str("NUMBER(ADDRESS_SPACE_END)=0x%lx\n", ADDRESS_SPACE_END);
+	}
+}
Signature · 1 line
2.17.1
#6 lore raw

PATCH v2 2/2 Documentation: kdump: describe VMCOREINFO export for RISCV64

In reply to Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,
KASAN_SHADOW_START ~ KASAN_SHADOW_END,
KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END

Document these RISCV64 exports above.

---
 .../admin-guide/kdump/vmcoreinfo.rst          | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
Documentation/admin-guide/kdump/vmcoreinfo.rst +30 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
 -----
 
 Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.
Signature · 1 line
2.17.1
#7 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

Quoted 30 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,
KASAN_SHADOW_START ~ KASAN_SHADOW_END,
KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END

Document these RISCV64 exports above.

---
 .../admin-guide/kdump/vmcoreinfo.rst          | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
Documentation/admin-guide/kdump/vmcoreinfo.rst +4 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
 -----
 
 Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 611

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.

Apologies for not seeing this sooner, but should there not be a "the" prior to "direct-mapped"?

Quoted 4 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +4 -0
+
+phys_ram_base
+-------------
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 625

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+Indicates the start physical RAM address.
+
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.

Since I'm in pedant mode, it does look a little odd that you're using region for vmemmap but space for the others but idc that much.

Thanks,
Conor.

Quoted 6 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +2 -0
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.
Signature · 1 line
2.17.1

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#8 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

Quoted 35 lines · Conor Dooley
Quoted 34 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,
KASAN_SHADOW_START ~ KASAN_SHADOW_END,
KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END

Document these RISCV64 exports above.

---
  .../admin-guide/kdump/vmcoreinfo.rst          | 30 +++++++++++++++++++
  1 file changed, 30 insertions(+)
Documentation/admin-guide/kdump/vmcoreinfo.rst +8 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
  -----
 
  Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
Quoted 8 lines

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 611

Quoted 6 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +6 -0
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.

Apologies for not seeing this sooner, but should there not be a "the" prior to "direct-mapped"?

will fix in v3

Quoted 17 lines
Quoted 5 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +4 -0
+
+phys_ram_base
+-------------
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 625

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+Indicates the start physical RAM address.
+
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.

Since I'm in pedant mode, it does look a little odd that you're using region for vmemmap but space for the others but idc that much.

Sorry, I didn't get your point :(

it contains vmemmap area with reference wth arch/arm64/kernel/crash_core.c.

Quoted 10 lines

Thanks,
Conor.

Quoted 6 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +2 -0
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.
Signature · 1 line
2.17.1
#9 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

Quoted 63 lines · Xianting Tian
Quoted 34 lines · Conor Dooley
Quoted 33 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
VA_BITS,
PAGE_OFFSET,
phys_ram_base,
MODULES_VADDR ~ MODULES_END,
VMALLOC_START ~ VMALLOC_END,
VMEMMAP_START ~ VMEMMAP_END,
KASAN_SHADOW_START ~ KASAN_SHADOW_END,
KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END

Document these RISCV64 exports above.

---
  .../admin-guide/kdump/vmcoreinfo.rst          | 30 +++++++++++++++++++
  1 file changed, 30 insertions(+)
Documentation/admin-guide/kdump/vmcoreinfo.rst +8 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
  -----
  Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
Quoted 8 lines

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 611

Quoted 6 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +6 -0
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.

Apologies for not seeing this sooner, but should there not be a "the" prior to "direct-mapped"?

will fix in v3

Quoted 17 lines
Quoted 5 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +4 -0
+
+phys_ram_base
+-------------
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 625

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+Indicates the start physical RAM address.
+
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.

Since I'm in pedant mode, it does look a little odd that you're using region for vmemmap but space for the others but idc that much.

Quoted 3 lines

Sorry, I didn't get your point :(

it contains vmemmap area with reference wth arch/arm64/kernel/crash_core.c.

The wording is different, vmemmap uses space and the others use region. Not a big deal.

Quoted 16 lines
Quoted 11 lines

Thanks,
Conor.

Quoted 6 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +2 -0
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.
Signature · 1 line
2.17.1

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

Reviewed-by on v2 2/2
#10 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

In reply to Xianting Tian
Quoted 2 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":

Better say "..., which are exported by ..."

Quoted 28 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +20 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
 -----
 
 Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 627

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.

The documentation LGTM, thanks.

When the patch subject is fixed,

Signature · 1 line
An old man doll... just what I always wanted! - Clara

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#11 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

Quoted 4 lines · Bagas Sanjaya
Quoted 2 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":

Better say "..., which are exported by ..."

will fix it in v3

thanks

Quoted 41 lines
Quoted 29 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +20 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
  -----
 
  Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 627

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.

The documentation LGTM, thanks.

Quoted 4 lines

When the patch subject is fixed,

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#12 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

In reply to Bagas Sanjaya
Quoted 45 lines · Bagas Sanjaya
Quoted 2 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":

Better say "..., which are exported by ..."

Quoted 28 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +20 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB
  -----
 
  Indicates whether the crashed kernel enabled SH extended mode.
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 627

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.

The documentation LGTM, thanks.

Quoted 1 line

When the patch subject is fixed,

Could you tell me what patch subject should be changed to ? thanks

Quoted 3 lines
#13 lore raw

Re: [PATCH V2 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64

Quoted 46 lines · Xianting Tian
Quoted 44 lines · Bagas Sanjaya
Quoted 2 lines · Xianting Tian

The following interrelated definitions and ranges are needed by the kdump crash tool, they are exported by "arch/riscv/kernel/crash_core.c":

Better say "..., which are exported by ..."

Quoted 27 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +0 -0
index 6726f439958c..8e2e164cf3db 100644
@@ -595,3 +595,33 @@ X2TLB

  -----
    Indicates whether the crashed kernel enabled SH extended mode.

Documentation/admin-guide/kdump/vmcoreinfo.rst +20 -0
+
+RISCV64
+=======
+
+VA_BITS
+-------
+
+The maximum number of bits for virtual addresses. Used to compute the
+virtual memory ranges.
+
+PAGE_OFFSET
+-----------
+
+Indicates the virtual kernel start address of direct-mapped RAM region.
+
+phys_ram_base
+-------------
+
+Indicates the start physical RAM address.
+

Documentation/admin-guide/kdump/vmcoreinfo.rst X2TLB · line 627

Quoted 10 lines
Documentation/admin-guide/kdump/vmcoreinfo.rst +10 -0
+MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
+----------------------------------------------------------------------------------------------------------------------------------------------------
+
+Used to get the correct ranges:
+
+  * MODULES_VADDR ~ MODULES_END : Kernel module space.
+  * VMALLOC_START ~ VMALLOC_END : vmalloc() / ioremap() space.
+  * VMEMMAP_START ~ VMEMMAP_END : vmemmap region, used for struct page array.
+  * KASAN_SHADOW_START ~ KASAN_SHADOW_END : kasan shadow space.
+  * KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END : Kernel link and BPF space.

The documentation LGTM, thanks.

Quoted 2 lines
Quoted 1 line

When the patch subject is fixed,

Could you tell me what patch subject should be changed to ? thanks

I mean the description, not subject (as in email). That is, fix the description (see above). The subject shouldn't be changed. Sorry for inconvenience.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara