powerpc/selftests: Use timersub() for gettimeofday()
Subsystems (2)
Sasha Levin
maintainerPATCH 1/3 powerpc/selftests: Use timersub() for gettimeofday()
From: ye xingchen <[email protected]>
[ Upstream commit c814bf958926ff45a9c1e899bd001006ab6cfbae ]
Use timersub() function to simplify the code.
--- tools/testing/selftests/powerpc/benchmarks/gettimeofday.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/testing/selftests/powerpc/benchmarks/gettimeofday.c +4 -2
@@ -12,7 +12,7 @@ static int test_gettimeofday(void) {int i; -struct timeval tv_start, tv_end; +struct timeval tv_start, tv_end, tv_diff;gettimeofday (&tv_start,NULL );
@@ -20,7 +20,9 @@ static int test_gettimeofday(void)gettimeofday (&tv_end,NULL ); } -printf ("time = %.6f\n" , tv_end.tv_sec - tv_start.tv_sec + (tv_end.tv_usec - tv_start.tv_usec) *1e-6 ); +timersub (&tv_start, &tv_end, &tv_diff); + +printf ("time = %.6f\n" , tv_diff.tv_sec + (tv_diff.tv_usec) *1e-6 );return 0 ; }
Signature · 1 line
2.35.1
Sasha Levin
maintainerPATCH 2/3 powerpc/85xx: Fix fall-through warning for Clang
From: "Gustavo A. R. Silva" <[email protected]>
[ Upstream commit d4d944ff68cb1f896d3f3b1af0bc656949dc626a ]
Fix the following fallthrough warning:
arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
--- arch/powerpc/platforms/85xx/mpc85xx_cds.c | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/platforms/85xx/mpc85xx_cds.c +1 -0
@@ -162,6 +162,7 @@ static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)else dev->irq =10 ;pci_write_config_byte (dev,PCI_INTERRUPT_LINE , dev->irq); +break ;default :break ; }
Signature · 1 line
2.35.1
Sasha Levin
maintainerPATCH 3/3 powerpc: Remove direct call to personality syscall handler
In reply to Sasha LevinFrom: Rohan McLure <[email protected]>
[ Upstream commit 4df0221f9ded8c39aecfb1a80cef346026671cb7 ]
Syscall handlers should not be invoked internally by their symbol names, as these symbols defined by the architecture-defined SYSCALL_DEFINE macro. Fortunately, in the case of ppc64_personality, its call to sys_personality can be replaced with an invocation to the equivalent ksys_personality inline helper in <linux/syscalls.h>.
--- arch/powerpc/kernel/syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/syscalls.c +1 -1
@@ -109,7 +109,7 @@ long ppc64_personality(unsigned long personality)if (personality (current->personality) ==PER_LINUX32 &&personality (personality) ==PER_LINUX ) personality = (personality & ~PER_MASK ) |PER_LINUX32 ; - ret =sys_personality (personality); + ret =ksys_personality (personality);if (personality (ret) ==PER_LINUX32 ) ret = (ret & ~PER_MASK ) |PER_LINUX ;return ret;
Signature · 1 line
2.35.1
Quoted 5 lines · Sasha Levin
From: ye xingchen <[email protected]>
[ Upstream commit
c814bf958926ff45a9c1e899bd001006ab6cfbae]Use
timersub()function to simplify the code.
Why should a code simplification be backported?
Quoted 34 lines
Reported-by Zeal Robot <[email protected]>Signed-off-by ye xingchen <[email protected]>Signed-off-by Michael Ellerman <[email protected]>Signed-off-by Sasha Levin <[email protected]>--- tools/testing/selftests/powerpc/benchmarks/gettimeofday.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)tools/testing/selftests/powerpc/benchmarks/gettimeofday.c +4
-2@@ -12,7 +12,7 @@ static int test_gettimeofday(void) {int i; -struct timeval tv_start, tv_end; +struct timeval tv_start, tv_end, tv_diff;gettimeofday (&tv_start,NULL );@@ -20,7 +20,9 @@ static int test_gettimeofday(void)gettimeofday (&tv_end,NULL ); } -printf ("time = %.6f\n" , tv_end.tv_sec - tv_start.tv_sec + (tv_end.tv_usec - tv_start.tv_usec) *1e-6 ); +timersub (&tv_start, &tv_end, &tv_diff); + +printf ("time = %.6f\n" , tv_diff.tv_sec + (tv_diff.tv_usec) *1e-6 );return 0 ; }