Skip to contentSkip to conversation

package/brltty: fix infinite loop in configure

PATCH Applied James Hilliard 2 participants 2 messages Oct 15, 2022 – Oct 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/brltty: fix infinite loop in configure

Backport a patch to fix an infinite loop bug in configure.

Fixes:
- http://autobuild.buildroot.net/results/82a/82af705f7ca282495461cb3994f5a7e6f64273e1
- http://autobuild.buildroot.net/results/06c/06c9414a1ecbc1a147bc8dfddced03fc659af694
- http://autobuild.buildroot.net/results/59e/59e36093f7e437a5a37037f7fa50ce2443c47fd3

---
Changes v1 -> v2:
- backport patch instead of revert

---
 ...unProgramTerminationCommands-used-a-.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/brltty/0002-shell-prologue-runProgramTerminationCommands-used-a-.patch
package/brltty/0002-shell-prologue-runProgramTerminationCommands-used-a-.patch new file +29 -0
new file mode 100644
index 0000000000..0f81254e08
@@ -0,0 +1,29 @@
+From 4503c2cbd3981ba1b50ec7ce287ab48c772b3a7f Mon Sep 17 00:00:00 2001
+From: Dave Mielke <[email protected]>
+Date: Sat, 15 Oct 2022 15:20:38 -0400
+Subject: [PATCH] shell prologue: runProgramTerminationCommands used a bash
+ command. (dm)
+
+Signed-off-by: James Hilliard <[email protected]>
+[[email protected]: backport from upstream commit
+4503c2cbd3981ba1b50ec7ce287ab48c772b3a7f]
+---
+ brltty-prologue.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/brltty-prologue.sh b/brltty-prologue.sh
+index 05b817742..6d1faf983 100644
+--- a/brltty-prologue.sh
++++ b/brltty-prologue.sh
+@@ -102,7 +102,7 @@ runProgramTerminationCommands() {
+    while [ "${programTerminationCommandCount}" -gt 0 ]
+    do
+       set -- $(getVariable "programTerminationCommand${programTerminationCommandCount}")
+-      let "programTerminationCommandCount -= 1"
++      programTerminationCommandCount=$((programTerminationCommandCount - 1))
+ 
+       local process="${1}"
+       local directory="${2}"
+-- 
+2.34.1
+
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

James, All,

On 2022-10-15 15:09 -0600, James Hilliard spake thusly:

Quoted 8 lines

Backport a patch to fix an infinite loop bug in configure.

Fixes:
- http://autobuild.buildroot.net/results/82a/82af705f7ca282495461cb3994f5a7e6f64273e1
- http://autobuild.buildroot.net/results/06c/06c9414a1ecbc1a147bc8dfddced03fc659af694
- http://autobuild.buildroot.net/results/59e/59e36093f7e437a5a37037f7fa50ce2443c47fd3

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 50 lines

---
Changes v1 -> v2:
- backport patch instead of revert

---
 ...unProgramTerminationCommands-used-a-.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/brltty/0002-shell-prologue-runProgramTerminationCommands-used-a-.patch
package/brltty/0002-shell-prologue-runProgramTerminationCommands-used-a-.patch new file +29 -0
new file mode 100644
index 0000000000..0f81254e08
@@ -0,0 +1,29 @@
+From 4503c2cbd3981ba1b50ec7ce287ab48c772b3a7f Mon Sep 17 00:00:00 2001
+From: Dave Mielke <[email protected]>
+Date: Sat, 15 Oct 2022 15:20:38 -0400
+Subject: [PATCH] shell prologue: runProgramTerminationCommands used a bash
+ command. (dm)
+
+Signed-off-by: James Hilliard <[email protected]>
+[[email protected]: backport from upstream commit
+4503c2cbd3981ba1b50ec7ce287ab48c772b3a7f]
+---
+ brltty-prologue.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/brltty-prologue.sh b/brltty-prologue.sh
+index 05b817742..6d1faf983 100644
+--- a/brltty-prologue.sh
++++ b/brltty-prologue.sh
+@@ -102,7 +102,7 @@ runProgramTerminationCommands() {
+    while [ "${programTerminationCommandCount}" -gt 0 ]
+    do
+       set -- $(getVariable "programTerminationCommand${programTerminationCommandCount}")
+-      let "programTerminationCommandCount -= 1"
++      programTerminationCommandCount=$((programTerminationCommandCount - 1))
+ 
+       local process="${1}"
+       local directory="${2}"
+-- 
+2.34.1
+
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot