Skip to contentSkip to conversation

pinctrl: Ingenic: JZ4755 bug fixes

PATCH In review Siarhei Volkau 3 participants 3 messages Oct 16, 2022 – Oct 17, 2022

Subsystems (5)
Stable branch MIPS GPIO Pin control +1 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pinctrl: Ingenic: JZ4755 bug fixes

Fixes UART1 function bits and MMC groups typo.

For pins 0x97,0x99 function 0 is designated to PWM3/PWM5 respectively, function is 1 designated to the UART1.

Diff from v1:
- sent separately
- added tag Fixes

Fixes b582b5a434d3 ("pinctrl: Ingenic: Add pinctrl driver for JZ4755.")
---
 drivers/pinctrl/pinctrl-ingenic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-ingenic.c +2 -2
index 3a9ee9c8a..2991fe0bb 100644
@@ -667,7 +667,7 @@ static u8 jz4755_lcd_24bit_funcs[] = { 1, 1, 1, 1, 0, 0, };
 static const struct group_desc jz4755_groups[] = {
 	INGENIC_PIN_GROUP("uart0-data", jz4755_uart0_data, 0),
 	INGENIC_PIN_GROUP("uart0-hwflow", jz4755_uart0_hwflow, 0),
-	INGENIC_PIN_GROUP("uart1-data", jz4755_uart1_data, 0),
+	INGENIC_PIN_GROUP("uart1-data", jz4755_uart1_data, 1),
 	INGENIC_PIN_GROUP("uart2-data", jz4755_uart2_data, 1),
 	INGENIC_PIN_GROUP("ssi-dt-b", jz4755_ssi_dt_b, 0),
 	INGENIC_PIN_GROUP("ssi-dt-f", jz4755_ssi_dt_f, 0),
@@ -721,7 +721,7 @@ static const char *jz4755_ssi_groups[] = {
 	"ssi-ce1-b", "ssi-ce1-f",
 };
 static const char *jz4755_mmc0_groups[] = { "mmc0-1bit", "mmc0-4bit", };
-static const char *jz4755_mmc1_groups[] = { "mmc0-1bit", "mmc0-4bit", };
+static const char *jz4755_mmc1_groups[] = { "mmc1-1bit", "mmc1-4bit", };
 static const char *jz4755_i2c_groups[] = { "i2c-data", };
 static const char *jz4755_cim_groups[] = { "cim-data", };
 static const char *jz4755_lcd_groups[] = {
Signature · 1 line
2.36.1
maintainer
#1 lore raw
Quoted 9 lines · Siarhei Volkau

Fixes UART1 function bits and MMC groups typo.

For pins 0x97,0x99 function 0 is designated to PWM3/PWM5 respectively, function is 1 designated to the UART1.

Diff from v1:
- sent separately
- added tag Fixes

Quoted 6 lines
Fixes b582b5a434d3 ("pinctrl: Ingenic: Add pinctrl driver for JZ4755.")
---
 drivers/pinctrl/pinctrl-ingenic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

#2 lore raw
In reply to Siarhei Volkau
Quoted 5 lines · Siarhei Volkau

Fixes UART1 function bits and MMC groups typo.

For pins 0x97,0x99 function 0 is designated to PWM3/PWM5 respectively, function is 1 designated to the UART1.

Quoted 7 lines

Diff from v1:
- sent separately
- added tag Fixes

Fixes b582b5a434d3 ("pinctrl: Ingenic: Add pinctrl driver for JZ4755.")

Applied this for fixes and tagged for stable.

Yours,
Linus Walleij