Avoid caching ioctl during fork
PATCH 1/1 Avoid caching ioctl during fork
Both gem_exec_flush and gem_ctx_engines require the SET_CACHING ioctl for some subtests. The ioctl itself, called by gem_set_caching, is wrapped in an igt_require, forcing a skip when the ioctl fails. MTL currently fails this check with -EOPNOTSUPP 100% of the time.
Normally, the ioctl failing and causing a test skip wouldn't be a problem. Howerver, the failing call to the ioctl is made within a forked child process in some cases, which causes an error to occur. By checking whether or not caching is supported before these cases occur, the resulting error can be downgraded to a graceful skip.
v2: The gem_ctx_engines subtest does not require using gem_set_caching if the domain is moved from CPU to WC, so the ioctl was removed from the execution path.
v3: Replace gem_mmap__cpu with gem_mmap__device_coherent instead of gem_mmap__wc in gem_ctx_engines.c
v4: Fix formatting
References: VLK-34086
--- tests/i915/gem_ctx_engines.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
tests/i915/gem_ctx_engines.c +4 -7
@@ -492,12 +492,10 @@ static void independent(int i915, const intel_ctx_t *base_ctx, } param.ctx_id =gem_context_create (i915);gem_context_set_param (i915, ¶m); - -if (!gem_has_lmem (i915)) -gem_set_caching (i915, results.handle,I915_CACHING_CACHED ); - map =gem_mmap__cpu (i915, results.handle,0 ,4096 ,PROT_READ ); + + map =gem_mmap__device_coherent (i915, results.handle,0 ,4096 ,PROT_READ );gem_set_domain (i915, results.handle, -I915_GEM_DOMAIN_CPU ,I915_GEM_DOMAIN_CPU ); +I915_GEM_DOMAIN_WC ,I915_GEM_DOMAIN_WC );for (int i =0 ; i <I915_EXEC_RING_MASK +1 ; i++) {struct drm_i915_gem_exec_object2 obj[2 ] = {
@@ -515,8 +513,7 @@ static void independent(int i915, const intel_ctx_t *base_ctx,uint32_t *cs;int j =0 ; - cs =gem_mmap__cpu (i915, obj[1 ].handle,0 ,4096 ,PROT_WRITE ); - + cs =gem_mmap__device_coherent (i915, obj[1 ].handle,0 ,4096 ,PROT_WRITE ); cs[j] =0x24 <<23 |1 ;/* SRM */ if (has_64bit_reloc) cs[j]++;
Signature · 1 line
2.25.1
Patchwork
CI[igt-dev] ✗ GitLab.Pipeline: warning for Avoid caching ioctl during fork
== Series Details ==
== Series Details ==
Series: Avoid caching ioctl during fork
URL : https://patchwork.freedesktop.org/series/109753/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/713040 for the overview.
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/29841864):
Ok: 23
Expected Fail: 4
Fail: 293
Unexpected Pass: 0 Skipped: 0 Timeout: 0
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt section_end:1665995908:step_script
section_start:1665995908:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1786 matching files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=29841864 responseStatus=201 Created token=88NWiGgD section_end:1665995918:upload_artifacts_on_failure
section_start:1665995918:cleanup_file_variables
Cleaning up project directory and file based variables section_end:1665995918:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/713040
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Avoid caching ioctl during fork
In reply to vikassri07== Series Details ==
== Series Details ==
Series: Avoid caching ioctl during fork
URL : https://patchwork.freedesktop.org/series/109753/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12250 -> IGTPW_7970
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
Participating hosts (45 -> 44)
------------------------------
Additional (1): fi-rkl-guc
Missing (2): fi-bdw-samus fi-skl-6700k2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7970:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_pm_rpm@module-reload:
- {fi-tgl-dsi}: [INCOMPLETE][1] ([i915#7190]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-tgl-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/fi-tgl-dsi/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_7970 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [PASS][3] -> [SKIP][4] ([fdo#109271]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-pnv-d510/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/fi-pnv-d510/igt@[email protected]
* igt@runner@aborted:
- fi-rkl-guc: NOTRUN -> [FAIL][5] ([i915#7220])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/fi-rkl-guc/igt@[email protected]
#### Warnings ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-gvtdvm: [FAIL][6] ([fdo#103375]) -> [INCOMPLETE][7] ([i915#146])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-bdw-gvtdvm/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/fi-bdw-gvtdvm/igt@[email protected]
* igt@runner@aborted:
- fi-kbl-soraka: [FAIL][8] ([i915#4991]) -> [FAIL][9] ([i915#4991] / [i915#7220])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/fi-kbl-soraka/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/fi-kbl-soraka/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#7190]: https://gitlab.freedesktop.org/drm/intel/issues/7190
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7016 -> IGTPW_7970
CI-20190529: 20190529
CI_DRM_12250: 9b84132c9b266a89e2865cbe8b586dd0b14cc2a4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7970: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
IGT_7016: 642f4bf44e2b42791b4d1684936a1bfbe2d099ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.IGT: failure for Avoid caching ioctl during fork
In reply to vikassri07== Series Details ==
== Series Details ==
Series: Avoid caching ioctl during fork
URL : https://patchwork.freedesktop.org/series/109753/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12250_full -> IGTPW_7970_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7970_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_7970_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
Participating hosts (9 -> 8)
------------------------------
Additional (2): shard-rkl shard-dg1
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7970_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][3] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl6/igt@kms_cursor_crc@[email protected]
#### Warnings ####
* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [WARN][4] ([i915#2658]) -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb2/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-tglb: [SKIP][6] ([i915#6497]) -> [FAIL][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@runner@aborted:
- {shard-dg1}: NOTRUN -> ([FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19], [FAIL][20], [FAIL][21], [FAIL][22], [FAIL][23], [FAIL][24], [FAIL][25], [FAIL][26], [FAIL][27], [FAIL][28], [FAIL][29])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-12/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-12/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-19/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-13/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-17/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-15/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-15/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-15/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-19/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-16/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-17/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-16/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-13/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-18/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-18/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-17/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-18/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-16/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-13/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-15/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-19/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-dg1-12/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_7970_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_mm@all:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#6433])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@feature_discovery@display-4x:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#1839])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@gem_ccs@suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#5325])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#6335])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@gem_create@create-massive:
- shard-tglb: NOTRUN -> [DMESG-WARN][34] ([i915#4991])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#1099]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-snb6/igt@[email protected]
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#280])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#6334])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: NOTRUN -> [FAIL][38] ([i915#2842]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#112283])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#4613]) +6 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#4613]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl6/igt@[email protected]
* igt@gem_pxp@create-protected-buffer:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#4270]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@gem_softpin@evict-snoop:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109312]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3297]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-tglb: NOTRUN -> [FAIL][45] ([i915#3318])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@gen7_exec_parse@load-register-reg:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109289]) +4 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#2527] / [i915#2856]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: NOTRUN -> [FAIL][48] ([i915#3989] / [i915#454]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#1902])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#111644] / [i915#1397]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109506])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#4387])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#1769])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#5286]) +6 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#111614]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: NOTRUN -> [FAIL][56] ([i915#3743])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#7206])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#111615]) +5 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#6095]) +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#3886]) +13 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3689] / [i915#3886]) +8 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3689] / [i915#6095]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#111615] / [i915#3689]) +9 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3689]) +12 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3742])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_chamelium@hdmi-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109284] / [fdo#111827]) +18 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-snb: NOTRUN -> [SKIP][67] ([fdo#109271] / [fdo#111827]) +8 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-snb5/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +14 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl1/igt@[email protected]
* igt@kms_color@ctm-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [FAIL][69] ([i915#315] / [i915#6946]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_color@[email protected]
* igt@kms_content_protection@legacy:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#7118]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#3359]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109274])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109274] / [fdo#111825] / [i915#3637] / [i915#3966])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@kms_flip@2x-absolute-wf_vblank.html
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109274] / [fdo#111825] / [i915#3637]) +8 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#2587] / [i915#2672]) +4 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-snb: NOTRUN -> [FAIL][76] ([fdo#103375]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-snb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt:
- shard-snb: NOTRUN -> [SKIP][77] ([fdo#109271]) +172 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-snb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#6497]) +12 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#109280] / [fdo#111825]) +40 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][80] -> [SKIP][81] ([i915#433])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb2/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3555]) +5 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#6403]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@kms_invalid_mode@[email protected]
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][84] ([i915#4573]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl2/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_plane_lowres@tiling-none@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][85] ([i915#3536]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#112054] / [i915#5288])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109274] / [fdo#111825]) +9 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-b-edp-1:
- shard-tglb: NOTRUN -> [SKIP][88] ([i915#5176]) +15 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#5235]) +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#2920])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658]) +5 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl8/igt@[email protected]
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#7037])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb1/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][93] ([i915#132] / [i915#3467]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271]) +211 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl1/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111615] / [i915#5289])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb5/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][96] ([i915#4939]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl2/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#2437])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@prime_vgem@fence-flip-hang:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#109295])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2994]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
* igt@sysfs_clients@sema-25:
- shard-apl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#2994]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-tglb: [FAIL][101] ([i915#5784]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb2/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb2/igt@[email protected]
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-tglb: [FAIL][103] ([i915#7225]) -> [SKIP][104] ([fdo#109280] / [fdo#111825])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@runner@aborted:
- shard-apl: ([FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114]) ([i915#3002] / [i915#4312])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-apl1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-apl3/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-apl3/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12250/shard-apl1/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl1/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl7/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl6/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/shard-apl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7206]: https://gitlab.freedesktop.org/drm/intel/issues/7206
[i915#7220]: https://gitlab.freedesktop.org/drm/intel/issues/7220
[i915#7225]: https://gitlab.freedesktop.org/drm/intel/issues/7225
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7016 -> IGTPW_7970
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12250: 9b84132c9b266a89e2865cbe8b586dd0b14cc2a4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7970: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
IGT_7016: 642f4bf44e2b42791b4d1684936a1bfbe2d099ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7970/index.html
Add original author in the signed-off along with yours. After that change.
Quoted 78 lines
-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of vikassri07
Sent: 17 October 2022 01:28 PM
To: [email protected]; Wilson, Chris P <[email protected]>
Cc: Cavitt, Jonathan <[email protected]>; Yang, Fei <[email protected]>
Subject: [igt-dev] [PATCH i-g-t] Avoid caching ioctl during forkBoth
gem_exec_flushandgem_ctx_enginesrequire theSET_CACHING
ioctl
for some subtests. The ioctl itself, called bygem_set_caching, is wrapped in anigt_require, forcing a skip when the ioctl fails. MTL currently fails this check with-EOPNOTSUPP100% of the time.Normally, the ioctl failing and causing a test skip wouldn't be a problem. Howerver, the failing call to the ioctl is made within a forked child process in some cases, which causes an error to occur. By checking whether or not caching is supported before these cases occur, the resulting error can be downgraded to a graceful skip.
v2: The
gem_ctx_enginessubtest does not require usinggem_set_cachingif the domain is moved from CPU to WC, so the ioctl was removed from the execution path.
v3: Replacegem_mmap__cpuwithgem_mmap__device_coherentinstead
of
gem_mmap__wcingem_ctx_engines.c
v4: Fix formattingReferences: VLK-34086
Signed-off-by vikas.srivastava <[email protected]>CC Jonathan Cavitt <[email protected]>CC Fei Yang <[email protected]>CC Chris Wilson <[email protected]>--- tests/i915/gem_ctx_engines.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)tests/i915/gem_ctx_engines.c +5
-6@@ -492,12 +492,10 @@ static void independent(int i915, const intel_ctx_t *base_ctx, } param.ctx_id =gem_context_create (i915);gem_context_set_param (i915, ¶m); - -if (!gem_has_lmem (i915)) -gem_set_caching (i915, results.handle, I915_CACHING_CACHED); - map =gem_mmap__cpu (i915, results.handle,0 ,4096 ,PROT_READ ); + + map =gem_mmap__device_coherent (i915, results.handle,0 ,4096 , +PROT_READ );gem_set_domain (i915, results.handle, -I915_GEM_DOMAIN_CPU ,I915_GEM_DOMAIN_CPU ); +I915_GEM_DOMAIN_WC ,I915_GEM_DOMAIN_WC ); for (int i = 0; i < I915_EXEC_RING_MASK + 1; i++) { struct drm_i915_gem_exec_object2 obj[2] = { @@ -515,8 +513,7 @@ static void independent(int i915, const intel_ctx_t *base_ctx, uint32_t *cs; int j = 0; - cs = gem_mmap__cpu(i915, obj[1].handle, 0, 4096,
PROT_WRITE);tests/i915/gem_ctx_engines.c +1
-1- + cs = gem_mmap__device_coherent(i915, obj[1].handle, 0,4096,
tests/i915/gem_ctx_engines.c +1
-1+PROT_WRITE); cs[j] =0x24 <<23 |1 ;/* SRM */ if (has_64bit_reloc) cs[j]++; --2.25.1
Hi Vikas,
please improve your commit description in subject, now it is a little ambiguous, put also name of test you changed, so it will looks like:
tests/i915/gem_ctx_engines: Avoid SET_CACHING ioctl
or
tests/gem_ctx_engines: Avoid SET_CACHING ioctl
Subject: Re: [igt-dev] [PATCH i-g-t] Avoid caching ioctl during fork
Quoted 1 line · On 2022-10-17 at 13:28:22 +0530, vikassri07 wrote:
Both
gem_exec_flushandgem_ctx_enginesrequire theSET_CACHINGioctl
^^^^^
Remove whitespaces before text (here and below).
Quoted 1 line
for some subtests. The ioctl itself, called by
gem_set_caching, is
^^^^^
Quoted 7 lines
wrapped in an
igt_require, forcing a skip when the ioctl fails. MTL currently fails this check with-EOPNOTSUPP100% of the time.Normally, the ioctl failing and causing a test skip wouldn't be a problem. Howerver, the failing call to the ioctl is made within a forked child process in some cases, which causes an error to occur. By checking whether or not caching is supported before these cases occur,
^ ^ ^
Quoted 1 line
the resulting error can be downgraded to a graceful skip.
This long description is now wrong, I do not see any check added nor any igt_skip() ? Please correct commit description.
Please also read CONTRIBUTING.md from igt project and some other helpfull notes:
https://www.ozlabs.org/~akpm/stuff/tpp.txt
https://kernelnewbies.org/PatchPhilosophy
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
Quoted 10 lines
v2: The
gem_ctx_enginessubtest does not require usinggem_set_cachingif the domain is moved from CPU to WC, so the ioctl was removed from the execution path.
v3: Replacegem_mmap__cpuwithgem_mmap__device_coherentinstead ofgem_mmap__wcingem_ctx_engines.c
v4: Fix formattingReferences: VLK-34086
Signed-off-by vikas.srivastava <[email protected]>
-------------------- ^ ^^
This should be: Vikas Srivastava <[email protected]>
Quoted 3 lines
CC Jonathan Cavitt <[email protected]>CC Fei Yang <[email protected]>CC Chris Wilson <[email protected]>
^^^^^
Last line where you should remove white spaces.
Regards,
Kamil
Quoted 38 lines
--- tests/i915/gem_ctx_engines.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)tests/i915/gem_ctx_engines.c +4
-7@@ -492,12 +492,10 @@ static void independent(int i915, const intel_ctx_t *base_ctx, } param.ctx_id =gem_context_create (i915);gem_context_set_param (i915, ¶m); - -if (!gem_has_lmem (i915)) -gem_set_caching (i915, results.handle,I915_CACHING_CACHED ); - map =gem_mmap__cpu (i915, results.handle,0 ,4096 ,PROT_READ ); + + map =gem_mmap__device_coherent (i915, results.handle,0 ,4096 ,PROT_READ );gem_set_domain (i915, results.handle, -I915_GEM_DOMAIN_CPU ,I915_GEM_DOMAIN_CPU ); +I915_GEM_DOMAIN_WC ,I915_GEM_DOMAIN_WC );for (int i =0 ; i <I915_EXEC_RING_MASK +1 ; i++) {struct drm_i915_gem_exec_object2 obj[2 ] = {@@ -515,8 +513,7 @@ static void independent(int i915, const intel_ctx_t *base_ctx,uint32_t *cs;int j =0 ; - cs =gem_mmap__cpu (i915, obj[1 ].handle,0 ,4096 ,PROT_WRITE ); - + cs =gem_mmap__device_coherent (i915, obj[1 ].handle,0 ,4096 ,PROT_WRITE ); cs[j] =0x24 <<23 |1 ;/* SRM */ if (has_64bit_reloc) cs[j]++;Signature · 1 line
2.25.1