generic/193: add to perms group
PATCH 1/1 generic/193: add to perms group
This test changes permissions and specifically tests for setuid and setgid bits to be dropped or kept. It really needs to be run when -g perms is specified.
--- tests/generic/193 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/193 +1 -1
@@ -7,7 +7,7 @@ # Test permission checks in ->setattr # . ./common/preamble -_begin_fstest metadata auto quick +_begin_fstest metadata auto quick perms _register_cleanup "_cleanup_files" tag="added by qa $seq"
base-commit: a75c5f50584e03ca7862ad51f48efd2d524d1dc5
Signature · 1 line
2.34.1
Quoted 3 lines · Christian Brauner
This test changes permissions and specifically tests for setuid and setgid bits to be dropped or kept. It really needs to be run when -g perms is specified.
Yes, Reviewed-by: Yang Xu <[email protected]>
ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should also add perms group.
Best Regards
Yang Xu
Quoted 21 lines
Signed-off-by Christian Brauner (Microsoft) <[email protected]>--- tests/generic/193 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/193 +1
-1@@ -7,7 +7,7 @@ # Test permission checks in ->setattr # . ./common/preamble -_begin_fstest metadata auto quick +_begin_fstest metadata auto quick perms _register_cleanup "_cleanup_files" tag="added by qa $seq"base-commit:
a75c5f50584e03ca7862ad51f48efd2d524d1dc5
Quoted 11 lines · On Mon, Oct 17, 2022 at 10:01:13AM +0000, [email protected] wrote:
Quoted 3 lines · Christian Brauner
This test changes permissions and specifically tests for setuid and setgid bits to be dropped or kept. It really needs to be run when -g perms is specified.
Yes, Reviewed-by: Yang Xu <[email protected]>
ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should also add perms group.
OK, if Christian agrees with this point and would like to help that, please help to check and add "perms" to more proper cases in one patch.
Thanks,
Zorro
Quoted 24 lines
Best Regards
Yang XuQuoted 21 lines
Signed-off-by Christian Brauner (Microsoft) <[email protected]>--- tests/generic/193 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/193 +1
-1@@ -7,7 +7,7 @@ # Test permission checks in ->setattr # . ./common/preamble -_begin_fstest metadata auto quick +_begin_fstest metadata auto quick perms _register_cleanup "_cleanup_files" tag="added by qa $seq"base-commit:
a75c5f50584e03ca7862ad51f48efd2d524d1dc5
Quoted 8 lines · Zorro Lang
Quoted 7 lines · On Mon, Oct 17, 2022 at 10:01:13AM +0000, [email protected] wrote:
Quoted 3 lines · Christian Brauner
This test changes permissions and specifically tests for setuid and setgid bits to be dropped or kept. It really needs to be run when -g perms is specified.
Quoted 7 lines
Quoted 4 lines
Yes, Reviewed-by: Yang Xu <[email protected]>
ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should also add perms group.
OK, if Christian agrees with this point and would like to help that, please help to check and add "perms" to more proper cases in one patch.
I think that's a good idea. Yang, would you be open to sending a patch to add all these test to the "perms" group in one go?
Quoted 11 lines · Christian Brauner
Quoted 10 lines · Zorro Lang
Quoted 9 lines · On Mon, Oct 17, 2022 at 10:01:13AM +0000, [email protected] wrote:
Quoted 3 lines · Christian Brauner
This test changes permissions and specifically tests for setuid and setgid bits to be dropped or kept. It really needs to be run when -g perms is specified.
Yes, Reviewed-by: Yang Xu <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should also add perms group.
OK, if Christian agrees with this point and would like to help that, please help to check and add "perms" to more proper cases in one patch.
I think that's a good idea. Yang, would you be open to sending a patch to add all these test to the "perms" group in one go?
Of course, I will look for more case to add perms group in one patch as zorro and you sugguested.
Best Regards
Yang Xu