Skip to contentSkip to conversation

drm/amdgpu/sienna_cichlid: drop unused variables

PATCH In review Alex Deucher 2 participants 2 messages Oct 17, 2022 – Oct 18, 2022

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/sienna_cichlid: drop unused variables

They are no longer used so drop them.

Fixes 498acd86a942ae ("drm/amdgpu: Refactor mode2 reset logic for v11.0.7")
Cc Victor Zhao <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c +2 -2
index a096f0b740ce..81a6d5b94987 100644
@@ -33,8 +33,9 @@
 
 static bool sienna_cichlid_is_mode2_default(struct amdgpu_reset_control *reset_ctl)
 {
-	struct amdgpu_device *adev = (struct amdgpu_device *)reset_ctl->handle;
 #if 0
+	struct amdgpu_device *adev = (struct amdgpu_device *)reset_ctl->handle;
+
 	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(11, 0, 7) &&
 	    adev->pm.fw_version >= 0x3a5500 && !amdgpu_sriov_vf(adev))
 		return true;
@@ -47,7 +48,6 @@ sienna_cichlid_get_reset_handler(struct amdgpu_reset_control *reset_ctl,
 			    struct amdgpu_reset_context *reset_context)
 {
 	struct amdgpu_reset_handler *handler;
-	struct amdgpu_device *adev = (struct amdgpu_device *)reset_ctl->handle;
 
 	if (reset_context->method != AMD_RESET_METHOD_NONE) {
 		list_for_each_entry(handler, &reset_ctl->reset_handlers,
Signature · 1 line
2.37.3
Reviewed-by on v1 1/1
#1 lore raw

Regards,
Guchun

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Tuesday, October 18, 2022 12:48 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhao, Victor <[email protected]>
Subject: [PATCH] drm/amdgpu/sienna_cichlid: drop unused variables

They are no longer used so drop them.

Fixes 498acd86a942ae ("drm/amdgpu: Refactor mode2 reset logic for v11.0.7")
Cc Victor Zhao <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/sienna_cichlid.c +3 -3
index a096f0b740ce..81a6d5b94987 100644
@@ -33,8 +33,9 @@
 
 static bool sienna_cichlid_is_mode2_default(struct amdgpu_reset_control *reset_ctl)  {
-	struct amdgpu_device *adev = (struct amdgpu_device *)reset_ctl->handle;
 #if 0
+	struct amdgpu_device *adev = (struct amdgpu_device 
+*)reset_ctl->handle;
+
 	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(11, 0, 7) &&
 	    adev->pm.fw_version >= 0x3a5500 && !amdgpu_sriov_vf(adev))
 		return true;
@@ -47,7 +48,6 @@ sienna_cichlid_get_reset_handler(struct amdgpu_reset_control *reset_ctl,
 			    struct amdgpu_reset_context *reset_context)  {
 	struct amdgpu_reset_handler *handler;
-	struct amdgpu_device *adev = (struct amdgpu_device *)reset_ctl->handle;
 
 	if (reset_context->method != AMD_RESET_METHOD_NONE) {
 		list_for_each_entry(handler, &reset_ctl->reset_handlers,
--

2.37.3