RISC-V: stop selecting device drivers in Kconfig.socs
Subsystems (4)
cover RISC-V: stop selecting device drivers in Kconfig.socs
From: Conor Dooley <[email protected]>
As my RFC [0] series doing the symbol name changes has not yet reached consensus, I've split out the removal of device driver selects into a new series. I kept the plic as a direct select - although given how Maz is treating the SiFive plic driver as the RISC-V plic driver, maybe that should just be selected by default at an arch level...
I assume the individual patches can go via their subsystems & I'll resubmit the arch/riscv patches a cycle later? I'm not in any rush.
Thanks,
Conor.
0 - https://lore.kernel.org/linux-riscv/[email protected]/
Conor Dooley (6):
clk: sifive: select by default if SOC_SIFIVE
serial: sifive: select by default if SOC_SIFIVE
serial: sifive: select by default if SOC_CANAAN
riscv: stop selecting the PolarFire SoC clock driver
riscv: stop selecting SiFive clock and serial drivers directly
riscv: stop directly selecting drivers for SOC_CANAAN
arch/riscv/Kconfig.socs | 8 -------- drivers/clk/sifive/Kconfig | 4 +++- drivers/tty/serial/Kconfig | 2 ++ 3 files changed, 5 insertions(+), 9 deletions(-)
Signature · 1 line
2.37.3
PATCH 1/6 clk: sifive: select by default if SOC_SIFIVE
From: Conor Dooley <[email protected]>
With the aim of dropping direct selects of drivers from Kconfig.socs, default the SiFive clock drivers to the value of SOC_SIFIVE.
--- drivers/clk/sifive/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/sifive/Kconfig +3 -1
@@ -2,7 +2,8 @@ menuconfig CLK_SIFIVE bool "SiFive SoC driver support" - depends on RISCV || COMPILE_TEST + depends on SOC_SIFIVE || COMPILE_TEST + default SOC_SIFIVE help SoC drivers for SiFive Linux-capable SoCs.
@@ -10,6 +11,7 @@ if CLK_SIFIVE config CLK_SIFIVE_PRCI bool "PRCI driver for SiFive SoCs" + default SOC_SIFIVE select RESET_CONTROLLER select RESET_SIMPLE select CLK_ANALOGBITS_WRPLL_CLN28HPC
Signature · 1 line
2.37.3
Re: [PATCH 1/6] clk: sifive: select by default if SOC_SIFIVE
Quoting Conor Dooley (2022-10-05 10:13:44)
Quoted 7 lines
From: Conor Dooley <[email protected]>
With the aim of dropping direct selects of drivers from
Kconfig.socs, default the SiFive clock drivers to the value ofSOC_SIFIVE.Signed-off-by Conor Dooley <[email protected]>---
Applied to clk-fixes
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH 2/6 serial: sifive: select by default if SOC_SIFIVE
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
With the aim of dropping direct selects of drivers from Kconfig.socs, default the SiFive serial drivers to the value of SOC_SIFIVE.
--- drivers/tty/serial/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/tty/serial/Kconfig +2 -0
@@ -972,6 +972,7 @@ config SERIAL_OMAP_CONSOLE config SERIAL_SIFIVE tristate "SiFive UART support" depends on OF + default SOC_SIFIVE select SERIAL_CORE help Select this option if you are building a kernel for a device that
@@ -981,6 +982,7 @@ config SERIAL_SIFIVE config SERIAL_SIFIVE_CONSOLE bool "Console on SiFive UART" depends on SERIAL_SIFIVE=y + default SOC_SIFIVE select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON help
Signature · 1 line
2.37.3
PATCH 3/6 serial: sifive: select by default if SOC_CANAAN
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
With the aim of dropping direct selects of drivers from Kconfig.socs, default the SiFive serial drivers to enabled if SOC_CANAAN.
--- drivers/tty/serial/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/Kconfig +2 -2
@@ -972,7 +972,7 @@ config SERIAL_OMAP_CONSOLE config SERIAL_SIFIVE tristate "SiFive UART support" depends on OF - default SOC_SIFIVE + default SOC_SIFIVE || SOC_CANAAN select SERIAL_CORE help Select this option if you are building a kernel for a device that
@@ -982,7 +982,7 @@ config SERIAL_SIFIVE config SERIAL_SIFIVE_CONSOLE bool "Console on SiFive UART" depends on SERIAL_SIFIVE=y - default SOC_SIFIVE + default SOC_SIFIVE || SOC_CANAAN select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON help
Signature · 1 line
2.37.3
PATCH 4/6 riscv: stop selecting the PolarFire SoC clock driver
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
The driver is now enabled by default if SOC_MICROCHIP so there is no longer a need to select it in Kconfig.socs
--- arch/riscv/Kconfig.socs | 1 - 1 file changed, 1 deletion(-)
arch/riscv/Kconfig.socs +0 -1
@@ -2,7 +2,6 @@ menu "SoC selection" config SOC_MICROCHIP_POLARFIRE bool "Microchip PolarFire SoCs" - select MCHP_CLK_MPFS select SIFIVE_PLIC help This enables support for Microchip PolarFire SoC platforms.
Signature · 7 lines
2.37.3 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH 5/6 riscv: stop selecting SiFive clock and serial drivers directly
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
The SiFive clock and serial drivers will now default to the value of SOC_SIFIVE so there is no need to directly select their symbols anymore.
--- arch/riscv/Kconfig.socs | 4 ---- 1 file changed, 4 deletions(-)
arch/riscv/Kconfig.socs +0 -4
@@ -8,10 +8,6 @@ config SOC_MICROCHIP_POLARFIRE config SOC_SIFIVE bool "SiFive SoCs" - select SERIAL_SIFIVE if TTY - select SERIAL_SIFIVE_CONSOLE if TTY - select CLK_SIFIVE - select CLK_SIFIVE_PRCI select SIFIVE_PLIC select ERRATA_SIFIVE if !XIP_KERNEL help
Signature · 7 lines
2.37.3 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH 6/6 riscv: stop directly selecting drivers for SOC_CANAAN
In reply to Conor DooleyFrom: Conor Dooley <[email protected]>
The serial and clock drivers will be enabled by default if the symbol itself is enabled, so stop directly selecting the drivers in Kconfigs.socs.
--- arch/riscv/Kconfig.socs | 3 --- 1 file changed, 3 deletions(-)
arch/riscv/Kconfig.socs +0 -3
@@ -40,13 +40,10 @@ config SOC_CANAAN bool "Canaan Kendryte K210 SoC" depends on !MMU select CLINT_TIMER if RISCV_M_MODE - select SERIAL_SIFIVE if TTY - select SERIAL_SIFIVE_CONSOLE if TTY select SIFIVE_PLIC select ARCH_HAS_RESET_CONTROLLER select PINCTRL select COMMON_CLK - select COMMON_CLK_K210 help This enables support for Canaan Kendryte K210 SoC platform hardware.
Signature · 7 lines
2.37.3 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 10 lines · Conor Dooley
From: Conor Dooley <[email protected]>
As my RFC [0] series doing the symbol name changes has not yet reached consensus, I've split out the removal of device driver selects into a new series. I kept the plic as a direct select - although given how Maz is treating the SiFive plic driver as the RISC-V plic driver, maybe that should just be selected by default at an arch level...
I assume the individual patches can go via their subsystems & I'll resubmit the
arch/riscvpatches a cycle later? I'm not in any rush.
Hey,
What's the story here with the two serial patches, they just waiting for an Ack? I think these are archived on the riscv patchwork, so if that is the case I'll unarchive them and mark as needing one.
Thanks,
Conor.
Quoted 19 lines
0 - https://lore.kernel.org/linux-riscv/[email protected]/
Conor Dooley (6):
clk: sifive: select by default ifSOC_SIFIVE
serial: sifive: select by default ifSOC_SIFIVE
serial: sifive: select by default ifSOC_CANAAN
riscv: stop selecting the PolarFire SoC clock driver
riscv: stop selecting SiFive clock and serial drivers directly
riscv: stop directly selecting drivers forSOC_CANAANarch/riscv/Kconfig.socs | 8 -------- drivers/clk/sifive/Kconfig | 4 +++- drivers/tty/serial/Kconfig | 2 ++ 3 files changed, 5 insertions(+), 9 deletions(-)Signature · 1 line
2.37.3
Greg Kroah-Hartman
maintainerQuoted 9 lines · Conor Dooley
Quoted 8 lines · Conor Dooley
From: Conor Dooley <[email protected]>
As my RFC [0] series doing the symbol name changes has not yet reached consensus, I've split out the removal of device driver selects into a new series. I kept the plic as a direct select - although given how Maz is treating the SiFive plic driver as the RISC-V plic driver, maybe that should just be selected by default at an arch level...
Quoted 8 lines
Quoted 2 lines
I assume the individual patches can go via their subsystems & I'll resubmit the
arch/riscvpatches a cycle later? I'm not in any rush.Hey,
What's the story here with the two serial patches, they just waiting for an Ack? I think these are archived on the riscv patchwork, so if that is the case I'll unarchive them and mark as needing one.
Sorry for the delay, I'll take both of them through the tty/serial tree.
thanks,
greg k-h
Quoted 13 lines · Greg Kroah-Hartman
Quoted 12 lines · Conor Dooley
Quoted 10 lines · Conor Dooley
From: Conor Dooley <[email protected]>
As my RFC [0] series doing the symbol name changes has not yet reached consensus, I've split out the removal of device driver selects into a new series. I kept the plic as a direct select - although given how Maz is treating the SiFive plic driver as the RISC-V plic driver, maybe that should just be selected by default at an arch level...
I assume the individual patches can go via their subsystems & I'll resubmit the
arch/riscvpatches a cycle later? I'm not in any rush.
Quoted 7 lines
Quoted 5 lines
Hey,
What's the story here with the two serial patches, they just waiting for an Ack? I think these are archived on the riscv patchwork, so if that is the case I'll unarchive them and mark as needing one.
Sorry for the delay, I'll take both of them through the tty/serial tree.
nw Greg, thanks.
@Palmer, I'll re-submit the Kconfig.socs bits of this after v6.2-rc1.
Thanks,
Conor.