pinctrl: cy8c95x0: Don't use cy8c95x0_set_mode() twice
Subsystems (3)
PATCH 1/1 pinctrl: cy8c95x0: Don't use cy8c95x0_set_mode() twice
Instead, call it once in cy8c95x0_pinmux_mode() and if selector is 0, shortcut the flow by returning 0 immediately.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/pinctrl/pinctrl-cy8c95x0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/pinctrl-cy8c95x0.c +4 -4
@@ -1107,13 +1107,13 @@ static int cy8c95x0_pinmux_mode(struct cy8c95x0_pinctrl *chip,u8 bit =cypress_get_pin_mask (chip, group);int ret; -if (selector ==0 ) -return cy8c95x0_set_mode (chip, group, false); - - ret =cy8c95x0_set_mode (chip, group, true); + ret =cy8c95x0_set_mode (chip, group, selector);if (ret <0 )return ret; +if (selector ==0 ) +return 0 ; +/* Set direction to output & set output to 1 so that PWM can work */ ret =regmap_write_bits (chip->regmap,CY8C95X0_DIRECTION , bit, bit);if (ret <0 )
Signature · 1 line
2.35.1
Quoted 4 lines · Andy Shevchenko
Instead, call it once in
cy8c95x0_pinmux_mode()and if selector is 0, shortcut the flow by returning 0 immediately.Signed-off-by Andy Shevchenko <[email protected]>
Patch applied!
Yours,
Linus Walleij