vfio: platform: Do not pass return buffer to ACPI _RST method
Subsystems (3)
PATCH 1/1 vfio: platform: Do not pass return buffer to ACPI _RST method
The ACPI _RST method has no return value, there's no need to pass a return buffer to acpi_evaluate_object().
Fixes d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
Signed-off-by Rafael Mendonca <[email protected]>
--- drivers/vfio/platform/vfio_platform_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/vfio/platform/vfio_platform_common.c +1 -2
@@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, const char **extra_dbg) {#ifdef CONFIG_ACPI -struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER ,NULL };struct device *dev = vdev->device;acpi_handle handle =ACPI_HANDLE (dev);acpi_status acpi_ret; - acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL , &buffer); + acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL ,NULL );if (ACPI_FAILURE (acpi_ret)) {if (extra_dbg) *extra_dbg =acpi_format_exception (acpi_ret);
Signature · 1 line
2.34.1
Hi Rafael,
Quoted 5 lines · Rafael Mendonca
The ACPI
_RSTmethod has no return value, there's no need to pass a return buffer toacpi_evaluate_object().Fixes d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")Signed-off-by Rafael Mendonca <[email protected]>
Reviewed-by Eric Auger <[email protected]>
Thanks
Eric
Quoted 22 lines
--- drivers/vfio/platform/vfio_platform_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/vfio/platform/vfio_platform_common.c +1
-2@@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, const char **extra_dbg) {#ifdef CONFIG_ACPI -struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER ,NULL };struct device *dev = vdev->device;acpi_handle handle =ACPI_HANDLE (dev);acpi_status acpi_ret; - acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL , &buffer); + acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL ,NULL );if (ACPI_FAILURE (acpi_ret)) {if (extra_dbg) *extra_dbg =acpi_format_exception (acpi_ret);
Alex Williamson
AppliedQuoted 17 lines · On Tue, 18 Oct 2022 12:28:25 -0300 Rafael Mendonca <[email protected]>…
The ACPI
_RSTmethod has no return value, there's no need to pass a return buffer toacpi_evaluate_object().Fixes d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")Signed-off-by Rafael Mendonca <[email protected]>--- drivers/vfio/platform/vfio_platform_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/vfio/platform/vfio_platform_common.c +0
-0@@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, const char **extra_dbg) {#ifdef CONFIG_ACPI
drivers/vfio/platform/vfio_platform_common.c static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, · line 82
Quoted 10 lines
drivers/vfio/platform/vfio_platform_common.c +1
-2-struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER ,NULL };struct device *dev = vdev->device;acpi_handle handle =ACPI_HANDLE (dev);acpi_status acpi_ret; - acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL , &buffer); + acpi_ret =acpi_evaluate_object (handle,"_RST" ,NULL ,NULL );if (ACPI_FAILURE (acpi_ret)) {if (extra_dbg) *extra_dbg =acpi_format_exception (acpi_ret);
Applied to vfio next branch for v6.2. Thanks,
Alex