Skip to contentSkip to conversation

arm64/asm: Remove unused enable_da macro

PATCH Applied Mark Brown 3 participants 3 messages Oct 19, 2022 – Nov 7, 2022 arm64

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 arm64/asm: Remove unused enable_da macro

We no longer use the enable_da macro, remove it to avoid having to think about maintaining it.

---
 arch/arm64/include/asm/assembler.h | 5 -----
 1 file changed, 5 deletions(-)
arch/arm64/include/asm/assembler.h +0 -5
index e5957a53be39..27e0c75f7818 100644
@@ -51,11 +51,6 @@
 	msr	daif, \flags
 	.endm
 
-	/* IRQ/FIQ are the lowest priority flags, unconditionally unmask the rest. */
-	.macro enable_da
-	msr	daifclr, #(8 | 4)
-	.endm
-
 /*
  * Save/restore interrupts.
  */

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Mark Brown

We no longer use the enable_da macro, remove it to avoid having to think about maintaining it.

Whhops; I had meant to remove that when I got rid of the last user in commit:

064dbfb416914194 ("arm64: entry: convert IRQ+FIQ handlers to C")

FWIW:

Mark.

Quoted 21 lines
---
 arch/arm64/include/asm/assembler.h | 5 -----
 1 file changed, 5 deletions(-)
arch/arm64/include/asm/assembler.h +0 -5
index e5957a53be39..27e0c75f7818 100644
@@ -51,11 +51,6 @@
 	msr	daif, \flags
 	.endm
 
-	/* IRQ/FIQ are the lowest priority flags, unconditionally unmask the rest. */
-	.macro enable_da
-	msr	daifclr, #(8 | 4)
-	.endm
-
 /*
  * Save/restore interrupts.
  */
Quoted 9 lines

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Applied
#2 lore raw
In reply to Mark Brown
Quoted 4 lines · Mark Brown

We no longer use the enable_da macro, remove it to avoid having to think about maintaining it.

Applied to arm64 (for-next/trivial), thanks!

[1/1] arm64/asm: Remove unused enable_da macro

      https://git.kernel.org/arm64/c/e8e510411847

Cheers,

Signature · 10 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel