Skip to contentSkip to conversation

GICv3: Emulate GICD_IGRPMODR as RAZ / WI

PATCH Superseded Ayan Kumar Halder 2 participants 3 messages Oct 19, 2022 – Oct 20, 2022

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GICv3: Emulate GICD_IGRPMODR as RAZ / WI

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to IGROUPR) is relevant only when the guests run in secure/non-secure mode. As Xen does not implement security extensions for guests, so the registers are emulated as read as zero/write ignore.

---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

 xen/arch/arm/include/asm/gic.h | 2 ++
 xen/arch/arm/vgic-v3.c         | 4 ++++
 2 files changed, 6 insertions(+)
xen/arch/arm/include/asm/gic.h +2 -0
index 76e3fa5dc4..998dd62651 100644
@@ -48,6 +48,8 @@
 #define GICD_ICFGR1     (0xC04)
 #define GICD_ICFGR2     (0xC08)
 #define GICD_ICFGRN     (0xCFC)
+#define GICD_IGRPMODR   (0xD00)
+#define GICD_IGRPMODRN  (0xD7C)
 #define GICD_NSACR      (0xE00)
 #define GICD_NSACRN     (0xEFC)
 #define GICD_SGIR       (0xF00)
xen/arch/arm/vgic-v3.c +4 -0
index 7fb99a9ff2..0c23f6df9d 100644
@@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, read zero */
         if ( dabt.size != DABT_WORD ) goto bad_width;
         goto read_as_zero;
@@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, write ignore */
         goto write_ignore_32;
 
@@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /*
          * Above all register are common with GICR and GICD
          * Manage in common
@@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* Above registers are common with GICR and GICD
          * Manage in common */
         return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
Signature · 1 line
2.17.1
#1 lore raw

Hi Ayan,

Quoted 22 lines · Ayan Kumar Halder

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to IGROUPR) is relevant only when the guests run in secure/non-secure mode. As Xen does not implement security extensions for guests, so the registers are emulated as read as zero/write ignore.

---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

 xen/arch/arm/include/asm/gic.h | 2 ++
 xen/arch/arm/vgic-v3.c         | 4 ++++
 2 files changed, 6 insertions(+)
xen/arch/arm/include/asm/gic.h +0 -0
index 76e3fa5dc4..998dd62651 100644

xen/arch/arm/include/asm/gic.h line 52

Quoted 5 lines
xen/arch/arm/include/asm/gic.h +2 -0
@@ -48,6 +48,8 @@
 #define GICD_ICFGR1     (0xC04)
 #define GICD_ICFGR2     (0xC08)
 #define GICD_ICFGRN     (0xCFC)
+#define GICD_IGRPMODR   (0xD00)
+#define GICD_IGRPMODRN  (0xD7C)

These registers are GICv3 specific and as such should be defined in arch/arm/include/asm/gic_v3_defs.h.

~Michal

#2 lore raw
Quoted 1 line · Michal Orzel

Hi Ayan,

Hi Michal,

Quoted 18 lines · Ayan Kumar Halder
Quoted 16 lines

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to IGROUPR) is relevant only when the guests run in secure/non-secure mode. As Xen does not implement security extensions for guests, so the registers are emulated as read as zero/write ignore.

---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

  xen/arch/arm/include/asm/gic.h | 2 ++
  xen/arch/arm/vgic-v3.c         | 4 ++++
  2 files changed, 6 insertions(+)
Quoted 12 lines

xen/arch/arm/include/asm/gic.h line 52

Quoted 10 lines
xen/arch/arm/include/asm/gic.h +2 -0
index 76e3fa5dc4..998dd62651 100644
@@ -48,6 +48,8 @@
  #define GICD_ICFGR1     (0xC04)
  #define GICD_ICFGR2     (0xC08)
  #define GICD_ICFGRN     (0xCFC)
+#define GICD_IGRPMODR   (0xD00)
+#define GICD_IGRPMODRN  (0xD7C)

These registers are GICv3 specific and as such should be defined in arch/arm/include/asm/gic_v3_defs.h.

Thanks for pointing out. I have fixed this in v2.

- Ayan

Quoted 2 lines

~Michal