usb: typec: retimer: Use device type for matching
Subsystems (2)
Heikki Krogerus
maintainerPATCH 1/1 usb: typec: retimer: Use device type for matching
Device name is not reliable so using the type instead in retimer_fwnode_match().
This will also introduce is_typec_retimer() helper, and remove the static keyword from the retimer device type. That will make it accessible also in the main typec class.
Signed-off-by Heikki Krogerus <[email protected]>
--- drivers/usb/typec/retimer.c | 16 ++-------------- drivers/usb/typec/retimer.h | 4 ++++ 2 files changed, 6 insertions(+), 14 deletions(-)
drivers/usb/typec/retimer.c +2 -14
@@ -17,21 +17,9 @@#include "class.h" #include "retimer.h" -static bool dev_name_ends_with (struct device *dev,const char *suffix) -{ -const char *name =dev_name (dev); -const int name_len =strlen (name); -const int suffix_len =strlen (suffix); - -if (suffix_len > name_len) -return false; - -return strcmp (name + (name_len - suffix_len), suffix) ==0 ; -} -static int retimer_fwnode_match (struct device *dev,const void *fwnode) { -return device_match_fwnode (dev, fwnode) &&dev_name_ends_with (dev,"-retimer" ); +return is_typec_retimer (dev) &&device_match_fwnode (dev, fwnode); }static void *typec_retimer_match (struct fwnode_handle *fwnode,const char *id,void *data)
@@ -97,7 +85,7 @@ static void typec_retimer_release(struct device *dev)kfree (to_typec_retimer (dev)); } -static const struct device_type typec_retimer_dev_type = { +const struct device_type typec_retimer_dev_type = { .name ="typec_retimer" , .release = typec_retimer_release, };
drivers/usb/typec/retimer.h +4 -0
@@ -12,4 +12,8 @@ struct typec_retimer {#define to_typec_retimer (_dev_) container_of(_dev_, struct typec_retimer, dev) +const struct device_type typec_retimer_dev_type; + +#define is_typec_retimer (dev) ((dev)->type == &typec_retimer_dev_type) +#endif /* __USB_TYPEC_RETIMER__ */
Signature · 1 line
2.35.1