Skip to contentSkip to conversation

package/libnss: disable parallel build with Make 4.4

PATCH In review Giulio Benetti 2 participants 8 messages Oct 19, 2022 – Nov 20, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libnss: disable parallel build with Make 4.4

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

---
 package/libnss/libnss.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +2 -2
index 041b2cfc56..a613006f70 100644
@@ -15,8 +15,8 @@ LIBNSS_LICENSE_FILES = nss/COPYING
 LIBNSS_CPE_ID_VENDOR = mozilla
 LIBNSS_CPE_ID_PRODUCT = nss
 
-# Don't parallel build if make version = 4.3
-ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
+# Don't parallel build if make version = 4.3 or 4.4
+ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3 4.4),)
 LIBNSS_MAKE = $(MAKE1)
 else
 LIBNSS_MAKE = $(MAKE)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 3 lines · Giulio Benetti

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

Quoted 24 lines
---
 package/libnss/libnss.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +2 -3
index 041b2cfc56..a613006f70 100644
@@ -15,8 +15,8 @@ LIBNSS_LICENSE_FILES = nss/COPYING
 LIBNSS_CPE_ID_VENDOR = mozilla
 LIBNSS_CPE_ID_PRODUCT = nss
 
-# Don't parallel build if make version = 4.3
-ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
+# Don't parallel build if make version = 4.3 or 4.4
+ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3 4.4),)
 LIBNSS_MAKE = $(MAKE1)
 else
 LIBNSS_MAKE = $(MAKE)
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
Quoted 10 lines · James Hilliard
Quoted 3 lines · Giulio Benetti

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Quoted 25 lines
Quoted 25 lines
---
 package/libnss/libnss.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +2 -3
index 041b2cfc56..a613006f70 100644
@@ -15,8 +15,8 @@ LIBNSS_LICENSE_FILES = nss/COPYING
 LIBNSS_CPE_ID_VENDOR = mozilla
 LIBNSS_CPE_ID_PRODUCT = nss
 
-# Don't parallel build if make version = 4.3
-ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
+# Don't parallel build if make version = 4.3 or 4.4
+ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3 4.4),)
 LIBNSS_MAKE = $(MAKE1)
 else
 LIBNSS_MAKE = $(MAKE)
--

2.34.1

Quoted 4 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Hi James,

Quoted 11 lines

Il giorno 20 ott 2022, alle ore 02:23, James Hilliard <[email protected]> ha scritto:

On Wed, Oct 19, 2022 at 7:36 PM James Hilliard

Quoted 7 lines · <[email protected]> wrote:
Quoted 6 lines

On Wed, Oct 19, 2022 at 3:55 PM Giulio Benetti
<[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Quoted 8 lines
Quoted 3 lines

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Thank you for testing, I have forgotten exactly to ask you to do it :-) since almost all the failures comes from your asahi-mini that I remember to have Make 4.4.

So I try to reproduce the bug here at me and find out a fix.

Thanks again

Best regards
Giulio

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines

---
package/libnss/libnss.mk | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +0 -0
index 041b2cfc56..a613006f70 100644
@@ -15,8 +15,8 @@ LIBNSS_LICENSE_FILES = nss/COPYING

LIBNSS_CPE_ID_VENDOR = mozilla
LIBNSS_CPE_ID_PRODUCT = nss

package/libnss/libnss.mk +2 -2
-# Don't parallel build if make version = 4.3
-ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
+# Don't parallel build if make version = 4.3 or 4.4
+ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3 4.4),)

LIBNSS_MAKE = $(MAKE1)
else
LIBNSS_MAKE = $(MAKE)
--
2.34.1

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
Quoted 18 lines · Giulio Benetti

Hi James,

Quoted 15 lines

Il giorno 20 ott 2022, alle ore 02:23, James Hilliard <[email protected]> ha scritto:

On Wed, Oct 19, 2022 at 7:36 PM James Hilliard

Quoted 10 lines · <[email protected]> wrote:
Quoted 6 lines

On Wed, Oct 19, 2022 at 3:55 PM Giulio Benetti
<[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

Quoted 6 lines
Quoted 4 lines

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Thank you for testing, I have forgotten exactly to ask you to do it :-) since almost all the failures comes from your asahi-mini that I remember to have Make 4.4.

I'm running make master branch on all my autobuilders at the moment, the failures aren't limited to asahi-mini:
http://autobuild.buildroot.net/?reason=libnss-3.84

Quoted 2 lines

So I try to reproduce the bug here at me and find out a fix.

Use make master branch from here for testing:
git clone https://git.savannah.gnu.org/git/make.git

Quoted 32 lines

Thanks again

Best regards
Giulio

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines

---
package/libnss/libnss.mk | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
package/libnss/libnss.mk +0 -0
index 041b2cfc56..a613006f70 100644
@@ -15,8 +15,8 @@ LIBNSS_LICENSE_FILES = nss/COPYING

LIBNSS_CPE_ID_VENDOR = mozilla
LIBNSS_CPE_ID_PRODUCT = nss

package/libnss/libnss.mk +2 -2
-# Don't parallel build if make version = 4.3
-ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3),)
+# Don't parallel build if make version = 4.3 or 4.4
+ifneq ($(filter $(RUNNING_MAKE_VERSION),4.3 4.4),)

LIBNSS_MAKE = $(MAKE1)
else
LIBNSS_MAKE = $(MAKE)
--
2.34.1

Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Hi James,

Quoted 32 lines · James Hilliard
Quoted 18 lines · Giulio Benetti

Hi James,

Quoted 15 lines

Il giorno 20 ott 2022, alle ore 02:23, James Hilliard <[email protected]> ha scritto:

On Wed, Oct 19, 2022 at 7:36 PM James Hilliard

Quoted 10 lines · <[email protected]> wrote:
Quoted 6 lines

On Wed, Oct 19, 2022 at 3:55 PM Giulio Benetti
<[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

Quoted 6 lines
Quoted 4 lines

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Thank you for testing, I have forgotten exactly to ask you to do it :-) since almost all the failures comes from your asahi-mini that I remember to have Make 4.4.

I'm running make master branch on all my autobuilders at the moment, the failures aren't limited to asahi-mini:
http://autobuild.buildroot.net/?reason=libnss-3.84

Quoted 1 line
Quoted 5 lines
Quoted 1 line

So I try to reproduce the bug here at me and find out a fix.

Use make master branch from here for testing:
git clone https://git.savannah.gnu.org/git/make.git

After lot of time I've found a way to fix this bug with this patch:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Can you please give a try at you too and give a Tested-by tag?

Thank you
Best regards

Signature · 6 lines
Giulio Benetti
CEO/CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#6 lore raw
Quoted 38 lines · Giulio Benetti

Hi James,

Quoted 34 lines · James Hilliard
Quoted 18 lines · Giulio Benetti

Hi James,

Quoted 15 lines

Il giorno 20 ott 2022, alle ore 02:23, James Hilliard <[email protected]> ha scritto:

On Wed, Oct 19, 2022 at 7:36 PM James Hilliard

Quoted 10 lines · <[email protected]> wrote:
Quoted 6 lines

On Wed, Oct 19, 2022 at 3:55 PM Giulio Benetti
<[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

Quoted 6 lines
Quoted 4 lines

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Thank you for testing, I have forgotten exactly to ask you to do it :-) since almost all the failures comes from your asahi-mini that I remember to have Make 4.4.

I'm running make master branch on all my autobuilders at the moment, the failures aren't limited to asahi-mini:
http://autobuild.buildroot.net/?reason=libnss-3.84

Quoted 2 lines

So I try to reproduce the bug here at me and find out a fix.

Quoted 8 lines
Quoted 3 lines

Use make master branch from here for testing:
git clone https://git.savannah.gnu.org/git/make.git

After lot of time I've found a way to fix this bug with this patch:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Can you please give a try at you too and give a Tested-by tag?

Yeah, I verified it works on the recently released make 4.4 final.

Quoted 6 lines

Thank you
Best regards
--
Giulio Benetti
CEO/CTO@Benetti Engineering sas

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw

Hi James,

Quoted 46 lines

Il giorno 20 nov 2022, alle ore 19:41, James Hilliard <[email protected]> ha scritto:

On Thu, Nov 17, 2022 at 3:48 PM Giulio Benetti

Quoted 42 lines · <[email protected]> wrote:

Hi James,

Quoted 38 lines · James Hilliard
Quoted 18 lines · Giulio Benetti

Hi James,

Quoted 15 lines

Il giorno 20 ott 2022, alle ore 02:23, James Hilliard <[email protected]> ha scritto:

On Wed, Oct 19, 2022 at 7:36 PM James Hilliard

Quoted 10 lines · <[email protected]> wrote:
Quoted 6 lines

On Wed, Oct 19, 2022 at 3:55 PM Giulio Benetti
<[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/433/4335d0d8454035a8f74645ba8d6c2329ab2e5480/

Hmm, this looks like a bug in the libnss makefile, what was the failure seen with make 4.3 here:
https://lore.kernel.org/buildroot/[email protected]/

Quoted 6 lines
Quoted 4 lines

This patch also does not fix the build with make 4.4(make from master branch) from my testing.

Even without shuffle mode enabled the build appears to always fail.

Thank you for testing, I have forgotten exactly to ask you to do it :-) since almost all the failures comes from your asahi-mini that I remember to have Make 4.4.

I'm running make master branch on all my autobuilders at the moment, the failures aren't limited to asahi-mini:
http://autobuild.buildroot.net/?reason=libnss-3.84

Quoted 2 lines

So I try to reproduce the bug here at me and find out a fix.

Use make master branch from here for testing:
git clone https://git.savannah.gnu.org/git/make.git

Quoted 6 lines
Quoted 4 lines

After lot of time I've found a way to fix this bug with this patch:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Can you please give a try at you too and give a Tested-by tag?

Yeah, I verified it works on the recently released make 4.4 final.

Thanks a lot!

Giulio

Quoted 11 lines
Quoted 7 lines

Thank you
Best regards
--
Giulio Benetti
CEO/CTO@Benetti Engineering sas

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot