i40e: add a fault tolerance judgment
Subsystems (3)
PATCH 1/1 i40e: add a fault tolerance judgment
From: Linkui Xiao <[email protected]>
Avoid requesting memory when system memory resources are insufficient. Reference function i40e_setup_tx_descriptors, adding fault tolerance handling.
--- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_txrx.c +3 -0
@@ -1565,6 +1565,9 @@ int i40e_setup_rx_descriptors(struct i40e_ring *rx_ring)struct device *dev = rx_ring->dev;int err; +if (!dev) +return -ENOMEM ; +u64_stats_init (&rx_ring->syncp);/* Round up to nearest 4K */
Signature · 1 line
2.17.1
Quoted 16 lines · xiaolinkui
From: Linkui Xiao <[email protected]>
Avoid requesting memory when system memory resources are insufficient. Reference function
i40e_setup_tx_descriptors, adding fault tolerance handling.Signed-off-by Linkui Xiao <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 +++ 1 file changed, 3 insertions(+)drivers/net/ethernet/intel/i40e/i40e_txrx.c +0
-0
drivers/net/ethernet/intel/i40e/i40e_txrx.c int i40e_setup_rx_descriptors(struct i40e_ring *rx_ring) · line 1570
Quoted 6 lines
drivers/net/ethernet/intel/i40e/i40e_txrx.c +3
-0@@ -1565,6 +1565,9 @@ int i40e_setup_rx_descriptors(struct i40e_ring *rx_ring)struct device *dev = rx_ring->dev;int err; +if (!dev) +return -ENOMEM ; +
What is this trying to protect against? When does a ring not have a dev pointer? This seems more like patching over a buggy setup where we failed to assign a device pointer.
How does this protect against use of system memory resources? It also doesn't seem like it would significantly improve fault tolerance since its possible to have a non-NULL but invalid dev pointer...
Thanks,
Jake
Quoted 3 lines
drivers/net/ethernet/intel/i40e/i40e_txrx.c +0
-0u64_stats_init (&rx_ring->syncp);/* Round up to nearest 4K */