Skip to contentSkip to conversation

pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

PATCH In review Yang Yingliang 3 participants 3 messages Oct 20, 2022 – Oct 24, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it to static.

Fixes 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
---
 drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-sdm670.c +1 -1
index 4c3c3782fef8..b888bca7ecd7 100644
@@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
 	SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
 };
 
-const int sdm670_reserved_gpios[] = {
+static const int sdm670_reserved_gpios[] = {
 	58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
 };
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

Quoted 5 lines

sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it to static.

Fixes 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")

The email headers could maybe use a little work.

From: Yang Yingliang <[email protected]>
To: <[email protected]>
CC: <[email protected]>, <[email protected]>,
<[email protected]>
Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static

You don't need to remove people's names from their email addresses; they can go together like so (not a strict requirement, but a nice touch in everyone's mailboxes):

CC: Richard Acayan <[email protected]>,
Linus Walleij <[email protected]>, Yang Yingliang <[email protected]>

For this patch, there is a typo in the subject:

-Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static +Subject: [PATCH -next] pinctrl: qcom: sdm670: change sdm670_reserved_gpios to static

Otherwise, it looks good.

Quoted 19 lines
---
 drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-sdm670.c +1 -1
index 4c3c3782fef8..b888bca7ecd7 100644
@@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
 	SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
 };
 
-const int sdm670_reserved_gpios[] = {
+static const int sdm670_reserved_gpios[] = {
 	58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
 };
 
Signature · 1 line
2.25.1