Skip to contentSkip to conversation

perf vendor events: Add Arm Neoverse V2 PMU events

PATCH Applied James Clark 4 participants 5 messages Oct 20, 2022 – Nov 10, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf vendor events: Add Arm Neoverse V2 PMU events

Rename the neoverse-n2 folder to make it clear that it includes V2, and add V2 to mapfile.csv. V2 has the same events as N2, visible by running the following command in the ARM-software/data github repo [1]:

diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code

Testing:

  $ perf test pmu
  10: PMU events                                           :
  10.1: PMU event table sanity                             : Ok
  10.2: PMU event map aliases                              : Ok
  10.3: Parsing of PMU event table metrics                 : Ok
  10.4: Parsing of PMU event table metrics with fake PMUs  : Ok

[1]: https://github.com/ARM-software/data

---
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/branch.json | 0
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/bus.json    | 0
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/cache.json  | 0
 .../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/exception.json   | 0
 .../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/instruction.json | 0
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/memory.json | 0
 .../arm64/arm/{neoverse-n2 => neoverse-n2-v2}/pipeline.json    | 0
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/spe.json    | 0
 .../arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/trace.json  | 0
 tools/perf/pmu-events/arch/arm64/mapfile.csv                   | 3 ++-
 10 files changed, 2 insertions(+), 1 deletion(-)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/branch.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/bus.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/cache.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/exception.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/instruction.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/memory.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/pipeline.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/spe.json (100%)
 rename tools/perf/pmu-events/arch/arm64/arm/{neoverse-n2 => neoverse-n2-v2}/trace.json (100%)
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/branch.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/branch.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/branch.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/branch.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/bus.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/bus.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/bus.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/bus.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/cache.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/cache.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/cache.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/cache.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/exception.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/exception.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/exception.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/exception.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/instruction.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/instruction.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/instruction.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/instruction.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/memory.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/memory.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/pipeline.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/pipeline.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/pipeline.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/spe.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/spe.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/spe.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/spe.json
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/trace.json renamed from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/trace.json +0 -0
similarity index 100%
rename from tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/trace.json
rename to tools/perf/pmu-events/arch/arm64/arm/neoverse-n2-v2/trace.json
tools/perf/pmu-events/arch/arm64/mapfile.csv +2 -1
index ad502d00f460..f134e833c069 100644
@@ -34,7 +34,8 @@
 0x00000000410fd460,v1,arm/cortex-a510,core
 0x00000000410fd470,v1,arm/cortex-a710,core
 0x00000000410fd480,v1,arm/cortex-x2,core
-0x00000000410fd490,v1,arm/neoverse-n2,core
+0x00000000410fd490,v1,arm/neoverse-n2-v2,core
+0x00000000410fd4f0,v1,arm/neoverse-n2-v2,core
 0x00000000420f5160,v1,cavium/thunderx2,core
 0x00000000430f0af0,v1,cavium/thunderx2,core
 0x00000000460f0010,v1,fujitsu/a64fx,core
Signature · 1 line
2.28.0
#1 lore raw
Quoted 16 lines · James Clark

Rename the neoverse-n2 folder to make it clear that it includes V2, and add V2 to mapfile.csv. V2 has the same events as N2, visible by running the following command in the ARM-software/data github repo [1]:

diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code

Testing:

   $ perf test pmu
   10: PMU events                                           :
   10.1: PMU event table sanity                             : Ok
   10.2: PMU event map aliases                              : Ok
   10.3: Parsing of PMU event table metrics                 : Ok
   10.4: Parsing of PMU event table metrics with fake PMUs  : Ok
Quoted 4 lines

[1]:https://github.com/ARM-software/data

---

This looks ok. Out of curiosity, do you know how the naming works for these neoverse cores? Were "n" a predecessor to "v"?

thanks,
John

#2 lore raw
Quoted 17 lines · John Garry
Quoted 16 lines · James Clark

Rename the neoverse-n2 folder to make it clear that it includes V2, and add V2 to mapfile.csv. V2 has the same events as N2, visible by running the following command in the ARM-software/data github repo [1]:

   diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code

Testing:

   $ perf test pmu

   10: PMU events                                           :
   10.1: PMU event table sanity                             : Ok 10.2: PMU event map aliases                              : Ok 10.3: Parsing of PMU event table metrics                 : Ok 10.4: Parsing of PMU event table metrics with fake PMUs  : Ok

Quoted 7 lines
Quoted 4 lines

[1]:https://github.com/ARM-software/data

---

This looks ok. Out of curiosity, do you know how the naming works for these neoverse cores? Were "n" a predecessor to "v"?

Thanks for the review. No, they're more like different product lines than predecessors. From the image on this article [1], N are focused on performance per watt and V are high performance.

[1]:
https://www.arm.com/company/news/2022/09/redefining-the-global-computing-infrastructure-with-next-generation-arm-neoverse-platforms

Quoted 3 lines

thanks,
John

Reviewed-by on v1 1/1
#3 lore raw
In reply to James Clark
Quoted 16 lines · James Clark

Rename the neoverse-n2 folder to make it clear that it includes V2, and add V2 to mapfile.csv. V2 has the same events as N2, visible by running the following command in the ARM-software/data github repo [1]:

diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code

Testing:

   $ perf test pmu
   10: PMU events                                           :
   10.1: PMU event table sanity                             : Ok
   10.2: PMU event map aliases                              : Ok
   10.3: Parsing of PMU event table metrics                 : Ok
   10.4: Parsing of PMU event table metrics with fake PMUs  : Ok
Quoted 3 lines

[1]: https://github.com/ARM-software/data

maintainer Applied
#4 lore raw

Em Thu, Nov 10, 2022 at 10:52:44AM +0000, Nick Forrington escreveu:

Quoted 17 lines · James Clark
Quoted 16 lines

Rename the neoverse-n2 folder to make it clear that it includes V2, and add V2 to mapfile.csv. V2 has the same events as N2, visible by running the following command in the ARM-software/data github repo [1]:

diff pmu/neoverse-v2.json pmu/neoverse-n2.json | grep code

Testing:

   $ perf test pmu
   10: PMU events                                           :
   10.1: PMU event table sanity                             : Ok
   10.2: PMU event map aliases                              : Ok
   10.3: Parsing of PMU event table metrics                 : Ok
   10.4: Parsing of PMU event table metrics with fake PMUs  : Ok
Quoted 4 lines
Quoted 3 lines

[1]: https://github.com/ARM-software/data

Thanks, applied.

- Arnaldo