Skip to contentSkip to conversation

arch: crash: Remove duplicate declaration in smp.h

PATCH In review [email protected] 2 participants 3 messages Oct 20, 2022 – Oct 24, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch: crash: Remove duplicate declaration in smp.h

From: Guo Ren <[email protected]>

Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which has been in include/linux/smp.h since 6f1f942cd5fb ("smp:
kernel/panic.c - silence warnings").

---

This patch is separated from the series [1] to let maintainer take easily. It still needs a Acked-by from x86 side, hope it could be soon done.

[1] https://lore.kernel.org/linux-riscv/[email protected]/

---
 arch/arm64/include/asm/smp.h | 1 -
 arch/x86/include/asm/crash.h | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/include/asm/smp.h +0 -1
index fc55f5a57a06..a108ac93fd8f 100644
@@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void)
  */
 bool cpus_are_stuck_in_kernel(void);
 
-extern void crash_smp_send_stop(void);
 extern bool smp_crash_stop_failed(void);
 extern void panic_smp_self_stop(void);
 
arch/x86/include/asm/crash.h +0 -1
index 8b6bd63530dc..6a9be4907c82 100644
@@ -7,6 +7,5 @@ struct kimage;
 int crash_load_segments(struct kimage *image);
 int crash_setup_memmap_entries(struct kimage *image,
 		struct boot_params *params);
-void crash_smp_send_stop(void);
 
 #endif /* _ASM_X86_CRASH_H */
Signature · 1 line
2.36.1
maintainer Acked-by on v1 1/1
#1 lore raw

arch/x86/include/asm/crash.h struct kimage; · line 11

Quoted 11 lines · On Thu, Oct 20, 2022 at 09:59:13AM -0400, [email protected] wrote:
arch/x86/include/asm/crash.h +0 -1
index 8b6bd63530dc..6a9be4907c82 100644
@@ -7,6 +7,5 @@ struct kimage;
 int crash_load_segments(struct kimage *image);
 int crash_setup_memmap_entries(struct kimage *image,
 		struct boot_params *params);
-void crash_smp_send_stop(void);
 
 #endif /* _ASM_X86_CRASH_H */
Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
author
#2 lore raw
Quoted 12 lines · Borislav Petkov
Quoted 10 lines · On Thu, Oct 20, 2022 at 09:59:13AM -0400, [email protected] wrote:
arch/x86/include/asm/crash.h +0 -1
index 8b6bd63530dc..6a9be4907c82 100644
@@ -7,6 +7,5 @@ struct kimage;
 int crash_load_segments(struct kimage *image);
 int crash_setup_memmap_entries(struct kimage *image,
              struct boot_params *params);
-void crash_smp_send_stop(void);
 
Quoted 3 lines

arch/x86/include/asm/crash.h struct kimage; · line 11

Quoted 1 line
arch/x86/include/asm/crash.h +0 -0
 #endif /* _ASM_X86_CRASH_H */

Thx.

Hi, Arnd

Because it crosses the architecture, could you take this in your next-tree?

Quoted 6 lines

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Signature · 7 lines
Best Regards
 Guo Ren

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv