Skip to contentSkip to conversation

gpiolib: cdev: Fix typo in kernel doc for struct line

PATCH In review Andy Shevchenko 2 participants 3 messages Oct 20, 2022 – Oct 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: cdev: Fix typo in kernel doc for struct line

When eflags has been renamed to the edflags, the kernel doc change were missed. Update kernel doc accordingly.

Fixes b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
---
 drivers/gpio/gpiolib-cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib-cdev.c +1 -1
index 0c84b011a64a..f9288e41e3a7 100644
@@ -412,7 +412,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
  * @desc: the GPIO descriptor for this line.
  * @req: the corresponding line request
  * @irq: the interrupt triggered in response to events on this GPIO
- * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
+ * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
  * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
  * @timestamp_ns: cache for the timestamp storing it between hardirq and
  * IRQ thread, used to bring the timestamp close to the actual event
Signature · 1 line
2.35.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Andy Shevchenko

When eflags has been renamed to the edflags, the kernel doc change were missed. Update kernel doc accordingly.

Fixes b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
Quoted 20 lines
---
 drivers/gpio/gpiolib-cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib-cdev.c +1 -1
index 0c84b011a64a..f9288e41e3a7 100644
@@ -412,7 +412,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
  * @desc: the GPIO descriptor for this line.
  * @req: the corresponding line request
  * @irq: the interrupt triggered in response to events on this GPIO
- * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
+ * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
  * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
  * @timestamp_ns: cache for the timestamp storing it between hardirq and
  * IRQ thread, used to bring the timestamp close to the actual event
Signature · 1 line
2.35.1
#2 lore raw
Quoted 8 lines · Kent Gibson
Quoted 5 lines · Andy Shevchenko

When eflags has been renamed to the edflags, the kernel doc change were missed. Update kernel doc accordingly.

Fixes b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")

Pushed to my review and testing queue, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko