drm/i915/tgl+: Fix race conditions during DKL PHY accesses
v2 cover drm/i915/tgl+: Fix race conditions during DKL PHY accesses
This is v2 of [1] addressing the review comments from Jani.
[1] https://lore.kernel.org/intel-gfx/Y1BaRfTAH%[email protected]/T/#t
Imre Deak (4):
drm/i915/tgl+: Add locking around DKL PHY register accesses drm/i915: Rename intel_tc_phy_regs.h to intel_mg_phy_regs.h drm/i915/tgl+: Move DKL PHY register definitions to
intel_dkl_phy_regs.h
drm/i915/tgl+: Sanitize DKL PHY register definitions
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_ddi.c | 71 +++---
.../gpu/drm/i915/display/intel_display_core.h | 4 +
.../i915/display/intel_display_power_well.c | 8 +-
drivers/gpu/drm/i915/display/intel_dkl_phy.c | 101 +++++++++
drivers/gpu/drm/i915/display/intel_dkl_phy.h | 20 ++
.../gpu/drm/i915/display/intel_dkl_phy_regs.h | 202 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 62 +++---
...ntel_tc_phy_regs.h => intel_mg_phy_regs.h} | 6 +-
drivers/gpu/drm/i915/display/intel_tc.c | 3 +-
drivers/gpu/drm/i915/i915_driver.c | 1 +
drivers/gpu/drm/i915/i915_reg.h | 176 ---------------
12 files changed, 397 insertions(+), 258 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.c
create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.h
create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h
rename drivers/gpu/drm/i915/display/{intel_tc_phy_regs.h => intel_mg_phy_regs.h} (99%)Signature · 1 line
2.37.1
PATCH v2 1/4 drm/i915/tgl+: Add locking around DKL PHY register accesses
Accessing the TypeC DKL PHY registers during modeset-commit, -verification, DP link-retraining and AUX power well toggling is racy due to these code paths being concurrent and the PHY register bank selection register (HIP_INDEX_REG) being shared between PHY instances (aka TC ports) and the bank selection being not atomic wrt. the actual PHY register access.
Add the required locking around each PHY register bank selection-> register access sequence.
Kudos to Ville for noticing the race conditions.
v2:
- Add the DKL PHY register accessors to intel_dkl_phy.[ch]. (Jani)
- Make the DKL_REG_TC_PORT macro independent of PHY internals.
- Move initing the DKL PHY lock to a more logical place.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 68 +++++------- .../gpu/drm/i915/display/intel_display_core.h | 4 + .../i915/display/intel_display_power_well.c | 7 +- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 104 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dkl_phy.h | 20 ++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 59 +++++----- drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 3 + 9 files changed, 191 insertions(+), 76 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.c create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -285,6 +285,7 @@ i915-y += \ display/intel_ddi.o \ display/intel_ddi_buf_trans.o \ display/intel_display_trace.o \ + display/intel_dkl_phy.o \ display/intel_dp.o \ display/intel_dp_aux.o \ display/intel_dp_aux_backlight.o \
drivers/gpu/drm/i915/display/intel_ddi.c +28 -40
111 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_core.h +4 -0
@@ -315,6 +315,10 @@ struct intel_display {struct intel_global_obj obj; } dbuf; +struct { +spinlock_t phy_lock; + } dkl; +struct {/* VLV/CHV/BXT/GLK DSI MMIO register base address */ u32 mmio_base;
drivers/gpu/drm/i915/display/intel_display_power_well.c +3 -4
@@ -12,6 +12,7 @@#include "intel_de.h" #include "intel_display_power_well.h" #include "intel_display_types.h" +#include "intel_dkl_phy.h" #include "intel_dmc.h" #include "intel_dpio_phy.h" #include "intel_dpll.h"
@@ -529,11 +530,9 @@ icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,enum tc_port tc_port; tc_port =TGL_AUX_PW_TO_TC_PORT (i915_power_well_instance (power_well)->hsw.idx); -intel_de_write (dev_priv,HIP_INDEX_REG (tc_port), -HIP_INDEX_VAL (tc_port,0x2 )); -if (intel_de_wait_for_set (dev_priv,DKL_CMN_UC_DW_27 (tc_port), -DKL_CMN_UC_DW27_UC_HEALTH ,1 )) +if (wait_for (intel_dkl_phy_read (dev_priv,DKL_CMN_UC_DW_27 (tc_port),2 ) & +DKL_CMN_UC_DW27_UC_HEALTH ,1 ))drm_warn (&dev_priv->drm,"Timeout waiting TC uC health\n" ); }
drivers/gpu/drm/i915/display/intel_dkl_phy.c new file +104 -0
104 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dkl_phy.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_DKL_PHY_H__ +#define __INTEL_DKL_PHY_H__ + +#include <linux/types.h> + +#include "i915_reg_defs.h" + +struct drm_i915_private ; + +u32 intel_dkl_phy_read (struct drm_i915_private *i915,i915_reg_t reg,int ln); +void intel_dkl_phy_write (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 val); +void intel_dkl_phy_rmw (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 clear,u32 set); +void intel_dkl_phy_posting_read (struct drm_i915_private *i915,i915_reg_t reg,int ln); + +#endif /* __INTEL_DKL_PHY_H__ */
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +27 -32
141 lines not on this page · raw message
drivers/gpu/drm/i915/i915_driver.c +1 -0
@@ -355,6 +355,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)mutex_init (&dev_priv->display.wm.wm_mutex);mutex_init (&dev_priv->display.pps.mutex);mutex_init (&dev_priv->display.hdcp.comp_mutex); +spin_lock_init (&dev_priv->display.dkl.phy_lock);i915_memcpy_init_early (dev_priv);intel_runtime_pm_init_early (&dev_priv->runtime_pm);
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -7442,6 +7442,9 @@ enum skl_power_gate {#define _DKL_PHY5_BASE 0x16C000#define _DKL_PHY6_BASE 0x16D000 +#define DKL_REG_TC_PORT (reg) \ + (((reg).reg - _DKL_PHY1_BASE) / (_DKL_PHY2_BASE - _DKL_PHY1_BASE)) +/* DEKEL PHY MMIO Address = Phy base + (internal address & ~index_mask) */ #define _DKL_PCS_DW5 0x14#define DKL_PCS_DW5 (tc_port) _MMIO(_PORT(tc_port, _DKL_PHY1_BASE, \
Signature · 1 line
2.37.1
PATCH v2 2/4 drm/i915: Rename intel_tc_phy_regs.h to intel_mg_phy_regs.h
In reply to Imre DeakAn upcoming patch moves the DKL PHY register definitions to intel_dkl_phy_regs.h, so for consistency rename intel_tc_phy_regs.h containing only MG PHY register definitions to intel_mg_phy_regs.h.
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
.../display/{intel_tc_phy_regs.h => intel_mg_phy_regs.h} | 6 +++---
drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
rename drivers/gpu/drm/i915/display/{intel_tc_phy_regs.h => intel_mg_phy_regs.h} (99%)drivers/gpu/drm/i915/display/intel_ddi.c +1 -1
@@ -56,13 +56,13 @@#include "intel_hdmi.h" #include "intel_hotplug.h" #include "intel_lspcon.h" +#include "intel_mg_phy_regs.h" #include "intel_pps.h" #include "intel_psr.h" #include "intel_quirks.h" #include "intel_snps_phy.h" #include "intel_sprite.h" #include "intel_tc.h" -#include "intel_tc_phy_regs.h" #include "intel_vdsc.h" #include "intel_vrr.h" #include "skl_scaler.h"
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +1 -1
@@ -29,9 +29,9 @@#include "intel_dpio_phy.h" #include "intel_dpll.h" #include "intel_dpll_mgr.h" +#include "intel_mg_phy_regs.h" #include "intel_pch_refclk.h" #include "intel_tc.h" -#include "intel_tc_phy_regs.h" /** * DOC: Display PLLs
drivers/gpu/drm/i915/display/intel_mg_phy_regs.h renamed from drivers/gpu/drm/i915/display/intel_tc_phy_regs.h +3 -3
@@ -3,8 +3,8 @@* Copyright © 2022 Intel Corporation */ -#ifndef __INTEL_TC_PHY_REGS__ -#define __INTEL_TC_PHY_REGS__ +#ifndef __INTEL_MG_PHY_REGS__ +#define __INTEL_MG_PHY_REGS__#include "i915_reg_defs.h"
@@ -277,4 +277,4 @@ _MG_PLL_TDC_COLDST_BIAS_PORT1, \ _MG_PLL_TDC_COLDST_BIAS_PORT2) -#endif /* __INTEL_TC_PHY_REGS__ */ +#endif /* __INTEL_MG_PHY_REGS__ */
drivers/gpu/drm/i915/display/intel_tc.c +1 -1
@@ -9,8 +9,8 @@#include "intel_display_power_map.h" #include "intel_display_types.h" #include "intel_dp_mst.h" +#include "intel_mg_phy_regs.h" #include "intel_tc.h" -#include "intel_tc_phy_regs.h" static const char *tc_port_mode_name (enum tc_port_mode mode) {
Signature · 1 line
2.37.1
PATCH v2 3/4 drm/i915/tgl+: Move DKL PHY register definitions to intel_dkl_phy_regs.h
In reply to Imre DeakMove the TypeC DKL PHY register definitions to intel_dkl_phy_regs.h.
No functional changes.
v2:
- Move the definitions to a new intel_dkl_phy_regs.h file. (Jani).
--- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + .../i915/display/intel_display_power_well.c | 1 + drivers/gpu/drm/i915/display/intel_dkl_phy.c | 1 + .../gpu/drm/i915/display/intel_dkl_phy_regs.h | 193 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_tc.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 179 ---------------- 7 files changed, 198 insertions(+), 179 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h
drivers/gpu/drm/i915/display/intel_ddi.c +1 -0
@@ -44,6 +44,7 @@#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dkl_phy.h" +#include "intel_dkl_phy_regs.h" #include "intel_dp.h" #include "intel_dp_link_training.h" #include "intel_dp_mst.h"
drivers/gpu/drm/i915/display/intel_display_power_well.c +1 -0
@@ -13,6 +13,7 @@#include "intel_display_power_well.h" #include "intel_display_types.h" #include "intel_dkl_phy.h" +#include "intel_dkl_phy_regs.h" #include "intel_dmc.h" #include "intel_dpio_phy.h" #include "intel_dpll.h"
drivers/gpu/drm/i915/display/intel_dkl_phy.c +1 -0
@@ -9,6 +9,7 @@#include "intel_de.h" #include "intel_display.h" #include "intel_dkl_phy.h" +#include "intel_dkl_phy_regs.h" static void dkl_phy_set_hip_idx (struct drm_i915_private *i915,i915_reg_t reg,int idx) {
drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h new file +193 -0
193 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +1 -0
@@ -26,6 +26,7 @@#include "intel_de.h" #include "intel_display_types.h" #include "intel_dkl_phy.h" +#include "intel_dkl_phy_regs.h" #include "intel_dpio_phy.h" #include "intel_dpll.h" #include "intel_dpll_mgr.h"
drivers/gpu/drm/i915/display/intel_tc.c +1 -0
@@ -8,6 +8,7 @@#include "intel_display.h" #include "intel_display_power_map.h" #include "intel_display_types.h" +#include "intel_dkl_phy_regs.h" #include "intel_dp_mst.h" #include "intel_mg_phy_regs.h" #include "intel_tc.h"
drivers/gpu/drm/i915/i915_reg.h +0 -179
185 lines not on this page · raw message
Signature · 1 line
2.37.1
PATCH v2 4/4 drm/i915/tgl+: Sanitize DKL PHY register definitions
In reply to Imre DeakNot all Dekel PHY registers have a lane instance, so having to specify this when using them is awkward. It makes more sense to define each PHY register with its full internal PHY offset where bits 15:12 is the lane for lane-instanced PHY registers and just a register bank index for other PHY registers. This way lane-instanced registers can be referred to with the (tc_port, lane) parameters, while other registers just with a tc_port parameter.
An additional benefit of this change is to prevent passing a Dekel register to a generic MMIO access function or vice versa.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 20 +- .../i915/display/intel_display_power_well.c | 2 +- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 32 ++- drivers/gpu/drm/i915/display/intel_dkl_phy.h | 10 +- .../gpu/drm/i915/display/intel_dkl_phy_regs.h | 189 +++++++++--------- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 50 ++--- 6 files changed, 154 insertions(+), 149 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +10 -10
@@ -1264,11 +1264,11 @@ static void tgl_dkl_phy_set_signal_levels(struct intel_encoder *encoder,for (ln =0 ; ln <2 ; ln++) {int level; -intel_dkl_phy_write (dev_priv,DKL_TX_PMD_LANE_SUS (tc_port), ln,0 ); +intel_dkl_phy_write (dev_priv,DKL_TX_PMD_LANE_SUS (tc_port, ln),0 ); level =intel_ddi_level (encoder, crtc_state,2 *ln+0 ); - intel_dkl_phy_rmw(dev_priv, DKL_TX_DPCNTL0(tc_port), ln, + intel_dkl_phy_rmw(dev_priv, DKL_TX_DPCNTL0(tc_port, ln), DKL_TX_PRESHOOT_COEFF_MASK | DKL_TX_DE_EMPAHSIS_COEFF_MASK | DKL_TX_VSWING_CONTROL_MASK,
@@ -1278,7 +1278,7 @@ static void tgl_dkl_phy_set_signal_levels(struct intel_encoder *encoder, level =intel_ddi_level (encoder, crtc_state,2 *ln+1 ); - intel_dkl_phy_rmw(dev_priv, DKL_TX_DPCNTL1(tc_port), ln, + intel_dkl_phy_rmw(dev_priv, DKL_TX_DPCNTL1(tc_port, ln), DKL_TX_PRESHOOT_COEFF_MASK | DKL_TX_DE_EMPAHSIS_COEFF_MASK | DKL_TX_VSWING_CONTROL_MASK,
@@ -1286,7 +1286,7 @@ static void tgl_dkl_phy_set_signal_levels(struct intel_encoder *encoder,DKL_TX_DE_EMPHASIS_COEFF (trans->entries[level].dkl.de_emphasis) | DKL_TX_VSWING_CONTROL(trans->entries[level].dkl.vswing)); -intel_dkl_phy_rmw (dev_priv,DKL_TX_DPCNTL2 (tc_port), ln, +intel_dkl_phy_rmw (dev_priv,DKL_TX_DPCNTL2 (tc_port, ln),DKL_TX_DP20BITMODE ,0 );if (IS_ALDERLAKE_P (dev_priv)) {
@@ -1305,7 +1305,7 @@ static void tgl_dkl_phy_set_signal_levels(struct intel_encoder *encoder, val |=DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (0 ); } -intel_dkl_phy_rmw (dev_priv,DKL_TX_DPCNTL2 (tc_port), ln, +intel_dkl_phy_rmw (dev_priv,DKL_TX_DPCNTL2 (tc_port, ln),DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK |DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK , val);
@@ -2018,8 +2018,8 @@ icl_program_mg_dp_mode(struct intel_digital_port *dig_port,return ;if (DISPLAY_VER (dev_priv) >=12 ) { - ln0 =intel_dkl_phy_read (dev_priv,DKL_DP_MODE (tc_port),0 ); - ln1 =intel_dkl_phy_read (dev_priv,DKL_DP_MODE (tc_port),1 ); + ln0 =intel_dkl_phy_read (dev_priv,DKL_DP_MODE (tc_port,0 )); + ln1 =intel_dkl_phy_read (dev_priv,DKL_DP_MODE (tc_port,1 )); }else { ln0 =intel_de_read (dev_priv,MG_DP_MODE (0 , tc_port)); ln1 =intel_de_read (dev_priv,MG_DP_MODE (1 , tc_port));
@@ -2080,8 +2080,8 @@ icl_program_mg_dp_mode(struct intel_digital_port *dig_port, }if (DISPLAY_VER (dev_priv) >=12 ) { -intel_dkl_phy_write (dev_priv,DKL_DP_MODE (tc_port),0 , ln0); -intel_dkl_phy_write (dev_priv,DKL_DP_MODE (tc_port),1 , ln1); +intel_dkl_phy_write (dev_priv,DKL_DP_MODE (tc_port,0 ), ln0); +intel_dkl_phy_write (dev_priv,DKL_DP_MODE (tc_port,1 ), ln1); }else {intel_de_write (dev_priv,MG_DP_MODE (0 , tc_port), ln0);intel_de_write (dev_priv,MG_DP_MODE (1 , tc_port), ln1);
@@ -3086,7 +3086,7 @@ static void adlp_tbt_to_dp_alt_switch_wa(struct intel_encoder *encoder)int ln;for (ln =0 ; ln <2 ; ln++) -intel_dkl_phy_rmw (i915,DKL_PCS_DW5 (tc_port), ln,DKL_PCS_DW5_CORE_SOFTRESET ,0 ); +intel_dkl_phy_rmw (i915,DKL_PCS_DW5 (tc_port, ln),DKL_PCS_DW5_CORE_SOFTRESET ,0 ); } static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
drivers/gpu/drm/i915/display/intel_display_power_well.c +1 -1
@@ -532,7 +532,7 @@ icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv, tc_port =TGL_AUX_PW_TO_TC_PORT (i915_power_well_instance (power_well)->hsw.idx); -if (wait_for (intel_dkl_phy_read (dev_priv,DKL_CMN_UC_DW_27 (tc_port),2 ) & +if (wait_for (intel_dkl_phy_read (dev_priv,DKL_CMN_UC_DW_27 (tc_port)) &DKL_CMN_UC_DW27_UC_HEALTH ,1 ))drm_warn (&dev_priv->drm,"Timeout waiting TC uC health\n" );
drivers/gpu/drm/i915/display/intel_dkl_phy.c +14 -18
@@ -11,7 +11,7 @@#include "intel_dkl_phy.h" #include "intel_dkl_phy_regs.h" -static void dkl_phy_set_hip_idx (struct drm_i915_private *i915,i915_reg_t reg,int idx) +static void dkl_phy_set_hip_idx (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg) {enum tc_port tc_port =DKL_REG_TC_PORT (reg);
@@ -19,27 +19,26 @@ static void dkl_phy_set_hip_idx(struct drm_i915_private *i915, i915_reg_t reg, iintel_de_write (i915,HIP_INDEX_REG (tc_port), -HIP_INDEX_VAL (tc_port, idx)); +HIP_INDEX_VAL (tc_port, reg.bank_idx)); }/** * intel_dkl_phy_read - read a Dekel PHY register * @i915: i915 device instance * @reg: Dekel PHY register -* @ln: lane instance of @reg * * Read the @reg Dekel PHY register. * * Returns the read value. */ -u32 intel_dkl_phy_read (struct drm_i915_private *i915,i915_reg_t reg,int ln) +u32 intel_dkl_phy_read (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg) {u32 val;spin_lock (&i915->display.dkl.phy_lock); -dkl_phy_set_hip_idx (i915, reg, ln); - val =intel_de_read (i915, reg); +dkl_phy_set_hip_idx (i915, reg); + val =intel_de_read (i915,DKL_REG_MMIO (reg));spin_unlock (&i915->display.dkl.phy_lock);
@@ -50,17 +49,16 @@ u32 intel_dkl_phy_read(struct drm_i915_private *i915, i915_reg_t reg, int ln)* intel_dkl_phy_write - write a Dekel PHY register * @i915: i915 device instance * @reg: Dekel PHY register -* @ln: lane instance of @reg * @val: value to write * * Write @val to the @reg Dekel PHY register. */ -void intel_dkl_phy_write (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 val) +void intel_dkl_phy_write (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg,u32 val) {spin_lock (&i915->display.dkl.phy_lock); -dkl_phy_set_hip_idx (i915, reg, ln); -intel_de_write (i915, reg, val); +dkl_phy_set_hip_idx (i915, reg); +intel_de_write (i915,DKL_REG_MMIO (reg), val);spin_unlock (&i915->display.dkl.phy_lock); }
@@ -69,19 +67,18 @@ void intel_dkl_phy_write(struct drm_i915_private *i915, i915_reg_t reg, int ln,* intel_dkl_phy_rmw - read-modify-write a Dekel PHY register * @i915: i915 device instance * @reg: Dekel PHY register -* @ln: lane instance of @reg * @clear: mask to clear * @set: mask to set * * Read the @reg Dekel PHY register, clearing then setting the @clear/@set bits in it, and writing * this value back to the register if the value differs from the read one. */ -void intel_dkl_phy_rmw (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 clear,u32 set) +void intel_dkl_phy_rmw (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg,u32 clear,u32 set) {spin_lock (&i915->display.dkl.phy_lock); -dkl_phy_set_hip_idx (i915, reg, ln); -intel_de_rmw (i915, reg, clear, set); +dkl_phy_set_hip_idx (i915, reg); +intel_de_rmw (i915,DKL_REG_MMIO (reg), clear, set);spin_unlock (&i915->display.dkl.phy_lock); }
@@ -90,16 +87,15 @@ void intel_dkl_phy_rmw(struct drm_i915_private *i915, i915_reg_t reg, int ln, u3* intel_dkl_phy_posting_read - do a posting read from a Dekel PHY register * @i915: i915 device instance * @reg: Dekel PHY register -* @ln: lane instance of @reg * * Read the @reg Dekel PHY register without returning the read value. */ -void intel_dkl_phy_posting_read (struct drm_i915_private *i915,i915_reg_t reg,int ln) +void intel_dkl_phy_posting_read (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg) {spin_lock (&i915->display.dkl.phy_lock); -dkl_phy_set_hip_idx (i915, reg, ln); -intel_de_posting_read (i915, reg); +dkl_phy_set_hip_idx (i915, reg); +intel_de_posting_read (i915,DKL_REG_MMIO (reg));spin_unlock (&i915->display.dkl.phy_lock); }
drivers/gpu/drm/i915/display/intel_dkl_phy.h +5 -5
@@ -8,13 +8,13 @@#include <linux/types.h> -#include "i915_reg_defs.h" +#include "intel_dkl_phy_regs.h" struct drm_i915_private ; -u32 intel_dkl_phy_read (struct drm_i915_private *i915,i915_reg_t reg,int ln); -void intel_dkl_phy_write (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 val); -void intel_dkl_phy_rmw (struct drm_i915_private *i915,i915_reg_t reg,int ln,u32 clear,u32 set); -void intel_dkl_phy_posting_read (struct drm_i915_private *i915,i915_reg_t reg,int ln); +u32 intel_dkl_phy_read (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg); +void intel_dkl_phy_write (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg,u32 val); +void intel_dkl_phy_rmw (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg,u32 clear,u32 set); +void intel_dkl_phy_posting_read (struct drm_i915_private *i915,struct intel_dkl_phy_reg reg);#endif /* __INTEL_DKL_PHY_H__ */
drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h +99 -90
256 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +25 -25
125 lines not on this page · raw message
Signature · 1 line
2.37.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl+: Fix race conditions during DKL PHY accesses
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses
URL : https://patchwork.freedesktop.org/series/109963/
State : warning
== Summary ==
Error: dim checkpatch failed9bbcf8b185e4 drm/i915/tgl+: Add locking around DKL PHY register accesses Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:173: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #173: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:319:
+ spinlock_t phy_lock;
-:206: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #206:
new file mode 100644
-:449: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #449: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3739:
+ intel_dkl_phy_rmw(dev_priv, DKL_PLL_DIV0(tc_port), 2, val,
+ hw_state->mg_pll_div0);
-:510: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #510: FILE: drivers/gpu/drm/i915/i915_reg.h:7445:
+#define DKL_REG_TC_PORT(reg) \
+ (((reg).reg - _DKL_PHY1_BASE) / (_DKL_PHY2_BASE - _DKL_PHY1_BASE))
total: 0 errors, 1 warnings, 3 checks, 429 lines checked796c17a52706 drm/i915: Rename intel_tc_phy_regs.h to intel_mg_phy_regs.h
-:50: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #50:
rename from drivers/gpu/drm/i915/display/intel_tc_phy_regs.h
total: 0 errors, 1 warnings, 0 checks, 48 lines checked060db4c81b85 drm/i915/tgl+: Move DKL PHY register definitions to intel_dkl_phy_regs.h Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:54: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #54:
new file mode 100644
-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #74: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:16:
+#define DKL_REG_TC_PORT(reg) \
+ (((reg).reg - _DKL_PHY1_BASE) / (_DKL_PHY2_BASE - _DKL_PHY1_BASE))
-:91: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #91: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:33:
+#define DKL_PLL_DIV0_AFC_STARTUP(val) REG_FIELD_PREP(DKL_PLL_DIV0_AFC_STARTUP_MASK, (val))
-:196: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #196: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:138:
+#define DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1(val) REG_FIELD_PREP(DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK, (val))
-:198: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #198: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:140:
+#define DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2(val) REG_FIELD_PREP(DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK, (val))
total: 0 errors, 4 warnings, 1 checks, 413 lines checkedaa5a4c2beb11 drm/i915/tgl+: Sanitize DKL PHY register definitions
-:186: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#186: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy.c:76:
+void intel_dkl_phy_rmw(struct drm_i915_private *i915, struct intel_dkl_phy_reg reg, u32 clear, u32 set)
-:236: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#236: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy.h:17:
+void intel_dkl_phy_rmw(struct drm_i915_private *i915, struct intel_dkl_phy_reg reg, u32 clear, u32 set);
-:267: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #267: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:27:
+#define DKL_REG_MMIO(reg) _MMIO(reg.reg)
-:274: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #274: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:34:
+#define _DKL_REG_BANK_OFFSET(phy_offset) ((phy_offset) & ((1 << _DKL_BANK_SHIFT) - 1))
-:277: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phy_offset' - possible side-effects? #277: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:37:
+#define _DKL_REG(tc_port, phy_offset) \
+ ((const struct intel_dkl_phy_reg) { \
+ .reg = _DKL_REG_PHY_BASE(tc_port) + \
+ _DKL_REG_BANK_OFFSET(phy_offset), \
+ .bank_idx = _DKL_REG_BANK_IDX(phy_offset), \
+ })
-:284: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ln0_offs' - possible side-effects? #284: FILE: drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h:44:
+#define _DKL_REG_LN(tc_port, ln_idx, ln0_offs, ln1_offs) \
+ _DKL_REG(tc_port, (ln0_offs) + (ln_idx) * ((ln1_offs) - (ln0_offs)))
total: 0 errors, 3 warnings, 3 checks, 576 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tgl+: Fix race conditions during DKL PHY accesses
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses
URL : https://patchwork.freedesktop.org/series/109963/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl+: Fix race conditions during DKL PHY accesses
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses
URL : https://patchwork.freedesktop.org/series/109963/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12267 -> Patchwork_109963v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/index.html
Participating hosts (46 -> 44)
------------------------------
Additional (1): bat-atsm-1
Missing (3): fi-ctg-p8600 fi-bdw-samus fi-hsw-4200u
Known issues
------------
Here are the changes found in Patchwork_109963v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-icl-u2/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-glk-j4005: [PASS][2] -> [DMESG-FAIL][3] ([i915#7270])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-glk-j4005/igt@i915_selftest@live@gem_contexts.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-glk-j4005/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@mman:
- fi-icl-u2: NOTRUN -> [DMESG-FAIL][4] ([i915#4890])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-icl-u2/igt@i915_selftest@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([fdo#109295] / [i915#3301])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][6] ([i915#2867]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]
* igt@i915_pm_rpm@basic-rte:
- fi-icl-u2: [DMESG-WARN][8] ([i915#4890]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-icl-u2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-icl-u2/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-kbl-7567u: [DMESG-FAIL][10] ([i915#7270]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
- {bat-jsl-1}: [DMESG-FAIL][12] ([i915#7270]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][14] ([i915#4983]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-rpls-2/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/bat-rpls-2/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270
Build changes
-------------
* Linux: CI_DRM_12267 -> Patchwork_109963v1
CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109963v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
b5c7083e1005 drm/i915/tgl+: Sanitize DKL PHY register definitions fa1a9b4c92eb drm/i915/tgl+: Move DKL PHY register definitions to intel_dkl_phy_regs.h 743cdf4aaba1 drm/i915: Rename intel_tc_phy_regs.h to intel_mg_phy_regs.h 6344e4914b59 drm/i915/tgl+: Add locking around DKL PHY register accesses
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl+: Fix race conditions during DKL PHY accesses
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses
URL : https://patchwork.freedesktop.org/series/109963/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12267_full -> Patchwork_109963v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109963v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_109963v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109963v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb8/igt@i915_pm_rpm@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb3/igt@i915_pm_rpm@[email protected]
Known issues
------------
Here are the changes found in Patchwork_109963v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26]) -> ([PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) ([i915#5032])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl4/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl4/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl10/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl9/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl10/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl10/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl10/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][51] -> [FAIL][52] ([i915#6268])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb6/igt@[email protected]
* igt@gem_ctx_persistence@hang:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271]) +54 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@gem_eio@in-flight-contexts-immediate:
- shard-apl: [PASS][54] -> [TIMEOUT][55] ([i915#3063])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl3/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl3/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][56] -> [SKIP][57] ([i915#4525])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][58] ([i915#2846])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#2842]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk1/igt@gem_exec_fair@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][61] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][62] -> [SKIP][63] ([i915#2190])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb8/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl8/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][66] -> [FAIL][67] ([i915#4171])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb1/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb3/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][68] ([i915#4991])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#3297])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb7/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][70] -> [DMESG-WARN][71] ([i915#180]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [PASS][72] -> [WARN][73] ([i915#1804])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@i915_pm_rc6_residency@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][74] -> [DMESG-FAIL][75] ([i915#5334])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@i915_selftest@live@gt_heartbeat.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [PASS][76] -> [DMESG-FAIL][77] ([i915#5334])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#5286])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglb: [PASS][79] -> [FAIL][80] ([i915#3743])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl9/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl7/igt@[email protected]
* igt@kms_color_chamelium@ctm-max:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][85] ([i915#1319] / [i915#7121] / [i915#7173])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl8/igt@kms_content_protection@[email protected]
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271]) +77 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl7/igt@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109274] / [fdo#111825] / [i915#3637])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][88] -> [FAIL][89] ([i915#2122]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][90] -> [FAIL][91] ([i915#79])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk9/igt@kms_flip@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][92] -> [FAIL][93] ([i915#79]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-skl: [PASS][94] -> [INCOMPLETE][95] ([i915#4939])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl6/igt@kms_flip@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-skl: [PASS][96] -> [INCOMPLETE][97] ([i915#4839])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl4/igt@kms_flip@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2587] / [i915#2672]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][99] ([i915#2672]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][100] ([i915#3555])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#6497])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][102] -> [SKIP][103] ([i915#5235]) +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@kms_plane_scaling@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#658]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl7/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][106] -> [SKIP][107] ([fdo#109441])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-skl: [PASS][108] -> [FAIL][109] ([i915#43])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2437])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl1/igt@[email protected]
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl8/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2994])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][113] ([i915#4525]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][115] ([i915#2842]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb8/igt@gem_exec_fair@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][117] ([i915#2842]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@gem_exec_fair@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][119] ([i915#2842]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@gem_exec_fair@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-gtt-active:
- {shard-rkl}: [SKIP][121] ([i915#3281]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-5/igt@[email protected]
* igt@gem_pread@uncached:
- {shard-rkl}: [SKIP][123] ([i915#3282]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-start-cmd:
- {shard-rkl}: [SKIP][125] ([i915#2527]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-5/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- {shard-rkl}: [FAIL][127] ([fdo#103375]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@linear-max-hw-stride-64bpp-rotate-180:
- {shard-rkl}: [SKIP][129] ([i915#1845] / [i915#4098]) -> [PASS][130] +4 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@cursor-sliding-256x256@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-WARN][131] ([i915#118]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk8/igt@kms_cursor_crc@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk5/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1:
- shard-tglb: [INCOMPLETE][133] -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb1/igt@kms_cursor_crc@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb7/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor@atomic-transitions-varying-size:
- shard-skl: [FAIL][135] ([i915#3927]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/igt@kms_cursor_legacy@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl9/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][137] ([i915#79]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][139] ([i915#79]) -> [PASS][140] +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk2/igt@kms_flip@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- {shard-rkl}: [SKIP][141] ([i915#1849] / [i915#4098]) -> [PASS][142] +2 similar issues
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][143] ([i915#180]) -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl3/igt@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- {shard-rkl}: [SKIP][145] ([i915#433]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-4/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-2/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- {shard-rkl}: [SKIP][147] ([i915#1849] / [i915#3558]) -> [PASS][148] +1 similar issue
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_plane@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_lowres@tiling-yf@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][149] -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@kms_plane_lowres@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk9/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][151] ([i915#5235]) -> [PASS][152] +2 similar issues
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_properties@crtc-properties-legacy:
- {shard-rkl}: [SKIP][153] ([i915#1849]) -> [PASS][154] +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr@cursor_blt:
- {shard-rkl}: [SKIP][155] ([i915#1072]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_psr@cursor_blt.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-6/igt@kms_psr@cursor_blt.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][157] ([fdo#109441]) -> [PASS][158] +1 similar issue
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][159] ([i915#5639]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb3/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-tglb2/igt@[email protected]
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][161] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-rkl-5/igt@[email protected]
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][163] ([i915#6117]) -> [SKIP][164] ([i915#4525])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb7/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-apl: [WARN][165] ([i915#2658]) -> [INCOMPLETE][166] ([i915#7268])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-apl8/igt@[email protected]
- shard-glk: [INCOMPLETE][167] -> [WARN][168] ([i915#2658])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk9/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk3/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: [INCOMPLETE][169] -> [INCOMPLETE][170] ([i915#7296])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk3/igt@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-glk6/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][171] ([i915#588]) -> [SKIP][172] ([i915#658])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][173] ([i915#658]) -> [SKIP][174] ([i915#2920])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][175] ([i915#2920]) -> [SKIP][176] ([fdo#111068] / [i915#658]) +2 similar issues
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb7/igt@[email protected]
* igt@runner@aborted:
- shard-iclb: ([FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181], [FAIL][182], [FAIL][183]) ([i915#3002] / [i915#4312] / [i915#7300]) -> ([FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187], [FAIL][188], [FAIL][189], [FAIL][190]) ([i915#3002] / [i915#4312])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb7/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb1/igt@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb6/igt@[email protected]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb4/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@[email protected]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb4/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb2/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/shard-iclb8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3927]: https://gitlab.freedesktop.org/drm/intel/issues/3927
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7268]: https://gitlab.freedesktop.org/drm/intel/issues/7268
[i915#7296]: https://gitlab.freedesktop.org/drm/intel/issues/7296
[i915#7300]: https://gitlab.freedesktop.org/drm/intel/issues/7300
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12267 -> Patchwork_109963v1
CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109963v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109963v1/index.html
Quoted 1 line · Imre Deak
This is v2 of [1] addressing the review comments from Jani.
Did not do detailed review,
Quoted 30 lines
[1] https://lore.kernel.org/intel-gfx/Y1BaRfTAH%[email protected]/T/#t
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Imre Deak (4):
drm/i915/tgl+: Add locking around DKL PHY register accesses drm/i915: Renameintel_tc_phy_regs.htointel_mg_phy_regs.hdrm/i915/tgl+: Move DKL PHY register definitions to
intel_dkl_phy_regs.h
drm/i915/tgl+: Sanitize DKL PHY register definitionsdrivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 71 +++--- .../gpu/drm/i915/display/intel_display_core.h | 4 + .../i915/display/intel_display_power_well.c | 8 +- drivers/gpu/drm/i915/display/intel_dkl_phy.c | 101 +++++++++ drivers/gpu/drm/i915/display/intel_dkl_phy.h | 20 ++ .../gpu/drm/i915/display/intel_dkl_phy_regs.h | 202 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 62 +++--- ...ntel_tc_phy_regs.h => intel_mg_phy_regs.h} | 6 +- drivers/gpu/drm/i915/display/intel_tc.c | 3 +- drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 176 --------------- 12 files changed, 397 insertions(+), 258 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.c create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy.h create mode 100644 drivers/gpu/drm/i915/display/intel_dkl_phy_regs.h rename drivers/gpu/drm/i915/display/{intel_tc_phy_regs.h => intel_mg_phy_regs.h} (99%)
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center