drm: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap
Subsystems (2)
PATCH 1/1 drm: Switch drm_client_buffer_delete() to unlocked drm_gem_vunmap
The drm_client_buffer_delete() wasn't switched to unlocked GEM vunmapping by accident when rest of drm_client code transitioned to the unlocked variants of the vmapping functions. Make drm_client_buffer_delete() use the unlocked variant. This fixes lockdep warning splat about missing reservation lock when framebuffer is released.
--- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_client.c +1 -1
@@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) {struct drm_device *dev = buffer->client->dev; -drm_gem_vunmap (buffer->gem, &buffer->map); +drm_gem_vunmap_unlocked (buffer->gem, &buffer->map);if (buffer->gem)drm_gem_object_put (buffer->gem);
Signature · 1 line
2.37.3
Hello,
Quoted 19 lines · Dmitry Osipenko
The
drm_client_buffer_delete()wasn't switched to unlocked GEM vunmapping by accident when rest ofdrm_clientcode transitioned to the unlocked variants of the vmapping functions. Makedrm_client_buffer_delete()use the unlocked variant. This fixes lockdep warning splat about missing reservation lock when framebuffer is released.Reported-by kernel test robot <[email protected]>Fixes 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_client.c +0
-0
drivers/gpu/drm/drm_client.c static void drm_client_buffer_delete(struct drm_client_buffer *buffer) · line 241
Quoted 8 lines
drivers/gpu/drm/drm_client.c +1
-1@@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) {struct drm_device *dev = buffer->client->dev; -drm_gem_vunmap (buffer->gem, &buffer->map); +drm_gem_vunmap_unlocked (buffer->gem, &buffer->map);if (buffer->gem)drm_gem_object_put (buffer->gem);
Christian, could you please give yours r-b? The dim insists that the patch should have r-b or it won't let me push to misc-next. Thanks in advance!
Signature · 2 lines
Best regards, Dmitry
Am 20.10.22 um 23:33 schrieb Dmitry Osipenko:
Quoted 10 lines
The
drm_client_buffer_delete()wasn't switched to unlocked GEM vunmapping by accident when rest ofdrm_clientcode transitioned to the unlocked variants of the vmapping functions. Makedrm_client_buffer_delete()use the unlocked variant. This fixes lockdep warning splat about missing reservation lock when framebuffer is released.Reported-by kernel test robot <[email protected]>Fixes 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")Signed-off-by Dmitry Osipenko <[email protected]>
The code was properly added recently between review and pushing. Let's get that upstream ASAP.
Quoted 17 lines
--- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_client.c +1
-1@@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) {struct drm_device *dev = buffer->client->dev; -drm_gem_vunmap (buffer->gem, &buffer->map); +drm_gem_vunmap_unlocked (buffer->gem, &buffer->map);if (buffer->gem)drm_gem_object_put (buffer->gem);
Dmitry Osipenko
AppliedQuoted 19 lines · Dmitry Osipenko
The
drm_client_buffer_delete()wasn't switched to unlocked GEM vunmapping by accident when rest ofdrm_clientcode transitioned to the unlocked variants of the vmapping functions. Makedrm_client_buffer_delete()use the unlocked variant. This fixes lockdep warning splat about missing reservation lock when framebuffer is released.Reported-by kernel test robot <[email protected]>Fixes 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_client.c +0
-0
drivers/gpu/drm/drm_client.c static void drm_client_buffer_delete(struct drm_client_buffer *buffer) · line 241
Quoted 8 lines
drivers/gpu/drm/drm_client.c +1
-1@@ -235,7 +235,7 @@ static void drm_client_buffer_delete(struct drm_client_buffer *buffer) {struct drm_device *dev = buffer->client->dev; -drm_gem_vunmap (buffer->gem, &buffer->map); +drm_gem_vunmap_unlocked (buffer->gem, &buffer->map);if (buffer->gem)drm_gem_object_put (buffer->gem);
Applied to misc-next
Signature · 2 lines
Best regards, Dmitry