Skip to contentSkip to conversation

dumpcap: remove bogus rte_free()

PATCH Applied Stephen Hemminger 2 participants 2 messages Oct 20, 2022 – Oct 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dumpcap: remove bogus rte_free()

At end of program there is call to rte_free() which is passing a bogus value. There is no "bpf_filter" defined in this application; it ends up being a text address inside pcap library.

Fixes cbb44143be74 ("app/dumpcap: add new packet capture application")
---
 app/dumpcap/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
app/dumpcap/main.c +1 -1
index e0a3477d912f..e49558c2534a 100644
@@ -849,7 +849,7 @@ int main(int argc, char **argv)
 		pcap_dump_close(out.dumper);
 
 	cleanup_pdump_resources();
-	rte_free(bpf_filter);
+
 	rte_ring_free(r);
 	rte_mempool_free(mp);
 
Signature · 1 line
2.35.1
#1 lore raw
Quoted 6 lines · Stephen Hemminger

At end of program there is call to rte_free() which is passing a bogus value. There is no "bpf_filter" defined in this application; it ends up being a text address inside pcap library.

Fixes cbb44143be74 ("app/dumpcap: add new packet capture application")
Quoted 1 line

Applied, thanks.

Signature · 1 line
David Marchand