tracing/hist: add in missing * in comment blocks
Subsystems (2)
PATCH 1/1 tracing/hist: add in missing * in comment blocks
There are a couple of missing * in comment blocks. Fix these. Cleans up two clang warnings:
kernel/trace/trace_events_hist.c:986: warning: bad line:kernel/trace/trace_events_hist.c:3229: warning: bad line:
--- kernel/trace/trace_events_hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/trace/trace_events_hist.c +2 -2
@@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data,* A trigger can define one or more variables. If any one of them is * currently referenced by any other trigger, this function will * determine that. - +* * Typically used to determine whether or not a trigger can be removed * - if there are any references to a trigger's variables, it cannot. *
@@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data,* events. However, for convenience, users are allowed to directly * specify an event field in an action, which will be automatically * converted into a variable on their behalf. - +* * This function creates a field variable with the name var_name on * the hist trigger currently being defined on the target event. If * subsys_name and event_name are specified, this function simply
Signature · 1 line
2.37.3
Hi,
Quoted 7 lines · On Thu, 20 Oct 2022 14:30:19 +0100 Colin Ian King <[email protected]>…
There are a couple of missing * in comment blocks. Fix these. Cleans up two clang warnings:
kernel/trace/trace_events_hist.c:986: warning: bad line:kernel/trace/trace_events_hist.c:3229: warning: bad line:Signed-off-by Colin Ian King <[email protected]>
Thanks for the patch.
BTW, what version of clang are you using?
I couldn't see this warning with clang 15.0.0. Maybe I need a kconfig option?
Thank you,
Quoted 29 lines
--- kernel/trace/trace_events_hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/trace/trace_events_hist.c +2
-2@@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data,* A trigger can define one or more variables. If any one of them is * currently referenced by any other trigger, this function will * determine that. - +* * Typically used to determine whether or not a trigger can be removed * - if there are any references to a trigger's variables, it cannot. * @@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data,* events. However, for convenience, users are allowed to directly * specify an event field in an action, which will be automatically * converted into a variable on their behalf. - +* * This function creates a field variable with the name var_name on * the hist trigger currently being defined on the target event. If * subsys_name and event_name are specified, this function simply Signature · 1 line
2.37.3
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>
Quoted 11 lines · Masami Hiramatsu (Google)
Hi,
Quoted 6 lines · On Thu, 20 Oct 2022 14:30:19 +0100 Colin Ian King <[email protected]>…
There are a couple of missing * in comment blocks. Fix these. Cleans up two clang warnings:
kernel/trace/trace_events_hist.c:986: warning: bad line:kernel/trace/trace_events_hist.c:3229: warning: bad line:
Quoted 8 lines
Quoted 1 line
Signed-off-by Colin Ian King <[email protected]>Thanks for the patch.
BTW, what version of clang are you using?
I couldn't see this warning with clang 15.0.0. Maybe I need a kconfig option?
clang-13 and kernel W=1 for this specific case, e.g. kernel built using make CC=clang-13 HOSTCC=clang-13 W=1
Quoted 34 lines
Thank you,
Quoted 29 lines
--- kernel/trace/trace_events_hist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/trace/trace_events_hist.c +2
-2@@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data,* A trigger can define one or more variables. If any one of them is * currently referenced by any other trigger, this function will * determine that. - +* * Typically used to determine whether or not a trigger can be removed * - if there are any references to a trigger's variables, it cannot. * @@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data,* events. However, for convenience, users are allowed to directly * specify an event field in an action, which will be automatically * converted into a variable on their behalf. - +* * This function creates a field variable with the name var_name on * the hist trigger currently being defined on the target event. If * subsys_name and event_name are specified, this function simply Signature · 1 line
2.37.3
Quoted 14 lines · Colin King (gmail)
Quoted 13 lines · Masami Hiramatsu (Google)
Hi,
Quoted 7 lines · On Thu, 20 Oct 2022 14:30:19 +0100 Colin Ian King <[email protected]>…
There are a couple of missing * in comment blocks. Fix these. Cleans up two clang warnings:
kernel/trace/trace_events_hist.c:986: warning: bad line:kernel/trace/trace_events_hist.c:3229: warning: bad line:Signed-off-by Colin Ian King <[email protected]>
Quoted 9 lines
Quoted 6 lines
Thanks for the patch.
BTW, what version of clang are you using?
I couldn't see this warning with clang 15.0.0. Maybe I need a kconfig option?clang-13 and kernel W=1 for this specific case, e.g. kernel built using make CC=clang-13 HOSTCC=clang-13 W=1
but those are kernel-doc warnings, not clang (AFAIK).
Quoted 36 lines
Quoted 35 lines
Thank you,
Quoted 29 lines
---
kernel/trace/trace_events_hist.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)kernel/trace/trace_events_hist.c +2
-2@@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data, * A trigger can define one or more variables. If any one of them is * currently referenced by any other trigger, this function will * determine that. - + * * Typically used to determine whether or not a trigger can be removed * - if there are any references to a trigger's variables, it cannot. *@@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data, * events. However, for convenience, users are allowed to directly * specify an event field in an action, which will be automatically * converted into a variable on their behalf. - + * * This function creates a field variable with the name var_name on * the hist trigger currently being defined on the target event. If * subsys_name and event_name are specified, this function simply--
2.37.3
Signature · 1 line
~Randy
Masami Hiramatsu (Google)
maintainerQuoted 21 lines · On Thu, 20 Oct 2022 11:07:12 -0700 Randy Dunlap <[email protected]> wrote:
Quoted 18 lines · Colin King (gmail)
Quoted 17 lines · Masami Hiramatsu (Google)
Hi,
Quoted 7 lines · On Thu, 20 Oct 2022 14:30:19 +0100 Colin Ian King <[email protected]>…
There are a couple of missing * in comment blocks. Fix these. Cleans up two clang warnings:
kernel/trace/trace_events_hist.c:986: warning: bad line:kernel/trace/trace_events_hist.c:3229: warning: bad line:Signed-off-by Colin Ian King <[email protected]>Thanks for the patch.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
BTW, what version of clang are you using?
I couldn't see this warning with clang 15.0.0. Maybe I need a kconfig option?clang-13 and kernel W=1 for this specific case, e.g. kernel built using make CC=clang-13 HOSTCC=clang-13 W=1
but those are kernel-doc warnings, not clang (AFAIK).
Ah, I got it.
Thanks!
Quoted 40 lines
Quoted 37 lines
Quoted 36 lines
Thank you,
Quoted 29 lines
---
kernel/trace/trace_events_hist.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)kernel/trace/trace_events_hist.c +2
-2@@ -983,7 +983,7 @@ static struct hist_field *find_any_var_ref(struct hist_trigger_data *hist_data, * A trigger can define one or more variables. If any one of them is * currently referenced by any other trigger, this function will * determine that. - + * * Typically used to determine whether or not a trigger can be removed * - if there are any references to a trigger's variables, it cannot. *@@ -3226,7 +3226,7 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data, * events. However, for convenience, users are allowed to directly * specify an event field in an action, which will be automatically * converted into a variable on their behalf. - + * * This function creates a field variable with the name var_name on * the hist trigger currently being defined on the target event. If * subsys_name and event_name are specified, this function simply--
2.37.3Signature · 1 line
~Randy
Signature · 1 line
Masami Hiramatsu (Google) <[email protected]>