Skip to contentSkip to conversation

crypto/fsl: fsl_rsa: Fix dcache issue in the driver

PATCH New Gaurav Jain 2 participants 2 messages Sep 28, 2022 – Oct 21, 2022 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 crypto/fsl: fsl_rsa: Fix dcache issue in the driver

From: Ye Li <[email protected]>

issue:
CAAM fails with key error when perform Modular Exponentiation using PKHA Block in CAAM

Fix:
add flush and invalidate dcache for keys, signature and output decrypted data processed by CAAM.

Fixes 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver)

---
changes in v4:
- upgrade to latest.

changes in v3:
- fix warning: implicit declaration of function ‘flush_dcache_range’ [-Wimplicit-function-declaration]

 drivers/crypto/fsl/fsl_rsa.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/crypto/fsl/fsl_rsa.c +10 -0
index 897ee855ea..335b7fe25a 100644
@@ -6,6 +6,7 @@
 
 #include <config.h>
 #include <common.h>
+#include <cpu_func.h>
 #include <dm.h>
 #include <log.h>
 #include <asm/types.h>
@@ -36,12 +37,21 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
 
 	inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len);
 
+	flush_dcache_range((ulong)sig, (ulong)sig + sig_len);
+	flush_dcache_range((ulong)prop->modulus, (ulong)(prop->modulus) + keylen);
+	flush_dcache_range((ulong)prop->public_exponent,
+			   (ulong)(prop->public_exponent) + prop->exp_len);
+	flush_dcache_range((ulong)desc, (ulong)desc + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE));
+	flush_dcache_range((ulong)out, (ulong)out + sig_len);
+
 	ret = run_descriptor_jr(desc);
 	if (ret) {
 		debug("%s: RSA failed to verify: %d\n", __func__, ret);
 		return -EFAULT;
 	}
 
+	invalidate_dcache_range((ulong)out, (ulong)out + sig_len);
+
 	return 0;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH v4 1/1 crypto/fsl: fsl_rsa: Fix dcache issue in the driver

Quoted 11 lines

From: Ye Li <[email protected]>
issue:
CAAM fails with key error when perform Modular Exponentiation using PKHA Block in CAAM
Fix:
add flush and invalidate dcache for keys, signature and output decrypted data processed by CAAM.

Fixes 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver)

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================