Skip to contentSkip to conversation

protobuf: Enable protoc binary in nativesdk

PATCH In review Khem Raj 2 participants 4 messages Oct 21, 2022 – Oct 25, 2022

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 protobuf: Enable protoc binary in nativesdk

When it was disabled for target, it was enabled for native but not for nativesdk explicitly, lets do it here.

---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb +1 -0
index 0bc9cbedc0..c8b9158e6c 100644
@@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
+PACKAGECONFIG:class-nativesdk ?= "compiler"
 PACKAGECONFIG[python] = ",,"
 PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
 
Signature · 1 line
2.38.1
#1 lore raw

Hi Khem,

Quoted 5 lines · Khem Raj

When it was disabled for target, it was enabled for native but not for nativesdk explicitly, lets do it here.

I sent something similar 3 weeks ago:
https://www.mail-archive.com/[email protected]/msg84850.html

Just to be sure, is my submission format okay?

BR,
Clement

Quoted 28 lines
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb +1 -1
index 0bc9cbedc0..c8b9158e6c 100644
@@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
+PACKAGECONFIG:class-nativesdk ?= "compiler"
 PACKAGECONFIG[python] = ",,"
 PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
 
--

2.38.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255
Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 8 lines · Clément Péron

Hi Khem,

Quoted 4 lines · Khem Raj

When it was disabled for target, it was enabled for native but not for nativesdk explicitly, lets do it here.

Quoted 6 lines
Quoted 1 line

I sent something similar 3 weeks ago:
https://www.mail-archive.com/[email protected]/msg84850.html

Just to be sure, is my submission format okay?

Thanks for bringing this to my attention. I can not find this patch in my inbox, which might be that I accidentally deleted it
but I can not find it on patchwork either, which might be the reason that I never saw it. I have seen patchwork and lore not grok certain patches from the mailing list, and it does not seem to be obvious why. Unfortunately, the patch I sent is already applied to master, otherwise I would have credited it to you :)

Quoted 32 lines

BR,
Clement

Quoted 28 lines
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb +1 -1
index 0bc9cbedc0..c8b9158e6c 100644
@@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
+PACKAGECONFIG:class-nativesdk ?= "compiler"
 PACKAGECONFIG[python] = ",,"
 PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
 
--

2.38.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255
Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw

Hi Khem,

Quoted 17 lines · Khem Raj
Quoted 8 lines · Clément Péron

Hi Khem,

Quoted 4 lines · Khem Raj

When it was disabled for target, it was enabled for native but not for nativesdk explicitly, lets do it here.

Quoted 6 lines
Quoted 1 line

I sent something similar 3 weeks ago:
https://www.mail-archive.com/[email protected]/msg84850.html

Just to be sure, is my submission format okay?

Quoted 7 lines

Thanks for bringing this to my attention. I can not find this patch in my inbox, which might be that I accidentally deleted it
but I can not find it on patchwork either, which might be the reason that I never saw it. I have seen patchwork and lore not grok certain patches from the mailing list, and it does not seem to be obvious why. Unfortunately, the patch I sent is already applied to master, otherwise I would have credited it to you :)

No worries, I just wanted to confirm that my submission was correct.

Thanks for checking this.

BR, Clement

Quoted 33 lines
Quoted 33 lines

BR,
Clement

Quoted 28 lines
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb +1 -1
index 0bc9cbedc0..c8b9158e6c 100644
@@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
+PACKAGECONFIG:class-nativesdk ?= "compiler"
 PACKAGECONFIG[python] = ",,"
 PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
 
--

2.38.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255
Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-