Skip to contentSkip to conversation

generic/455: add $FSX_AVOID

PATCH In review Eric Whitney 4 participants 4 messages Oct 21, 2022 – Oct 26, 2022

lore
Share & tools
lore

Eric Whitney

author
#0 lore raw

PATCH 1/1 generic/455: add $FSX_AVOID

generic/455 fails when run on an ext4 bigalloc file system. Its fsx invocations can make insert range and collapse range calls whose arguments are not cluster aligned, and ext4 will fail those calls for bigalloc. They can be suppressed by adding the FSX_AVOID environment variable to the fsx invocation and setting its value appropriately in the test environment, as is done for other fsx-based tests. This avoids the need to exclude the test to avoid failures and makes it possible to take advantage of the remainder of its coverage.

Signed-off-by Eric Whitney <[email protected]>
---
 tests/generic/455 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/455 +1 -1
index 649b5410..c13d872c 100755
@@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 seeds=(0 0 0 0)
 # Run fsx for a while
 for j in `seq 0 $((NUM_FILES-1))`; do
-	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
 done
 wait
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Eric Whitney

generic/455 fails when run on an ext4 bigalloc file system. Its fsx invocations can make insert range and collapse range calls whose arguments are not cluster aligned, and ext4 will fail those calls for bigalloc. They can be suppressed by adding the FSX_AVOID environment variable to the fsx invocation and setting its value appropriately in the test environment, as is done for other fsx-based tests. This avoids the need to exclude the test to avoid failures and makes it possible to take advantage of the remainder of its coverage.

Signed-off-by Eric Whitney <[email protected]>

Yup.

Reviewed-by Darrick J. Wong <[email protected]>

--D

Quoted 20 lines
---
 tests/generic/455 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/455 +1 -1
index 649b5410..c13d872c 100755
@@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 seeds=(0 0 0 0)
 # Run fsx for a while
 for j in `seq 0 $((NUM_FILES-1))`; do
-	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
 done
 wait
Signature · 1 line
2.30.2
#2 lore raw
In reply to Eric Whitney
Quoted 19 lines · Eric Whitney

generic/455 fails when run on an ext4 bigalloc file system. Its fsx invocations can make insert range and collapse range calls whose arguments are not cluster aligned, and ext4 will fail those calls for bigalloc. They can be suppressed by adding the FSX_AVOID environment variable to the fsx invocation and setting its value appropriately in the test environment, as is done for other fsx-based tests. This avoids the need to exclude the test to avoid failures and makes it possible to take advantage of the remainder of its coverage.

Signed-off-by Eric Whitney <[email protected]>
---
 tests/generic/455 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/455 +0 -0
index 649b5410..c13d872c 100755

tests/generic/455 FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV" · line 80

Quoted 5 lines
tests/generic/455 +1 -1
@@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 seeds=(0 0 0 0)
 # Run fsx for a while
 for j in `seq 0 $((NUM_FILES-1))`; do
-	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &

generic/457 needs this fix as well.

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#3 lore raw
Quoted 15 lines · Dave Chinner
Quoted 14 lines · Eric Whitney

generic/455 fails when run on an ext4 bigalloc file system. Its fsx invocations can make insert range and collapse range calls whose arguments are not cluster aligned, and ext4 will fail those calls for bigalloc. They can be suppressed by adding the FSX_AVOID environment variable to the fsx invocation and setting its value appropriately in the test environment, as is done for other fsx-based tests. This avoids the need to exclude the test to avoid failures and makes it possible to take advantage of the remainder of its coverage.

Signed-off-by Eric Whitney <[email protected]>
---
 tests/generic/455 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

tests/generic/455 FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV" · line 80

Quoted 10 lines
tests/generic/455 +1 -1
index 649b5410..c13d872c 100755
@@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 seeds=(0 0 0 0)
 # Run fsx for a while
 for j in `seq 0 $((NUM_FILES-1))`; do
-	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &

generic/457 needs this fix as well.

Yes,

$ grep -rsn here/ltp/fsx tests/|grep -Ev "FSX_AVOID|replay-ops"
tests/generic/457:86:   run_check $here/ltp/fsx $FSX_OPTS -S 0 -j $j $SCRATCH_MNT/testfile$j &
tests/generic/455:80:   run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &

Hi Eric,

May you resend this patch? And you can keep Darrick's RVB in V2.

Thanks,
Zorro

Quoted 6 lines

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]