Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS
Subsystems (2)
PATCH v2 1/1 Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS
When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS command, use the correct op code in error status report:
was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS.
--- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/mgmt.c +1 -1
@@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev,* extra parameters we don't know about will be ignored in this request. */ if (data_len <MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE ) -return mgmt_cmd_status (sk, hdev->id,MGMT_OP_ADD_ADVERTISING , +return mgmt_cmd_status (sk, hdev->id,MGMT_OP_ADD_EXT_ADV_PARAMS ,MGMT_STATUS_INVALID_PARAMS ); flags =__le32_to_cpu (cp->flags);
Signature · 1 line
2.37.3
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=687734
---Test result---
Test Summary:
CheckPatch PASS 1.34 seconds GitLint PASS 0.77 seconds SubjectPrefix PASS 0.62 seconds BuildKernel PASS 41.37 seconds BuildKernel32 PASS 36.78 seconds Incremental Build with patchesPASS 54.99 seconds TestRunner: Setup PASS 618.60 seconds TestRunner: l2cap-tester PASS 19.67 seconds TestRunner: iso-tester PASS 19.61 seconds TestRunner: bnep-tester PASS 7.67 seconds TestRunner: mgmt-tester PASS 120.87 seconds TestRunner: rfcomm-tester PASS 12.12 seconds TestRunner: sco-tester PASS 11.25 seconds TestRunner: ioctl-tester PASS 12.91 seconds TestRunner: mesh-tester PASS 9.41 seconds TestRunner: smp-tester PASS 11.32 seconds TestRunner: userchan-tester PASS 8.19 seconds
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Fri, 21 Oct 2022 17:48:56 -0700 you wrote:
When validating the parameter length for
MGMT_OP_ADD_EXT_ADV_PARAMScommand, use the correct op code in error status report:
wasMGMT_OP_ADD_ADVERTISING, changed toMGMT_OP_ADD_EXT_ADV_PARAMS.Fixes 12410572833a2 ("Bluetooth: Break add adv into two mgmt commands")Signed-off-by Inga Stotland <[email protected]>[...]
Here is the summary with links:
- [v2] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS
https://git.kernel.org/bluetooth/bluetooth-next/c/28fd83db215e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html