Skip to contentSkip to conversation

coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE

PATCH New Nam Cao 1 participant 1 message Oct 23, 2022 VFS

lore
Share & tools
lore

Nam Cao

author
#0 lore raw

PATCH 1/1 coredump: wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE

The function dump_emit_page() is only called in dump_user_range(), which is wrapped in #ifdef CONFIG_ELF_CORE. This causes a build error when CONFIG_ELF_CORE is disabled:

CC fs/coredump.o
fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
834 | static int dump_emit_page(struct coredump_params *cprm, struct page *page)

      |            ^~~~~~~~~~~~~~

cc1: all warnings being treated as errors

Wrap dump_emit_page() in #ifdef CONFIG_ELF_CORE to avoid build problem.

---
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)
fs/coredump.c +2 -0
index 7bad7785e8e6..8663042ebe9c 100644
@@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
 	}
 }
 
+#ifdef CONFIG_ELF_CORE
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 {
 	struct bio_vec bvec = {
@@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 
 	return 1;
 }
+#endif
 
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
 {
Signature · 1 line
2.25.1