Skip to contentSkip to conversation

ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line

PATCH Applied Dmitry Torokhov 2 participants 2 messages Sep 30, 2022 – Oct 24, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: vf610-zii-dev-rev-c: fix polarity of at86rf233 reset line

at86rf230 driver starts with having reset line high, and then drives it low and then high again, and even calls it "rstn" internally, therefore it needs to be annotated as "active low" in the DTS.

This will make difference when at86rf230 driver will be converted to gpiod API that respects declared line polarity.

---
 arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts +1 -1
index de79dcfd32e6..f892977da9e4 100644
@@ -259,7 +259,7 @@ atzb-rf-233@1 {
 		xtal-trim = /bits/ 8 <0x06>;
 
 		sleep-gpio = <&gpio0 24 GPIO_ACTIVE_HIGH>;
-		reset-gpio = <&gpio6 10 GPIO_ACTIVE_HIGH>;
+		reset-gpio = <&gpio6 10 GPIO_ACTIVE_LOW>;
 
 		fsl,spi-cs-sck-delay = <180>;
 		fsl,spi-sck-cs-delay = <250>;
Signature · 5 lines
2.38.0.rc1.362.ged0d419d3c-goog


-- 
Dmitry
Applied
#1 lore raw
Quoted 8 lines · Dmitry Torokhov

at86rf230 driver starts with having reset line high, and then drives it low and then high again, and even calls it "rstn" internally, therefore it needs to be annotated as "active low" in the DTS.

This will make difference when at86rf230 driver will be converted to gpiod API that respects declared line polarity.

Applied, thanks!