Skip to contentSkip to conversation

arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

PATCH In review Heiko Thiery 3 participants 6 messages Oct 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Fixes 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)

v2:
- add Fixes tag

 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts +0 -1
index a91c136797f6..21442e04a632 100644
@@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-		off-on-delay-us = <20000>;
 		enable-active-high;
 	};
 };
Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Reviewed-by on v3 1/1
#1 lore raw

Hi Heiko,

Quoted 10 lines · Heiko Thiery

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Fixes 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
In reply to Heiko Thiery

Hi Heiko,

Quoted 2 lines · Heiko Thiery

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Now I'm curious, since this doesn't tell us the why, it just tell us about the end result. I'm asking because the NXP EVKs have an issue with the sd-card power line capacity and we need this delay to reach a level which is marked as low within the sd-spec.

Regards,
Marco

Quoted 29 lines
Fixes 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)

v2:
- add Fixes tag

 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts +0 -1
index a91c136797f6..21442e04a632 100644
@@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-		off-on-delay-us = <20000>;
 		enable-active-high;
 	};
 };
Signature · 1 line
2.30.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch <[email protected]>:

Quoted 11 lines

Hi Heiko,

Quoted 2 lines · Heiko Thiery

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Now I'm curious, since this doesn't tell us the why, it just tell us about the end result. I'm asking because the NXP EVKs have an issue with the sd-card power line capacity and we need this delay to reach a level which is marked as low within the sd-spec.

I must admit that I do not know at all why this entry was made. I have now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts I see no delay here.

Signature · 1 line
Heiko
Quoted 17 lines

Regards,
Marco

Quoted 13 lines
Fixes 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)

v2:
- add Fixes tag

 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
 1 file changed, 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts +0 -2
index a91c136797f6..21442e04a632 100644
@@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
              regulator-min-microvolt = <3300000>;
              regulator-max-microvolt = <3300000>;
              gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-             off-on-delay-us = <20000>;
              enable-active-high;
      };
 };
--
Quoted 3 lines

2.30.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 11 lines · Heiko Thiery

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch <[email protected]>:

Quoted 7 lines

Hi Heiko,

Quoted 2 lines · Heiko Thiery

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Quoted 8 lines
Quoted 4 lines

Now I'm curious, since this doesn't tell us the why, it just tell us about the end result. I'm asking because the NXP EVKs have an issue with the sd-card power line capacity and we need this delay to reach a level which is marked as low within the sd-spec.

I must admit that I do not know at all why this entry was made. I have now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts I see no delay here.

Please see <[email protected]>, they will be added.

Regards,
Marco

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:58 Uhr schrieb Marco Felsch <[email protected]>:

Quoted 18 lines · Heiko Thiery
Quoted 16 lines

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch <[email protected]>:

Quoted 11 lines

Hi Heiko,

Quoted 2 lines · Heiko Thiery

With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove.

Now I'm curious, since this doesn't tell us the why, it just tell us about the end result. I'm asking because the NXP EVKs have an issue with the sd-card power line capacity and we need this delay to reach a level which is marked as low within the sd-spec.

Quoted 6 lines
Quoted 3 lines

I must admit that I do not know at all why this entry was made. I have now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts I see no delay here.

Please see <[email protected]>, they will be added.

I think I have to re-check that and especially why U-Boot is not able with that setting to access the SD card for writing the environment.

Thanks!

Quoted 3 lines

Regards,
Marco

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel