Skip to contentSkip to conversation

automation: Explicitly enable NULL scheduler for boot-cpupools test

PATCH In review Michal Orzel 3 participants 3 messages Oct 24, 2022 – Oct 25, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 automation: Explicitly enable NULL scheduler for boot-cpupools test

NULL scheduler is not enabled by default on non-debug Xen builds. This causes the boot time cpupools test to fail on such build jobs. Fix the issue by explicitly specifying the config options required to enable the NULL scheduler.

Fixes 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")

---
Changes in v2:
- was: automation: Do not use null scheduler for boot cpupools test
- modify the commit msg/title
- explicitly enable NULL scheduler by specifying all the required options

This patch acts as a prerequisite before merging the following patch:
https://lore.kernel.org/xen-devel/[email protected]/
(to which Henry already gave RAB), that helped to find the issue described in the comment.

Tests shall explicitly specify the required Kconfig options for non-default pieces of logic, thus this patch is unrelated to the discussions whether enabling/disabling the NULL scheduler should be controlled by DEBUG or not.

---
 automation/gitlab-ci/build.yaml | 3 +++
 1 file changed, 3 insertions(+)
automation/gitlab-ci/build.yaml +3 -0
index ddc2234faf39..716ee0b1e460 100644
@@ -582,6 +582,9 @@ alpine-3.12-gcc-arm64-boot-cpupools:
   variables:
     CONTAINER: alpine:3.12-arm64v8
     EXTRA_XEN_CONFIG: |
+      CONFIG_EXPERT=y
+      CONFIG_UNSUPPORTED=y
+      CONFIG_SCHED_NULL=y
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
 ## Test artifacts common
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Michal Orzel

NULL scheduler is not enabled by default on non-debug Xen builds. This causes the boot time cpupools test to fail on such build jobs. Fix the issue by explicitly specifying the config options required to enable the NULL scheduler.

Fixes 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")

I would like a release-ack by Henry on this

Quoted 35 lines

---
Changes in v2:
- was: automation: Do not use null scheduler for boot cpupools test
- modify the commit msg/title
- explicitly enable NULL scheduler by specifying all the required options

This patch acts as a prerequisite before merging the following patch:
https://lore.kernel.org/xen-devel/[email protected]/
(to which Henry already gave RAB), that helped to find the issue described in the comment.

Tests shall explicitly specify the required Kconfig options for non-default pieces of logic, thus this patch is unrelated to the discussions whether enabling/disabling the NULL scheduler should be controlled by DEBUG or not.

---
 automation/gitlab-ci/build.yaml | 3 +++
 1 file changed, 3 insertions(+)
automation/gitlab-ci/build.yaml +3 -0
index ddc2234faf39..716ee0b1e460 100644
@@ -582,6 +582,9 @@ alpine-3.12-gcc-arm64-boot-cpupools:
   variables:
     CONTAINER: alpine:3.12-arm64v8
     EXTRA_XEN_CONFIG: |
+      CONFIG_EXPERT=y
+      CONFIG_UNSUPPORTED=y
+      CONFIG_SCHED_NULL=y
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
 ## Test artifacts common
Signature · 1 line
2.25.1
#2 lore raw

Hi Stefano and Michal,

Quoted 11 lines

-----Original Message-----
From: Stefano Stabellini <[email protected]>
Subject: Re: [for-4.17, PATCH v2] automation: Explicitly enable NULL scheduler for boot-cpupools test

Quoted 5 lines · Michal Orzel

NULL scheduler is not enabled by default on non-debug Xen builds. This causes the boot time cpupools test to fail on such build jobs. Fix the issue by explicitly specifying the config options required to enable the NULL scheduler.

Quoted 7 lines
Quoted 1 line
Fixes 36e3f4158778 ("automation: Add a new job for testing boot time

cpupools on arm64")

Quoted 1 line

I would like a release-ack by Henry on this

Kind regards,
Henry