pinctrl: samsung: remove variable pin
Subsystems (5)
PATCH 1/1 pinctrl: samsung: remove variable pin
Variable pin is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pinctrl/samsung/pinctrl-s3c24xx.c +1 -2
@@ -509,7 +509,6 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d)struct s3c24xx_eint_domain_data *ddata;unsigned int mask;unsigned int irq; -unsigned int pin;if (bank->eint_type !=EINT_TYPE_WKUP )continue ;
@@ -534,7 +533,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) irq = bank->eint_offset; mask = bank->eint_mask; -for (pin =0 ; mask; ++pin, mask >>=1 ) { +for (; mask; mask >>=1 ) {if (irq >=NUM_EINT )break ;if (!(mask &1 ))
Signature · 7 lines
2.37.3 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 8 lines · Colin Ian King
Variable pin is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.
Signed-off-by Colin Ian King <[email protected]>--- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks for the patch. The file is being in process of dropping (patchset is being reviewed), so I think we can skip all the fixes.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel