Skip to contentSkip to conversation

scsi: nsp_cs: remove variable i

PATCH Applied Colin Ian King 2 participants 3 messages Oct 24, 2022 – Nov 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: nsp_cs: remove variable i

Variable i is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/scsi/pcmcia/nsp_cs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/pcmcia/nsp_cs.c +1 -3
index 48acab03a8a0..a5a1406a2bde 100644
@@ -450,8 +450,6 @@ static int nsp_analyze_sdtr(struct scsi_cmnd *SCpnt)
 	sync_data	      *sync   = &(data->Sync[target]);
 	struct nsp_sync_table *sync_table;
 	unsigned int	       period, offset;
-	int		       i;
-
 
 	nsp_dbg(NSP_DEBUG_SYNC, "in");
 
@@ -466,7 +464,7 @@ static int nsp_analyze_sdtr(struct scsi_cmnd *SCpnt)
 		sync_table = nsp_sync_table_40M;
 	}
 
-	for ( i = 0; sync_table->max_period != 0; i++, sync_table++) {
+	for (; sync_table->max_period != 0; sync_table++) {
 		if ( period >= sync_table->min_period &&
 		     period <= sync_table->max_period	 ) {
 			break;
Signature · 1 line
2.37.3
#1 lore raw

Colin,

Quoted 2 lines

Variable i is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

Applied to 6.2/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering