ACPI: video: Fix missing native backlight on Chromebooks
PATCH v2 1/1 ACPI: video: Fix missing native backlight on Chromebooks
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.
drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/acpi/video_detect.c +12 -0
@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present (void ) +{ +return acpi_dev_found ("GOOG0004" ); +} +/* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect.
@@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)return acpi_backlight_video; } +/* +* Chromebooks that don't have backlight handle in ACPI table +* are supposed to use native backlight if it's available. +*/ +if (google_cros_ec_present () && native_available) +return acpi_backlight_native; +/* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Signature · 1 line
2.37.3
Hi,
Quoted 7 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>
Quoted 6 lines
---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.
Thanks this version looks good to me:
Rafael, can you pick this up and send it in a fixes pull-req for 6.1 to Linus? Or shall I pick this one up and include it in my next pull-req?
Regards,
Hans
Quoted 34 lines
drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +12
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present (void ) +{ +return acpi_dev_found ("GOOG0004" ); +} +/* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)return acpi_backlight_video; } +/* +* Chromebooks that don't have backlight handle in ACPI table +* are supposed to use native backlight if it's available. +*/ +if (google_cros_ec_present () && native_available) +return acpi_backlight_native; +/* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Rafael J. Wysocki
maintainerQuoted 18 lines · Hans de Goede
Hi,
Quoted 7 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>Quoted 6 lines
---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.
Quoted 7 lines
Thanks this version looks good to me:
Reviewed-by Hans de Goede <[email protected]>Rafael, can you pick this up and send it in a fixes pull-req for 6.1 to Linus? Or shall I pick this one up and include it in my next pull-req?
It would be better if you could pick this up IMV, so please free to add
to it.
Thanks!
Quoted 35 lines
Quoted 34 lines
drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +12
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present (void ) +{ +return acpi_dev_found ("GOOG0004" ); +} +/* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)return acpi_backlight_video; } +/* +* Chromebooks that don't have backlight handle in ACPI table +* are supposed to use native backlight if it's available. +*/ +if (google_cros_ec_present () && native_available) +return acpi_backlight_native; +/* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Hi,
Quoted 23 lines · Rafael J. Wysocki
Quoted 22 lines · Hans de Goede
Hi,
Quoted 7 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>Quoted 6 lines
---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.Thanks this version looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Quoted 7 lines
Quoted 3 lines
Rafael, can you pick this up and send it in a fixes pull-req for 6.1 to Linus? Or shall I pick this one up and include it in my next pull-req?
It would be better if you could pick this up IMV, so please free to add
Ok, I've merged this now and I'll send out fixes pull-req with this to Linus before coming Friday.
Dmitry, Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes
Regards,
Hans
Quoted 41 lines
to it.
Thanks!
Quoted 35 lines
Quoted 34 lines
drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +12
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present (void ) +{ +return acpi_dev_found ("GOOG0004" ); +} +/* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)return acpi_backlight_video; } +/* +* Chromebooks that don't have backlight handle in ACPI table +* are supposed to use native backlight if it's available. +*/ +if (google_cros_ec_present () && native_available) +return acpi_backlight_native; +/* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Quoted 37 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +5
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present (void ) +{ +return acpi_dev_found ("GOOG0004" ); +} +/* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native)return acpi_backlight_video; }
drivers/acpi/video_detect.c static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) · line 747
Quoted 10 lines
drivers/acpi/video_detect.c +7
-0+/* +* Chromebooks that don't have backlight handle in ACPI table +* are supposed to use native backlight if it's available. +*/ +if (google_cros_ec_present () && native_available) +return acpi_backlight_native; +/* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Hi,
The native_available check does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination.
Regards,
Akihiko Odaki
Hi,
Quoted 49 lines · Akihiko Odaki
Quoted 37 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v2: - Added explanatory comment to the code and added check for the native backlight presence, like was requested by Hans de Goede.
drivers/acpi/video_detect.c| 12 ++++++++++++1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +4
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present(void) +{ + return acpi_dev_found("GOOG0004"); +} + /** Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) return acpi_backlight_video; }+ /*
+ * Chromebooks that don't have backlight handle in ACPI tableQuoted 8 lines
+ * are supposed to use native backlight if it's available. + */
+ if (google_cros_ec_present()&&native_available)
+ returnacpi_backlight_native;
+
/* No ACPI video (old hw), use vendor specific fw methods. */ returnacpi_backlight_vendor;
}Hi,
Quoted 1 line
The
native_availablecheck does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination.
There are no drivers providing acpi_backlight_vendor functionality on chromebooks.
All the drivers providing acpi_backlight_vendor functionality use vendor (Dell, Acer, Asus, etc.) specific firmware (smbios, EC bitbanging or ACPI) backlight control method which are not available on CoreBoot based ChromeBooks.
Also notice that the theoretical problem of a vendor driver loading first was already present before the backlight refactor which landed in 6.1 and this has never been an issue.
Regards,
Hans
Quoted 52 lines · Hans de Goede
Hi,
Quoted 49 lines · Akihiko Odaki
Quoted 35 lines · Dmitry Osipenko
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found.
Suggested-by Hans de Goede <[email protected]>Fixes 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper")Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v2: - Added explanatory comment to the code and added check for the
native backlight presence, like was requested by Hans de Goede.drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/acpi/video_detect.c +4
-0@@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present(void) +{ + return acpi_dev_found("GOOG0004"); +} + /** Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) return acpi_backlight_video; }drivers/acpi/video_detect.c static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) · line 746
Quoted 10 lines
drivers/acpi/video_detect.c +6
-0+ /* + * Chromebooks that don't have backlight handle in ACPI table + * are supposed to use native backlight if it's available. + */ + if (google_cros_ec_present() && native_available) + return acpi_backlight_native; + /* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }Hi,
Quoted 7 lines
Quoted 1 line
The
native_availablecheck does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination.There are no drivers providing
acpi_backlight_vendorfunctionality on chromebooks.All the drivers providing
acpi_backlight_vendorfunctionality use vendor (Dell, Acer, Asus, etc.) specific firmware (smbios, EC bitbanging or ACPI) backlight control method which are not available on CoreBoot based ChromeBooks.
Hi,
Isn't the "native_available" check is for the case when acpi_backlight_vendor functionality gets implemented on Chromebooks? If it is, you don't want it to get broken when it actually happens. If you can ignore the case, native_available check is simply unnecessary.
Quoted 3 lines
Also notice that the theoretical problem of a vendor driver loading first was already present before the backlight refactor which landed in 6.1 and this has never been an issue.
The situation is even a bit better than it was before the refactor since duplication happened even when vendor driver loads later if I understand it correctly.
Regards,
Akihiko Odaki
Quoted 5 lines
Regards,
Hans