Skip to contentSkip to conversation

arm64: dts: ti: rename clock-names adc_tsc_fck to fck

PATCH Applied Matt Ranostay 4 participants 5 messages Oct 24, 2022 – Nov 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: ti: rename clock-names adc_tsc_fck to fck

Avoid the following warnings from dt-schema by just renaming the clock-names string from adc_tsc_fck to fck so it matches the values in ti,am3359-tscadc.yaml

tscadc@40200000: clock-names:0: 'fck' was expected

---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi        | 2 +-
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/ti/k3-am64-main.dtsi +1 -1
index d6aa23681bbe..b61c15427bf7 100644
@@ -612,7 +612,7 @@ tscadc0: tscadc@28001000 {
 		assigned-clocks = <&k3_clks 0 0>;
 		assigned-clock-parents = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 
 		adc {
 			#io-channel-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 8d592bf41d6f..1807ec4730cb 100644
@@ -85,7 +85,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 2>;
 		assigned-clocks = <&k3_clks 0 2>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&mcu_udmap 0x7100>,
 			<&mcu_udmap 0x7101 >;
 		dma-names = "fifo0", "fifo1";
@@ -103,7 +103,7 @@ tscadc1: tscadc@40210000 {
 		clocks = <&k3_clks 1 2>;
 		assigned-clocks = <&k3_clks 1 2>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&mcu_udmap 0x7102>,
 			<&mcu_udmap 0x7103>;
 		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
index 2025aab4b66f..3d9190a869c5 100644
@@ -325,7 +325,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 1>;
 		assigned-clocks = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7400>,
 			<&main_udmap 0x7401>;
 		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +2 -2
index 5d9ec221fa34..7799db6a167c 100644
@@ -216,7 +216,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 1>;
 		assigned-clocks = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7400>,
 			<&main_udmap 0x7401>;
 		dma-names = "fifo0", "fifo1";
@@ -235,7 +235,7 @@ tscadc1: tscadc@40210000 {
 		clocks = <&k3_clks 1 1>;
 		assigned-clocks = <&k3_clks 1 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7402>,
 			<&main_udmap 0x7403>;
 		dma-names = "fifo0", "fifo1";
Signature · 7 lines
2.38.GIT


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Matt Ranostay

Avoid the following warnings from dt-schema by just renaming the clock-names string from adc_tsc_fck to fck so it matches the values in ti,am3359-tscadc.yaml

tscadc@40200000: clock-names:0: 'fck' was expected

---

This patch LGTM.

Quoted 76 lines
  arch/arm64/boot/dts/ti/k3-am64-main.dtsi        | 2 +-
  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
  arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
  4 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/ti/k3-am64-main.dtsi +1 -1
index d6aa23681bbe..b61c15427bf7 100644
@@ -612,7 +612,7 @@ tscadc0: tscadc@28001000 {
  		assigned-clocks = <&k3_clks 0 0>;
  		assigned-clock-parents = <&k3_clks 0 3>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 
  		adc {
  			#io-channel-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 8d592bf41d6f..1807ec4730cb 100644
@@ -85,7 +85,7 @@ tscadc0: tscadc@40200000 {
  		clocks = <&k3_clks 0 2>;
  		assigned-clocks = <&k3_clks 0 2>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
  		dmas = <&mcu_udmap 0x7100>,
  			<&mcu_udmap 0x7101 >;
  		dma-names = "fifo0", "fifo1";
@@ -103,7 +103,7 @@ tscadc1: tscadc@40210000 {
  		clocks = <&k3_clks 1 2>;
  		assigned-clocks = <&k3_clks 1 2>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
  		dmas = <&mcu_udmap 0x7102>,
  			<&mcu_udmap 0x7103>;
  		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
index 2025aab4b66f..3d9190a869c5 100644
@@ -325,7 +325,7 @@ tscadc0: tscadc@40200000 {
  		clocks = <&k3_clks 0 1>;
  		assigned-clocks = <&k3_clks 0 3>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
  		dmas = <&main_udmap 0x7400>,
  			<&main_udmap 0x7401>;
  		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +2 -2
index 5d9ec221fa34..7799db6a167c 100644
@@ -216,7 +216,7 @@ tscadc0: tscadc@40200000 {
  		clocks = <&k3_clks 0 1>;
  		assigned-clocks = <&k3_clks 0 3>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
  		dmas = <&main_udmap 0x7400>,
  			<&main_udmap 0x7401>;
  		dma-names = "fifo0", "fifo1";
@@ -235,7 +235,7 @@ tscadc1: tscadc@40210000 {
  		clocks = <&k3_clks 1 1>;
  		assigned-clocks = <&k3_clks 1 3>;
  		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
  		dmas = <&main_udmap 0x7402>,
  			<&main_udmap 0x7403>;
  		dma-names = "fifo0", "fifo1";
#2 lore raw
In reply to Matt Ranostay

Hello,

Quoted 6 lines · Matt Ranostay

Avoid the following warnings from dt-schema by just renaming the clock-names string from adc_tsc_fck to fck so it matches the values in ti,am3359-tscadc.yaml

tscadc@40200000: clock-names:0: 'fck' was expected

Tested on AM64x GP EVM.

Quoted 78 lines
---
 arch/arm64/boot/dts/ti/k3-am64-main.dtsi        | 2 +-
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/ti/k3-am64-main.dtsi +1 -1
index d6aa23681bbe..b61c15427bf7 100644
@@ -612,7 +612,7 @@ tscadc0: tscadc@28001000 {
 		assigned-clocks = <&k3_clks 0 0>;
 		assigned-clock-parents = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 
 		adc {
 			#io-channel-cells = <1>;
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi +2 -2
index 8d592bf41d6f..1807ec4730cb 100644
@@ -85,7 +85,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 2>;
 		assigned-clocks = <&k3_clks 0 2>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&mcu_udmap 0x7100>,
 			<&mcu_udmap 0x7101 >;
 		dma-names = "fifo0", "fifo1";
@@ -103,7 +103,7 @@ tscadc1: tscadc@40210000 {
 		clocks = <&k3_clks 1 2>;
 		assigned-clocks = <&k3_clks 1 2>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&mcu_udmap 0x7102>,
 			<&mcu_udmap 0x7103>;
 		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
index 2025aab4b66f..3d9190a869c5 100644
@@ -325,7 +325,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 1>;
 		assigned-clocks = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7400>,
 			<&main_udmap 0x7401>;
 		dma-names = "fifo0", "fifo1";
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +2 -2
index 5d9ec221fa34..7799db6a167c 100644
@@ -216,7 +216,7 @@ tscadc0: tscadc@40200000 {
 		clocks = <&k3_clks 0 1>;
 		assigned-clocks = <&k3_clks 0 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7400>,
 			<&main_udmap 0x7401>;
 		dma-names = "fifo0", "fifo1";
@@ -235,7 +235,7 @@ tscadc1: tscadc@40210000 {
 		clocks = <&k3_clks 1 1>;
 		assigned-clocks = <&k3_clks 1 3>;
 		assigned-clock-rates = <60000000>;
-		clock-names = "adc_tsc_fck";
+		clock-names = "fck";
 		dmas = <&main_udmap 0x7402>,
 			<&main_udmap 0x7403>;
 		dma-names = "fifo0", "fifo1";
maintainer
#3 lore raw
Quoted 7 lines · Judith Mendez

Hello,

Quoted 4 lines · Matt Ranostay

Avoid the following warnings from dt-schema by just renaming the clock-names string from adc_tsc_fck to fck so it matches the values in ti,am3359-tscadc.yaml

Quoted 6 lines
Quoted 2 lines

tscadc@40200000: clock-names:0: 'fck' was expected

Tested on AM64x GP EVM.

Documentation/process/submitting-patches.rst Could you use the standard conventions defined there? I think you mean Tested-by? if so, please use that tag.

Quote from documentation:
"A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. This tag informs maintainers that some testing has been performed, provides a means to locate testers for future patches, and ensures credit for the testers.
"

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
maintainer Applied
#4 lore raw
In reply to Matt Ranostay

Hi Matt Ranostay,

Quoted 8 lines · Matt Ranostay

Avoid the following warnings from dt-schema by just renaming the clock-names string from adc_tsc_fck to fck so it matches the values in ti,am3359-tscadc.yaml

tscadc@40200000: clock-names:0: 'fck' was expected

[...]

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/1] arm64: dts: ti: rename clock-names adc_tsc_fck to fck

      commit: e5bad300e46c5bd0c5cf0a89c74116fbbf608a8c

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D