vboxsf: Remove variable out_len
Subsystems (3)
PATCH 1/1 vboxsf: Remove variable out_len
Variable out_len is just being incremented by nb and it's never used anywhere else. The variable and the increment are redundant so remove it.
Signed-off-by Colin Ian King <[email protected]>
--- fs/vboxsf/utils.c | 3 --- 1 file changed, 3 deletions(-)
fs/vboxsf/utils.c +0 -3
@@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, {const char *in;char *out; -size_t out_len;size_t out_bound_len;size_t in_bound_len;
@@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, in_bound_len = utf8_len; out = name; - out_len =0 ;/* Reserve space for terminating 0 */ out_bound_len = name_bound_len -1 ;
@@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, out += nb; out_bound_len -= nb; - out_len += nb; } *out =0 ;
Signature · 1 line
2.37.3
Hi,
Quoted 5 lines · Colin Ian King
Variable
out_lenis just being incremented by nb and it's never used anywhere else. The variable and the increment are redundant so remove it.Signed-off-by Colin Ian King <[email protected]>
Thanks, patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Regards,
Hans
Quoted 32 lines
--- fs/vboxsf/utils.c | 3 --- 1 file changed, 3 deletions(-)fs/vboxsf/utils.c +0
-3@@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, {const char *in;char *out; -size_t out_len;size_t out_bound_len;size_t in_bound_len;@@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, in_bound_len = utf8_len; out = name; - out_len =0 ;/* Reserve space for terminating 0 */ out_bound_len = name_bound_len -1 ;@@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, out += nb; out_bound_len -= nb; - out_len += nb; } *out =0 ;