ap: disallow TKIP and 'use group cipher'
PATCH 1/1 ap: disallow TKIP and 'use group cipher'
The EAPoL SM does not support either of these ciphers when acting as an authenticator since ARC4 encryption is not implemented. (see eapol_encrypt_key_data() for key descriptor version 1)
This can cause 4-way failures if e.g. the hardware only supports TKIP. Rather than fail the 4-way its better to not even start the AP and return NotSupported.
--- src/ap.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
src/ap.c +9 -1
@@ -3303,7 +3303,15 @@ struct ap_state *ap_start(struct netdev *netdev, struct l_settings *config, err = -EINVAL ;/* TODO: Add all ciphers supported by wiphy */ - ap->ciphers =wiphy_select_cipher (wiphy,0xffff ); + ap->ciphers =wiphy_select_cipher (wiphy, + ~(IE_RSN_CIPHER_SUITE_USE_GROUP_CIPHER | +IE_RSN_CIPHER_SUITE_TKIP )); +if (!ap->ciphers) { +l_error ("Hardware does not support required pairwise ciphers!" ); + err = -ENOTSUP ; + goto error; + } + ap->group_cipher =wiphy_select_cipher (wiphy,0xffff ); ap->beacon_interval =100 ; ap->networks =l_queue_new ();
Signature · 1 line
2.34.3
Hi James,
Quoted 11 lines · James Prestwood
The EAPoL SM does not support either of these ciphers when acting as an authenticator since ARC4 encryption is not implemented. (see
eapol_encrypt_key_data()for key descriptor version 1)This can cause 4-way failures if e.g. the hardware only supports TKIP. Rather than fail the 4-way its better to not even start the AP and return NotSupported.
--- src/ap.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
Well, I have a patch pending that limits the ciphers to TKIP or CCMP since P2P only works with those. No sense in choosing GCMP, CCMP-256, etc yet. So we can implement the missing bits in eapol_encrypt_key_data, or simply check whether CCMP is supported and only use that.
Regards,
-Denis