Skip to contentSkip to conversation

kunit: remove unused structure definition

PATCH In review YoungJun.park 2 participants 2 messages Oct 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kunit: remove unused structure definition

remove unused string_stream_alloc_context structure definition.

---
 lib/kunit/string-stream.c | 5 -----
 1 file changed, 5 deletions(-)
lib/kunit/string-stream.c +0 -5
index f5ae79c37400..72659a9773e3 100644
@@ -131,11 +131,6 @@ bool string_stream_is_empty(struct string_stream *stream)
 	return list_empty(&stream->fragments);
 }
 
-struct string_stream_alloc_context {
-	struct kunit *test;
-	gfp_t gfp;
-};
-
 struct string_stream *alloc_string_stream(struct kunit *test, gfp_t gfp)
 {
 	struct string_stream *stream;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · YoungJun.park

remove unused string_stream_alloc_context structure definition.

---

Thanks for catching this! It looks like we remembered to get rid of the related struct string_stream_fragment_alloc_context, but missed this one.

Fixes 78b1c6584fce ("kunit: string-stream: Simplify resource use")

Cheers,
-- David

Quoted 22 lines
 lib/kunit/string-stream.c | 5 -----
 1 file changed, 5 deletions(-)
lib/kunit/string-stream.c +0 -6
index f5ae79c37400..72659a9773e3 100644
@@ -131,11 +131,6 @@ bool string_stream_is_empty(struct string_stream *stream)
        return list_empty(&stream->fragments);
 }
 
-struct string_stream_alloc_context {
-       struct kunit *test;
-       gfp_t gfp;
-};
-
 struct string_stream *alloc_string_stream(struct kunit *test, gfp_t gfp)
 {
        struct string_stream *stream;
--

2.25.1