Skip to contentSkip to conversation

m68k: mac_via: remove unused rbv_set_video_bpp()

PATCH In review Jason A. Donenfeld 2 participants 2 messages Oct 26, 2022 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: mac_via: remove unused rbv_set_video_bpp()

In examining rbv_set_video_bpp()'s improper usage of a non-explictly signed char type, it turns out that the function is actually unused. So remove it.

Cc Geert Uytterhoeven <[email protected]>
---
 arch/m68k/include/asm/mac_via.h | 8 --------
 1 file changed, 8 deletions(-)
arch/m68k/include/asm/mac_via.h +0 -8
index 1149251ea58d..a9ef1e9ba6c4 100644
@@ -267,14 +267,6 @@ extern void via1_irq(struct irq_desc *desc);
 extern void via1_set_head(int);
 extern int via2_scsi_drq_pending(void);
 
-static inline int rbv_set_video_bpp(int bpp)
-{
-	char val = (bpp==1)?0:(bpp==2)?1:(bpp==4)?2:(bpp==8)?3:-1;
-	if (!rbv_present || val<0) return -1;
-	via2[rMonP] = (via2[rMonP] & ~RBV_DEPTH) | val;
-	return 0;
-}
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_MAC_VIA_H_ */
Signature · 1 line
2.38.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jason A. Donenfeld

In examining rbv_set_video_bpp()'s improper usage of a non-explictly signed char type, it turns out that the function is actually unused. So remove it.

Cc Geert Uytterhoeven <[email protected]>

i.e. will queue in the m68k for-v6.2 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds