Skip to contentSkip to conversation

nfsd: fix licensing header in filecache.c

PATCH In review Jeff Layton 3 participants 7 messages Oct 26, 2022 – Oct 31, 2022

Subsystems (2)
lore
Share & tools
lore

Jeff Layton

author maintainer
#0 lore raw

PATCH 1/1 nfsd: fix licensing header in filecache.c

I'm the same Jeff Layton that worked at Primary Data, but the email address is no good anymore. Drop the explicit copyright statement and change it to use a standard SPDX header.

---
 fs/nfsd/filecache.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/nfsd/filecache.c +2 -3
index 918d67cec1ad..dbc61b243d39 100644
@@ -1,7 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
- * Open file cache.
- *
- * (c) 2015 - Jeff Layton <[email protected]>
+ * The NFSD open file cache.
  */
 
 #include <linux/hash.h>
Signature · 1 line
2.37.3
#1 lore raw
Quoted 9 lines · Jeff Layton

I'm the same Jeff Layton that worked at Primary Data, but the email address is no good anymore. Drop the explicit copyright statement and change it to use a standard SPDX header.

Excellent, I'll apply this today.

Quoted 21 lines

---
fs/nfsd/filecache.c | 5 ++---

1 file changed, 2 insertions(+), 3 deletions(-)
fs/nfsd/filecache.c +2 -3
index 918d67cec1ad..dbc61b243d39 100644
@@ -1,7 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
- * Open file cache.
- *
- * (c) 2015 - Jeff Layton <[email protected]>
+ * The NFSD open file cache.
 */
 
 #include <linux/hash.h>
Signature · 1 line
2.37.3

--
Chuck Lever

#2 lore raw
In reply to Jeff Layton
Quoted 6 lines · Jeff Layton

+// SPDX-License-Identifier: GPL-2.0
/*
- * Open file cache.
- *
- * (c) 2015 - Jeff Layton <[email protected]>
+ * The NFSD open file cache.

ЅPDX identifiers do not replace copyright statements. So while adding one is agood idea, dropping the copyright notice (if that counts as one) is not.

#3 lore raw
Quoted 12 lines · Christoph Hellwig
Quoted 6 lines · Jeff Layton

+// SPDX-License-Identifier: GPL-2.0
/*
- * Open file cache.
- *
- * (c) 2015 - Jeff Layton <[email protected]>
+ * The NFSD open file cache.

Quoted 3 lines

ЅPDX identifiers do not replace copyright statements. So while adding one is agood idea, dropping the copyright notice (if that counts as one) is not.

I know you are Not A Lawyer (tm), but:

The e-mail address in the copyright notice is stale. Is the convention to leave stale e-mail addresses in place?

So I would expect copyright ownership of this code to go to Primary Data, Jeff's employer at the time. But they don't exist now either; it might be difficult to get permission from them to alter this notice.

--
Chuck Lever

#4 lore raw
Quoted 8 lines · Chuck Lever III

I know you are Not A Lawyer (tm), but:

The e-mail address in the copyright notice is stale. Is the convention to leave stale e-mail addresses in place?

So I would expect copyright ownership of this code to go to Primary Data, Jeff's employer at the time. But they don't exist now either; it might be difficult to get permission from them to alter this notice.

I'm not a copyright lawyer, but I've talked to a few, so:

- first, does Jeff own the copyright for this code, or his employer at the time?
- if he owns it, can cna do pretty much whatever he wants
- if he doesn't, I would not touch it without approval from the copyright holder, which gets a little complicated for a company that doesn't exist in that form any more.

author maintainer
#5 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 8 lines · Chuck Lever III

I know you are Not A Lawyer (tm), but:

The e-mail address in the copyright notice is stale. Is the convention to leave stale e-mail addresses in place?

So I would expect copyright ownership of this code to go to Primary Data, Jeff's employer at the time. But they don't exist now either; it might be difficult to get permission from them to alter this notice.

Quoted 8 lines

I'm not a copyright lawyer, but I've talked to a few, so:

- first, does Jeff own the copyright for this code, or his employer at the time?
- if he owns it, can cna do pretty much whatever he wants
- if he doesn't, I would not touch it without approval from the copyright holder, which gets a little complicated for a company that doesn't exist in that form any more.

I went back and looked at the PD employment contract and I think I may not own the copyright here. There was no explicit carveout for open- source contributions (like I have at RH).

In light of that, I guess we should drop this patch and replace it with one that just adds the SPDX header.

Signature · 1 line
Jeff Layton <[email protected]>
#6 lore raw
Quoted 24 lines · Jeff Layton
Quoted 10 lines · Christoph Hellwig
Quoted 8 lines · Chuck Lever III

I know you are Not A Lawyer (tm), but:

The e-mail address in the copyright notice is stale. Is the convention to leave stale e-mail addresses in place?

So I would expect copyright ownership of this code to go to Primary Data, Jeff's employer at the time. But they don't exist now either; it might be difficult to get permission from them to alter this notice.

Quoted 8 lines

I'm not a copyright lawyer, but I've talked to a few, so:

- first, does Jeff own the copyright for this code, or his employer at the time?
- if he owns it, can cna do pretty much whatever he wants
- if he doesn't, I would not touch it without approval from the copyright holder, which gets a little complicated for a company that doesn't exist in that form any more.

Quoted 6 lines

I went back and looked at the PD employment contract and I think I may not own the copyright here. There was no explicit carveout for open- source contributions (like I have at RH).

In light of that, I guess we should drop this patch and replace it with one that just adds the SPDX header.

OK. I can cobble one up.

--
Chuck Lever