Skip to contentSkip to conversation

package/mdio-tools: new package

PATCH In review Robert Marko 2 participants 3 messages Oct 27, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/mdio-tools: new package

mdio-tools are kernel module and accompanying tools for low-level debugging of devices attached on MDIO bus like PHY-s, switches etc.

Userspace tools provide C22 or C45 reads and writes, benchmarking and even dedicated Marvell Link Street tools via the included kernel module.

---
Changes in v3:
* Add dependecy on 5.1 headers

Changes in v2:
* Correct license
* Add host-pkgconf to DEPENDENCIES
* Add minimal required kernel config options

---
 package/Config.in                  |  1 +
 package/mdio-tools/Config.in       | 10 ++++++++++
 package/mdio-tools/mdio-tools.hash |  3 +++
 package/mdio-tools/mdio-tools.mk   | 20 ++++++++++++++++++++
 4 files changed, 34 insertions(+)
 create mode 100644 package/mdio-tools/Config.in
 create mode 100644 package/mdio-tools/mdio-tools.hash
 create mode 100644 package/mdio-tools/mdio-tools.mk
package/Config.in +1 -0
index e3a34d6e97..ed41e8bdd4 100644
@@ -536,6 +536,7 @@ endmenu
 	source "package/mbpfan/Config.in"
 	source "package/mdadm/Config.in"
 	source "package/mdevd/Config.in"
+	source "package/mdio-tools/Config.in"
 	source "package/memtest86/Config.in"
 	source "package/memtester/Config.in"
 	source "package/memtool/Config.in"
package/mdio-tools/Config.in new file +10 -0
new file mode 100644
index 0000000000..8a09bf19a7
@@ -0,0 +1,10 @@
+comment "mdio-tools needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_MDIO_TOOLS
+	bool "mdio-tools"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
+	select BR2_PACKAGE_LIBMNL
+	help
+	  Low-level debug tools for MDIO devices
package/mdio-tools/mdio-tools.hash new file +3 -0
new file mode 100644
index 0000000000..0111165f27
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  c5e17431c62392f6c1da1ba4fb0a6f5918521509a377af74485851f93ff2a106  mdio-tools-1.2.0.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/mdio-tools/mdio-tools.mk new file +20 -0
new file mode 100644
index 0000000000..308a23824b
@@ -0,0 +1,20 @@
+################################################################################
+#
+# mdio-tools
+#
+################################################################################
+
+MDIO_TOOLS_VERSION = 1.2.0
+MDIO_TOOLS_SITE = https://github.com/wkz/mdio-tools/releases/download/$(MDIO_TOOLS_VERSION)
+MDIO_TOOLS_LICENSE = GPL-2.0
+MDIO_TOOLS_LICENSE_FILES = COPYING
+MDIO_TOOLS_DEPENDENCIES = host-pkgconf libmnl
+
+MDIO_TOOLS_MODULE_SUBDIRS = kernel
+define MDIO_TOOLS_LINUX_CONFIG_FIXUPS
+	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MDIO_DEVICE)
+endef
+
+$(eval $(kernel-module))
+$(eval $(autotools-package))
Signature · 6 lines
2.37.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Robert,

Quoted 8 lines · On Thu, 27 Oct 2022 10:56:28 +0200 Robert Marko <[email protected]> wrote:

mdio-tools are kernel module and accompanying tools for low-level debugging of devices attached on MDIO bus like PHY-s, switches etc.

Userspace tools provide C22 or C45 reads and writes, benchmarking and even dedicated Marvell Link Street tools via the included kernel module.

Thanks, I have applied your patch, with two small changes. See below.

Quoted 5 lines
 package/Config.in                  |  1 +
 package/mdio-tools/Config.in       | 10 ++++++++++
 package/mdio-tools/mdio-tools.hash |  3 +++
 package/mdio-tools/mdio-tools.mk   | 20 ++++++++++++++++++++
 4 files changed, 34 insertions(+)

The entry in the DEVELOPERS file was missing, so I've added it.

package/mdio-tools/Config.in line 7

Quoted 13 lines
package/mdio-tools/Config.in new file +7 -0
new file mode 100644
index 0000000000..8a09bf19a7
@@ -0,0 +1,10 @@
+comment "mdio-tools needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_MDIO_TOOLS
+	bool "mdio-tools"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1

We like to have a Config.in comment corresponding to this dependency, so I've added it:

+comment "mdio-tools needs a toolchain w/ headers >= 5.1"
+ depends on !BR2_LINUX_KERNEL
+ depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1

And I know I realize that the depends on !BR2_LINUX_KERNEL should have been a depends on BR2_LINUX_KERNEL. I will fix that up.

Thanks for the contribution!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 46 lines · Thomas Petazzoni

Hello Robert,

Quoted 8 lines · On Thu, 27 Oct 2022 10:56:28 +0200 Robert Marko <[email protected]> wrote:

mdio-tools are kernel module and accompanying tools for low-level debugging of devices attached on MDIO bus like PHY-s, switches etc.

Userspace tools provide C22 or C45 reads and writes, benchmarking and even dedicated Marvell Link Street tools via the included kernel module.

Thanks, I have applied your patch, with two small changes. See below.

Quoted 5 lines
 package/Config.in                  |  1 +
 package/mdio-tools/Config.in       | 10 ++++++++++
 package/mdio-tools/mdio-tools.hash |  3 +++
 package/mdio-tools/mdio-tools.mk   | 20 ++++++++++++++++++++
 4 files changed, 34 insertions(+)

The entry in the DEVELOPERS file was missing, so I've added it.

package/mdio-tools/Config.in line 7

Quoted 13 lines
package/mdio-tools/Config.in new file +7 -0
new file mode 100644
index 0000000000..8a09bf19a7
@@ -0,0 +1,10 @@
+comment "mdio-tools needs a Linux kernel to be built"
+     depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_MDIO_TOOLS
+     bool "mdio-tools"
+     depends on BR2_LINUX_KERNEL
+     depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1

We like to have a Config.in comment corresponding to this dependency, so I've added it:

(quoted diff) +3 -0
+comment "mdio-tools needs a toolchain w/ headers >= 5.1"
+       depends on !BR2_LINUX_KERNEL
+       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
Quoted 2 lines

And I know I realize that the depends on !BR2_LINUX_KERNEL should have been a depends on BR2_LINUX_KERNEL. I will fix that up.

Thanks for fixing it up, it is my first time contributing to Buildroot so its all a bit
new to me.

Regards,
Robert

Quoted 8 lines

Thanks for the contribution!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot