pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c
Subsystems (5)
PATCH 1/1 pinctrl: qcom: Include bitfield.h in pinctrl-lpass-lpi.c
When building ARCH=arm allmodconfig, the following error occurs:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration]
102 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
| ^~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration]
127 | pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
| ^~~~~~~~~
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration]
233 | val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
| ^~~~~~~~~~~~~~~cc1: all warnings being treated as errors
bitfield.h was included via pinctrl-lpass-lpi.h but another change removed that include to restrict what was being included. Add bitfield.h back to pinctrl-lpass-lpi.c, as it is needed there.
--- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +1 -0
@@ -4,6 +4,7 @@* Copyright (c) 2020 Linaro Ltd. */ +#include <linux/bitfield.h> #include <linux/clk.h> #include <linux/gpio/driver.h> #include <linux/module.h>
base-commit: 76f3768132eab2c26c9d67022b452358adc28b2c
Signature · 1 line
2.38.1
Quoted 14 lines · Nathan Chancellor
When building ARCH=arm allmodconfig, the following error occurs:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’:
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration]102 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK); | ^~~~~~~~~~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration] 127 | pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg); | ^~~~~~~~~ drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration] 233 | val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK); | ^~~~~~~~~~~~~~~
Quoted 5 lines
cc1: all warnings being treated as errors
bitfield.hwas included viapinctrl-lpass-lpi.hbut another change removed that include to restrict what was being included. Addbitfield.hback topinctrl-lpass-lpi.c, as it is needed there.
Thanks, https://lore.kernel.org/linux-gpio/[email protected]/
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Nathan Chancellor
When building ARCH=arm allmodconfig, the following error occurs:
I have pushed my version to the tree, so it will appear in the next Linux Next.
Signature · 2 lines
With Best Regards, Andy Shevchenko