dt-bindings: leds: common: add disk write/read and usb-host/usb-gadget
Subsystems (2)
PATCH v3 1/2 dt-bindings: leds: common: add disk write/read and usb-host/usb-gadget
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit.
disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
---
V1 can be seen at https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/
Changes since v1:
- rebased on recent tree
Changes since v2:
- rebased on recent tree
Documentation/devicetree/bindings/leds/common.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/leds/common.yaml +4 -0
@@ -90,6 +90,8 @@ properties: - heartbeat # LED indicates disk activity - disk-activity + - disk-read + - disk-write # LED indicates IDE disk activity (deprecated), in new implementations # use "disk-activity" - ide-disk
@@ -98,6 +100,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + - usb-gadget + - usb-host # LED is triggered by SD/MMC activity - pattern: "^mmc[0-9]+$" - pattern: "^cpu[0-9]*$"
Signature · 1 line
2.37.4
PATCH v4 2/2 leds: remove ide-disk trigger
No user of ide-disk remains, so remove this deprecated trigger. Only a few platforms used this and were fixed in 2016.
---
Change since v1:
- remove also DEFINE_LED_TRIGGER(ledtrig_ide)
Changes since v2:
- Added the fact that few platforms used this and it was fixed old ago.
- Added Rob's ack
V3 can be seen at https://lore.kernel.org/lkml/[email protected]/T/
Changes since v3:
- rebased on recent tree
Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +0 -3
@@ -92,9 +92,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software
drivers/leds/trigger/ledtrig-disk.c +0 -4
@@ -16,7 +16,6 @@DEFINE_LED_TRIGGER (ledtrig_disk);DEFINE_LED_TRIGGER (ledtrig_disk_read);DEFINE_LED_TRIGGER (ledtrig_disk_write); -DEFINE_LED_TRIGGER (ledtrig_ide);void ledtrig_disk_activity (bool write) {
@@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write)led_trigger_blink_oneshot (ledtrig_disk, &blink_delay, &blink_delay,0 ); -led_trigger_blink_oneshot (ledtrig_ide, - &blink_delay, &blink_delay,0 );if (write)led_trigger_blink_oneshot (ledtrig_disk_write, &blink_delay, &blink_delay,0 );
@@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void)led_trigger_register_simple ("disk-activity" , &ledtrig_disk);led_trigger_register_simple ("disk-read" , &ledtrig_disk_read);led_trigger_register_simple ("disk-write" , &ledtrig_disk_write); -led_trigger_register_simple ("ide-disk" , &ledtrig_ide);return 0 ; }
Signature · 1 line
2.37.4
Re: [PATCH v4 2/2] leds: remove ide-disk trigger
Quoted 5 lines · Corentin Labbe
No user of ide-disk remains, so remove this deprecated trigger. Only a few platforms used this and were fixed in 2016.
Acked-by Rob Herring <[email protected]>Signed-off-by Corentin Labbe <[email protected]>
Yours,
Linus Walleij
Quoted 11 lines · Corentin Labbe
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit0cfbd328d60f("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit.disk-read/disk-write were added by commit
d1ed7c558612("leds: Extends disk trigger for reads and writes")Reviewed-by Linus Walleij <[email protected]>Acked-by Rob Herring <[email protected]>Signed-off-by Corentin Labbe <[email protected]>---
Hello
Gentle ping
Regards
Quoted 9 lines · Corentin Labbe
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit0cfbd328d60f("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit.disk-read/disk-write were added by commit
d1ed7c558612("leds: Extends disk trigger for reads and writes")Reviewed-by Linus Walleij <[email protected]>Acked-by Rob Herring <[email protected]>
Hello Pavel Machek and Lee Jones
The two patch are reviewed, could you take them to your tree ?
thanks
Regards
Quoted 6 lines · Corentin LABBE
Quoted 5 lines · Corentin Labbe
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit0cfbd328d60f("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit.
Quoted 8 lines
Quoted 4 lines
disk-read/disk-write were added by commit
d1ed7c558612("leds: Extends disk trigger for reads and writes")Reviewed-by Linus Walleij <[email protected]>Acked-by Rob Herring <[email protected]>Hello Pavel Machek and Lee Jones
The two patch are reviewed, could you take them to your tree ?
If the subsystem maintainers are too busy to respond, maybe you can propose it for merging through the SoC tree? It's a common last way out.
Yours,
Linus Walleij
Lee Jones
maintainerQuoted 6 lines · Corentin LABBE
Quoted 5 lines · Corentin Labbe
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit0cfbd328d60f("usb: Add LED triggers for USB activity") so we add also as valid trigger usb-gadget which was added along in this commit.
Quoted 8 lines
Quoted 4 lines
disk-read/disk-write were added by commit
d1ed7c558612("leds: Extends disk trigger for reads and writes")Reviewed-by Linus Walleij <[email protected]>Acked-by Rob Herring <[email protected]>Hello Pavel Machek and Lee Jones
The two patch are reviewed, could you take them to your tree ?
I do not have access to these patches. Please [RESEND] them.
Signature · 1 line
Lee Jones [李琼斯]