Skip to contentSkip to conversation

net: wwan: t7xx: use union to group port type specific data

PATCH Applied [email protected] 2 participants 2 messages Oct 28, 2022 – Nov 2, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v7 1/2 net: wwan: t7xx: use union to group port type specific data

From: M Chetan Kumar <[email protected]>

Use union inside t7xx_port to group port type specific data members.

--
v7:
* No change.
v5,v6:
* Date correction.

---
 drivers/net/wwan/t7xx/t7xx_port.h      |  6 +++++-
 drivers/net/wwan/t7xx/t7xx_port_wwan.c | 16 ++++++++--------
 2 files changed, 13 insertions(+), 9 deletions(-)
drivers/net/wwan/t7xx/t7xx_port.h +5 -1
index dc4133eb433a..fbc6d724b7c2 100644
@@ -99,7 +99,6 @@ struct t7xx_port_conf {
 struct t7xx_port {
 	/* Members not initialized in definition */
 	const struct t7xx_port_conf	*port_conf;
-	struct wwan_port		*wwan_port;
 	struct t7xx_pci_dev		*t7xx_dev;
 	struct device			*dev;
 	u16				seq_nums[2];	/* TX/RX sequence numbers */
@@ -122,6 +121,11 @@ struct t7xx_port {
 	int				rx_length_th;
 	bool				chan_enable;
 	struct task_struct		*thread;
+	union {
+		struct {
+			struct wwan_port		*wwan_port;
+		} wwan;
+	};
 };
 
 struct sk_buff *t7xx_port_alloc_skb(int payload);
drivers/net/wwan/t7xx/t7xx_port_wwan.c +8 -8
index 33931bfd78fd..24bd21942403 100644
@@ -109,12 +109,12 @@ static int t7xx_port_wwan_init(struct t7xx_port *port)
 
 static void t7xx_port_wwan_uninit(struct t7xx_port *port)
 {
-	if (!port->wwan_port)
+	if (!port->wwan.wwan_port)
 		return;
 
 	port->rx_length_th = 0;
-	wwan_remove_port(port->wwan_port);
-	port->wwan_port = NULL;
+	wwan_remove_port(port->wwan.wwan_port);
+	port->wwan.wwan_port = NULL;
 }
 
 static int t7xx_port_wwan_recv_skb(struct t7xx_port *port, struct sk_buff *skb)
@@ -129,7 +129,7 @@ static int t7xx_port_wwan_recv_skb(struct t7xx_port *port, struct sk_buff *skb)
 		return 0;
 	}
 
-	wwan_port_rx(port->wwan_port, skb);
+	wwan_port_rx(port->wwan.wwan_port, skb);
 	return 0;
 }
 
@@ -158,10 +158,10 @@ static void t7xx_port_wwan_md_state_notify(struct t7xx_port *port, unsigned int
 	if (state != MD_STATE_READY)
 		return;
 
-	if (!port->wwan_port) {
-		port->wwan_port = wwan_create_port(port->dev, port_conf->port_type,
-						   &wwan_ops, port);
-		if (IS_ERR(port->wwan_port))
+	if (!port->wwan.wwan_port) {
+		port->wwan.wwan_port = wwan_create_port(port->dev, port_conf->port_type,
+							&wwan_ops, port);
+		if (IS_ERR(port->wwan.wwan_port))
 			dev_err(port->dev, "Unable to create WWWAN port %s", port_conf->name);
 	}
 }
Signature · 1 line
2.34.1
#1 lore raw
This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 6 lines · On Fri, 28 Oct 2022 21:04:50 +0530 you wrote:

From: M Chetan Kumar <[email protected]>

Use union inside t7xx_port to group port type specific data members.

Quoted 7 lines

--
v7:
* No change.
v5,v6:
* Date correction.

[...]

Here is the summary with links:
- [V7,net-next,1/2] net: wwan: t7xx: use union to group port type specific data

    https://git.kernel.org/netdev/net-next/c/fece7a8c65d1
  - [V7,net-next,2/2] net: wwan: t7xx: Add port for modem logging
    https://git.kernel.org/netdev/net-next/c/3349e4a48acb

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html