Skip to contentSkip to conversation

xfs: new test on xfs with corrupted sb_inopblock

PATCH In review Zorro Lang 2 participants 2 messages Oct 28, 2022

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH v2 1/1 xfs: new test on xfs with corrupted sb_inopblock

There's a known bug fix 392c6de98af1 ("xfs: sanitize sb_inopblock in xfs_mount_validate_sb"). So try to corrupt the sb_inopblock of xfs, to cover this bug.

---

V2 does below changes:
1) Add _fixed_by_kernel_commit ...
2) Repair and check the xfs at the test end

Thanks,
Zorro

 tests/xfs/555     | 32 ++++++++++++++++++++++++++++++++
 tests/xfs/555.out |  6 ++++++
 2 files changed, 38 insertions(+)
 create mode 100755 tests/xfs/555
 create mode 100644 tests/xfs/555.out
tests/xfs/555 new file +32 -0
new file mode 100755
index 00000000..a4024501
@@ -0,0 +1,32 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2022 Red Hat, Inc.  All Rights Reserved.
+#
+# FS QA Test 555
+#
+# Corrupt xfs sb_inopblock, make sure no crash. This's a test coverage of
+# 392c6de98af1 ("xfs: sanitize sb_inopblock in xfs_mount_validate_sb")
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+# real QA test starts here
+_supported_fs xfs
+_fixed_by_kernel_commit 392c6de98af1 \
+	"xfs: sanitize sb_inopblock in xfs_mount_validate_sb"
+_require_scratch
+
+_scratch_mkfs >>$seqres.full
+echo "corrupt inopblock of sb 0"
+_scratch_xfs_set_metadata_field "inopblock" "500" "sb 0" >> $seqres.full
+echo "try to mount ..."
+_try_scratch_mount 2>> $seqres.full && _fail "mount should not succeed!"
+echo "no crash or hang"
+echo "repair corrupted sb 0"
+_scratch_xfs_repair >> $seqres.full 2>&1
+echo "check fs"
+_scratch_xfs_repair -n >> $seqres.full 2>&1 || echo "fs isn't fixed!"
+
+# success, all done
+status=0
+exit
tests/xfs/555.out new file +6 -0
new file mode 100644
index 00000000..4f1b01a2
@@ -0,0 +1,6 @@
+QA output created by 555
+corrupt inopblock of sb 0
+try to mount ...
+no crash or hang
+repair corrupted sb 0
+check fs
Signature · 1 line
2.31.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 33 lines · Zorro Lang

There's a known bug fix 392c6de98af1 ("xfs: sanitize sb_inopblock in xfs_mount_validate_sb"). So try to corrupt the sb_inopblock of xfs, to cover this bug.

---

V2 does below changes:
1) Add _fixed_by_kernel_commit ...
2) Repair and check the xfs at the test end

Thanks,
Zorro

 tests/xfs/555     | 32 ++++++++++++++++++++++++++++++++
 tests/xfs/555.out |  6 ++++++
 2 files changed, 38 insertions(+)
 create mode 100755 tests/xfs/555
 create mode 100644 tests/xfs/555.out
tests/xfs/555 new file +7 -0
new file mode 100755
index 00000000..a4024501
@@ -0,0 +1,32 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2022 Red Hat, Inc.  All Rights Reserved.
+#
+# FS QA Test 555
+#
+# Corrupt xfs sb_inopblock, make sure no crash. This's a test coverage of

tests/xfs/555 line 17

Quoted 10 lines
tests/xfs/555 new file +10 -0
+# 392c6de98af1 ("xfs: sanitize sb_inopblock in xfs_mount_validate_sb")
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+# real QA test starts here
+_supported_fs xfs
+_fixed_by_kernel_commit 392c6de98af1 \
+	"xfs: sanitize sb_inopblock in xfs_mount_validate_sb"
+_require_scratch

This /might/ want a _require_xfs_db_command "write" too, but that might not be necessary since iirc 'write' has been in db for a long time now.

Either way, this test looks ok to me so

--D

Quoted 30 lines
tests/xfs/555 new file +15 -0
+
+_scratch_mkfs >>$seqres.full
+echo "corrupt inopblock of sb 0"
+_scratch_xfs_set_metadata_field "inopblock" "500" "sb 0" >> $seqres.full
+echo "try to mount ..."
+_try_scratch_mount 2>> $seqres.full && _fail "mount should not succeed!"
+echo "no crash or hang"
+echo "repair corrupted sb 0"
+_scratch_xfs_repair >> $seqres.full 2>&1
+echo "check fs"
+_scratch_xfs_repair -n >> $seqres.full 2>&1 || echo "fs isn't fixed!"
+
+# success, all done
+status=0
+exit
tests/xfs/555.out new file +6 -0
new file mode 100644
index 00000000..4f1b01a2
@@ -0,0 +1,6 @@
+QA output created by 555
+corrupt inopblock of sb 0
+try to mount ...
+no crash or hang
+repair corrupted sb 0
+check fs
Signature · 1 line
2.31.1