Skip to contentSkip to conversation

memory-tier-sysfs-rename-attribute-nodes-to-nodelist.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Oct 28, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: memory tier, sysfs: rename attribute "nodes" to "nodelist"
has been removed from the -mm tree. Its filename was
memory-tier-sysfs-rename-attribute-nodes-to-nodelist.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Huang Ying <[email protected]>
Subject: memory tier, sysfs: rename attribute "nodes" to "nodelist"
Date: Thu, 20 Oct 2022 09:51:22 +0800

In sysfs, we use attribute name "cpumap" or "cpus" for cpu mask and "cpulist" or "cpus_list" for cpu list. For example, in my system,

 $ cat /sys/devices/system/node/node0/cpumap
 f,ffffffff
 $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus
 0,00100004
 $ cat cat /sys/devices/system/node/node0/cpulist
 0-35
 $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list
 2,20

It looks reasonable to use "nodemap" for node mask and "nodelist" for node list. So, rename the attribute to follow the naming convention.

Fixes 9832fb87834e2b ("mm/demotion: expose memory tier details via sysfs")
Cc Alistair Popple <[email protected]>
Cc Bharata B Rao <[email protected]>
Cc Dan Williams <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Hesham Almatary <[email protected]>
Cc Jagdish Gediya <[email protected]>
Cc Johannes Weiner <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Tim Chen <[email protected]>

---

Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers renamed from Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers~memory-tier-sysfs-rename-attribute-nodes-to-nodelist +2 -2
@@ -10,7 +10,7 @@ Description:	A collection of all the mem
 
 
 What:		/sys/devices/virtual/memory_tiering/memory_tierN/
-		/sys/devices/virtual/memory_tiering/memory_tierN/nodes
+		/sys/devices/virtual/memory_tiering/memory_tierN/nodelist
 Date:		August 2022
 Contact:	Linux memory management mailing list <[email protected]>
 Description:	Directory with details of a specific memory tier
@@ -21,5 +21,5 @@ Description:	Directory with details of a
 		A smaller value of N implies a higher (faster) memory tier in the
 		hierarchy.
 
-		nodes: NUMA nodes that are part of this memory tier.
+		nodelist: NUMA nodes that are part of this memory tier.
 
mm/memory-tiers.c renamed from mm/memory-tiers.c~memory-tier-sysfs-rename-attribute-nodes-to-nodelist +4 -4
@@ -131,8 +131,8 @@ static void memory_tier_device_release(s
 	kfree(tier);
 }
 
-static ssize_t nodes_show(struct device *dev,
-			  struct device_attribute *attr, char *buf)
+static ssize_t nodelist_show(struct device *dev,
+			     struct device_attribute *attr, char *buf)
 {
 	int ret;
 	nodemask_t nmask;
@@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device
 	mutex_unlock(&memory_tier_lock);
 	return ret;
 }
-static DEVICE_ATTR_RO(nodes);
+static DEVICE_ATTR_RO(nodelist);
 
 static struct attribute *memtier_dev_attrs[] = {
-	&dev_attr_nodes.attr,
+	&dev_attr_nodelist.attr,
 	NULL
 };
 

_

Patches currently in -mm which might be from [email protected] are