Skip to contentSkip to conversation

lib-maple_tree-remove-unneeded-initialization-in-mtree_range_walk.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Oct 28, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: lib: maple_tree: remove unneeded initialization in mtree_range_walk()
has been removed from the -mm tree. Its filename was
lib-maple_tree-remove-unneeded-initialization-in-mtree_range_walk.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Lukas Bulwahn <[email protected]>
Subject: lib: maple_tree: remove unneeded initialization in mtree_range_walk()
Date: Wed, 26 Oct 2022 14:00:29 +0200

Before the do-while loop in mtree_range_walk(), the variables next, min, max need to be initialized. The variables last, prev_min and prev_max are set within the loop body before they are eventually used after exiting the loop body.

As it is a do-while loop, the loop body is executed at least once, so the variables last, prev_min and prev_max do not need to be initialized before the loop body.

Remove unneeded initialization of last and prev_min.

The needless initialization was reported by clang-analyzer as Dead Stores.

As the compiler already identifies these assignments as unneeded, it optimizes the assignments away. Hence:

No functional change. No change in object code.

---

lib/maple_tree.c renamed from lib/maple_tree.c~lib-maple_tree-remove-unneeded-initialization-in-mtree_range_walk +2 -2
@@ -2903,8 +2903,8 @@ static inline void *mtree_range_walk(str
 	unsigned long max, min;
 	unsigned long prev_max, prev_min;
 
-	last = next = mas->node;
-	prev_min = min = mas->min;
+	next = mas->node;
+	min = mas->min;
 	max = mas->max;
 	do {
 		offset = 0;

_

Patches currently in -mm which might be from [email protected] are

mm-shmem-remove-unneeded-assignments-in-shmem_get_folio_gfp.patch